From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40FC5C004C9 for ; Tue, 7 May 2019 18:32:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13E1220656 for ; Tue, 7 May 2019 18:32:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lmSiKhQA"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="n9pn7hTy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13E1220656 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EIWi8JlZCYUy//jdgCYtztZpDzvfRUiT+KMj3rjtxrw=; b=lmSiKhQA6/J5Yg 1Enfa58SPY/NtU6jnj2yql4C/b9nkaFRoFy91LwKyU+FL6PIgWG4XnOoECORNKiVtKzycB3uFy4cr XuVvUOI7li//hUPCaNAA6GYl5J6/ZF4oMlXVSQb4bPMwul70cQ77CXGHii0qfuEBXrdWxlEkdOrCZ A+1eeP8OZWKkraCN+eecmCWq2SSaK0CK6NAVLDZ95wPFz80LEnPHi+s6aioh70A++RUmcTCU8UHaG rYPxsJZvGg8FndhOUFPhpuQUwtcmzIwRo8WAA63ms9qAM2uuMkRH7CgOUiPUagqRF2bbnnEO8rVw5 Or2fo3rn2La/kdNb4wsQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO4tN-0006yp-Ej; Tue, 07 May 2019 18:32:41 +0000 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hO4tJ-0006xv-NC for linux-arm-kernel@lists.infradead.org; Tue, 07 May 2019 18:32:38 +0000 Received: by mail-pf1-x444.google.com with SMTP id v80so9090274pfa.3 for ; Tue, 07 May 2019 11:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=L9NP0SdsXX0ATQ7hd4FjxeMY66WC5qCBDhcE03wlMhQ=; b=n9pn7hTy9KeLWgCDSYDl8ehIiuebJ7aO3nNdFBbXLH37I+1VGfxYiaqMQIEpUnpIPL OOQdkHsKxGosIIg1Ojsclp7fzclPx5QdLp0tpD6V2MRTelH82w79OrWA2Wru3n5SWnjJ btm1yoHLX7jisUvqex0E8XlrfqNKCSXawfT107h9rokUwhcSdHHa1zskeKwDGCDBun08 1dUDRURl+9pcBmyQ7DyV+pOf3nHd9GcXo6wRSEwO50Ispp5PBZuDlVtlSzts/22JsuCq XGOJ5e390VuNE0Qr73SMTMoPyf3dRQ2C3U+4rBMnkzQWgyvLmtUKwmKsYgRgFAovdbO1 EONg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=L9NP0SdsXX0ATQ7hd4FjxeMY66WC5qCBDhcE03wlMhQ=; b=m/xNs9m0/3HWbrDvLx4Il8Po42TydC7DZ8UDT+cWz2iK60htAKtLlFDCxbpzM8cfoM ac9NveyHt4xk+j4lLZ/FJpsosRRLlHwyDeVwNuIKLXf5q9pbiAyKiTEozAaCS5F1eFj1 afXNjS22Tx0EWdZ8731NFq3gBu8t2z5HfLfISU7yDggUKjb84S70XfwnbjAR/zUQZNfS pcmntyZULkeWDF1fhJovO9U33EDwLrm2wqsYEpVVzQxq4mxKpq23/Y3orkmlT/NgdcnZ w5NW+VKmFEiKeRqnCDn66m/qgNl3r1b+kO8+uOhwOhkUKwsKuGtZwJ/oqFKr6J6Hb5o9 qdSA== X-Gm-Message-State: APjAAAVQcKDX+2eYMcmxGiWCngAjZXzihwQ3+x9ZHyTz+CnymXdsIL0H kdDHwiqitVAR+hjyM3ZmaTrqfA== X-Google-Smtp-Source: APXvYqzbS5T0pyt5oyrebrwGtITwJcnl5essJwblVvuBYtzglREQxvzkfbjLim3A//WXRWpXvS7Z3Q== X-Received: by 2002:a63:1654:: with SMTP id 20mr41908345pgw.166.1557253953236; Tue, 07 May 2019 11:32:33 -0700 (PDT) Received: from google.com ([2620:15c:201:2:ce90:ab18:83b0:619]) by smtp.gmail.com with ESMTPSA id f15sm16524993pgf.18.2019.05.07.11.32.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 07 May 2019 11:32:32 -0700 (PDT) Date: Tue, 7 May 2019 11:32:27 -0700 From: Sami Tolvanen To: Mark Rutland Subject: Re: [PATCH v2 3/3] arm64: use the correct function type for __arm64_sys_ni_syscall Message-ID: <20190507183227.GA10191@google.com> References: <20190503191225.6684-1-samitolvanen@google.com> <20190503191225.6684-4-samitolvanen@google.com> <20190507172512.GA35803@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190507172512.GA35803@lakrids.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190507_113237_782643_642EF4F3 X-CRM114-Status: GOOD ( 12.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Catalin Marinas , Nick Desaulniers , linux-kernel@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 07, 2019 at 06:25:12PM +0100, Mark Rutland wrote: > I strongly think that we cant to fix up the common definition in > kernel/sys_ni.c rather than having a point-hack in arm64. Other > architectures (e.g. x86, s390) will want the same for CFI, and I'd like > to ensure that our approached don't diverge. s390 already has the following in arch/s390/kernel/sys_s390.c: SYSCALL_DEFINE0(ni_syscall) { return -ENOSYS; } Which, I suppose, is cleaner than calling sys_ni_syscall. > I took a quick look, and it looks like it's messy but possible to fix > up the core. OK. How would you propose fixing this? Sami _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, T_DKIMWL_WL_MED,USER_AGENT_MUTT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82CDFC04AAD for ; Tue, 7 May 2019 18:32:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 55ED620675 for ; Tue, 7 May 2019 18:32:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="n9pn7hTy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727279AbfEGSce (ORCPT ); Tue, 7 May 2019 14:32:34 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34317 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726653AbfEGSce (ORCPT ); Tue, 7 May 2019 14:32:34 -0400 Received: by mail-pf1-f193.google.com with SMTP id n19so541924pfa.1 for ; Tue, 07 May 2019 11:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=L9NP0SdsXX0ATQ7hd4FjxeMY66WC5qCBDhcE03wlMhQ=; b=n9pn7hTy9KeLWgCDSYDl8ehIiuebJ7aO3nNdFBbXLH37I+1VGfxYiaqMQIEpUnpIPL OOQdkHsKxGosIIg1Ojsclp7fzclPx5QdLp0tpD6V2MRTelH82w79OrWA2Wru3n5SWnjJ btm1yoHLX7jisUvqex0E8XlrfqNKCSXawfT107h9rokUwhcSdHHa1zskeKwDGCDBun08 1dUDRURl+9pcBmyQ7DyV+pOf3nHd9GcXo6wRSEwO50Ispp5PBZuDlVtlSzts/22JsuCq XGOJ5e390VuNE0Qr73SMTMoPyf3dRQ2C3U+4rBMnkzQWgyvLmtUKwmKsYgRgFAovdbO1 EONg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=L9NP0SdsXX0ATQ7hd4FjxeMY66WC5qCBDhcE03wlMhQ=; b=DxWMuzwy2bbvciGUgP79MAC07QsZiCrOZsKZbIlU1aib9vEaAIWAv+1gHKQQyjj9Kq QEzt7iR24bmnfJC6dGD1IrudonkDYwlOo8ObRYPsbYtoVADY3e6RkqAumSZ72iuGXfYo Pq+XwXLe3+IewXnFS6d8fVpBXGozRJWVowOd3HYlk83mfr7YTnh65iNC8P/OLH0vp9co shPCdiAbf5eyvxsYsK/4bjoXlK/t6/hFgXu+pp0k/lqo8/F7DiG2hoMzu59Nx+hd2Vuw xTkGeCZt4TwXRc1Fg3dsQ2S8MUUJJt0Aq9A3XTdUV76zrirx3oI31ypESYble+Sj+haC EJ+w== X-Gm-Message-State: APjAAAUJUba05ePabn53bbbvEki1akH7y/gqU1BY2wn5hkNMX4iRg6XM fUjLsLW8RXc/ErsdR+9E3U+Rog== X-Google-Smtp-Source: APXvYqzbS5T0pyt5oyrebrwGtITwJcnl5essJwblVvuBYtzglREQxvzkfbjLim3A//WXRWpXvS7Z3Q== X-Received: by 2002:a63:1654:: with SMTP id 20mr41908345pgw.166.1557253953236; Tue, 07 May 2019 11:32:33 -0700 (PDT) Received: from google.com ([2620:15c:201:2:ce90:ab18:83b0:619]) by smtp.gmail.com with ESMTPSA id f15sm16524993pgf.18.2019.05.07.11.32.32 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 07 May 2019 11:32:32 -0700 (PDT) Date: Tue, 7 May 2019 11:32:27 -0700 From: Sami Tolvanen To: Mark Rutland Cc: Catalin Marinas , Will Deacon , Kees Cook , Nick Desaulniers , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] arm64: use the correct function type for __arm64_sys_ni_syscall Message-ID: <20190507183227.GA10191@google.com> References: <20190503191225.6684-1-samitolvanen@google.com> <20190503191225.6684-4-samitolvanen@google.com> <20190507172512.GA35803@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190507172512.GA35803@lakrids.cambridge.arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 07, 2019 at 06:25:12PM +0100, Mark Rutland wrote: > I strongly think that we cant to fix up the common definition in > kernel/sys_ni.c rather than having a point-hack in arm64. Other > architectures (e.g. x86, s390) will want the same for CFI, and I'd like > to ensure that our approached don't diverge. s390 already has the following in arch/s390/kernel/sys_s390.c: SYSCALL_DEFINE0(ni_syscall) { return -ENOSYS; } Which, I suppose, is cleaner than calling sys_ni_syscall. > I took a quick look, and it looks like it's messy but possible to fix > up the core. OK. How would you propose fixing this? Sami