Re: [patch 0/4] SPDX: First batch of patches

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, May 07, 2019 at 08:43:44PM +0200, Thomas Gleixner wrote:
> On Tue, 7 May 2019, Greg KH wrote:
> > On Tue, May 07, 2019 at 04:19:35PM +0200, Thomas Gleixner wrote:
> > > On Tue, 7 May 2019, Greg KH wrote:
> > > > On Tue, May 07, 2019 at 02:19:52PM +0200, Thomas Gleixner wrote:
> > > > > Hi!
> > > > > 
> > > > > As promised here are the first 4 automatically generated patches. Each
> > > > > patch handles exactly one match pattern (rule).
> > > > > 
> > > > > While reviewing the patch (actual code change) might be massively time
> > > > > consuming, the quick and important part is to look at the patterns and
> > > > > verify whether the license conclusion is correct. The tooling which
> > > > > replaces exactly those patterns is pretty solid by now. But if you really
> > > > > insists on looking at each individual file change, you're welcome. :)
> > > > > 
> > > > > Note that some of the patterns contain obscure things like:
> > > > > 
> > > > >      [no]_[pad]_[ctrl]
> > > > > 
> > > > > in the middle. This one is a clear copy and paste artifact which happens to
> > > > > be in arch/arm/mach-imx/iomux-mx35.h:
> > > > > 
> > > > >  * of the License, or (at your option, NO_PAD_CTRL) any later version.
> > > > > 
> > > > > Oh well.....
> > > > 
> > > > What's the diffstat of all 4 of these patches?  How many files are you
> > > > fixing up here?
> > > 
> > > Oops. Forgot to add that.
> > > 
> > >       305 files changed, 311 insertions(+), 2789 deletions(-)
> > 
> > Nice, but I would have expected more files to be touched here :)
> 
> It's 4 out of 514 patches on the step2 branch.
> 
> step1-3 result with all patches applied in:
> 
>  24524 files changed, 24721 insertions(+), 184320 deletions(-)

That's better :)

> > Anyway, these all look good to me.  I'm guessing the subject lines will
> > be tweaked.  If there's anything I can do to run the script and send out
> > patches, please let me know.
> 
> You have a big enough machine?

I think I do:
	$ free -h
	              total        used        free      shared  buff/cache   available
	Mem:          118Gi       994Mi       113Gi       1.0Mi       3.3Gi       115Gi
	Swap:         4.0Gi          0B       4.0Gi

It's what I do my stable kernel build testing on :)

Anyway, glad to help out if you want me to.

greg k-h