From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A20C04A6B for ; Wed, 8 May 2019 06:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFC3D214C6 for ; Wed, 8 May 2019 06:46:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557297972; bh=LNTBuQLqm/k3K4ljnbiGKzOTXlT/9CKFErF49BWifc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=p83NW4PPBG7gjRwlPDGFmy7jO8LmSJ6fBRdeF/bPR+MW0iu9qpacG+W2grr7kH+/L M8TXw5hAEZ/BYQ8J5tHxpAL/I27IAIEsFG183OOCtbK0aCgYOfZQqzaa/O927wph5G zLyxtalNY+aAmm2CJyQHJfOjHvYmiJDoCirM5oqM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726628AbfEHGqL (ORCPT ); Wed, 8 May 2019 02:46:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:59886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726527AbfEHGqL (ORCPT ); Wed, 8 May 2019 02:46:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 224D320989; Wed, 8 May 2019 06:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557297970; bh=LNTBuQLqm/k3K4ljnbiGKzOTXlT/9CKFErF49BWifc0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MVHOtJ9hq2gaPuxmsJQJrbaKZRmNltrc6VRKcLiiPgZfe8R516rQekpBcReN1BxR8 Ws3LTb9L+UDEdQ6ux4CphmYWPLG6hjBU6T9zggRFCVG5XAE4H7KXaX/7kVOGzHM164 DMFlXZWKPc3VNfy3DQ5rpDDJ1LDdISjtfgjWPHuE= Date: Wed, 8 May 2019 08:46:08 +0200 From: Greg KH To: Thomas Gleixner Cc: linux-spdx@vger.kernel.org Subject: Re: [patch 0/4] SPDX: First batch of patches Message-ID: <20190508064608.GC21796@kroah.com> References: <20190507121952.495564307@linutronix.de> <20190507141746.GA28384@kroah.com> <20190507181435.GB13061@kroah.com> <20190507185816.GC17205@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-spdx-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spdx@vger.kernel.org On Wed, May 08, 2019 at 08:25:51AM +0200, Thomas Gleixner wrote: > Greg, > > On Tue, 7 May 2019, Greg KH wrote: > > > > Anyway, glad to help out if you want me to. > > Running the scripts is one thing. The more important thing is to figure out > how we are going to review these patches and agree that the conclusion is > correct. Ideally we have lots of Reviewed-by's on each of them. > > Yes, it's 500+ and some of them are really large, but the point is that at > least in my opinion it's enough to carefully review the 'normalized' > patterns which are in the change log. > > I have some postprocessing checks (not yet in utils) which verify that > author/copyright notices which are in the middle of the removed crap are > preserved. > > The other issue which I worked on yesterday night (krobot finding a few > corner cases where the patcher did not handle some odd comment formatting > correctly) should be gone. I just started a new full run to verify that. > > Apropos changelog. You said they need some care. If you check out the utils > repo, there are templates in the step2/3 directories and the subdirectories > of step1. If you could work on them that would be appreciated. What repo are you referring to? Did I miss a link somewhere? thanks, greg k-h