All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Wang <liwang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] libltpnuma: remove restrictions on numa node-id
Date: Wed,  8 May 2019 16:44:47 +0800	[thread overview]
Message-ID: <20190508084447.18191-2-liwang@redhat.com> (raw)
In-Reply-To: <20190508084447.18191-1-liwang@redhat.com>

For some ppc64le systems, it has non-continuous numa nodes in
hardware configuration. So we're hitting the below warnings while
running set_mempolicy tests on that. To fix this issue, let's just
remove restrictions on numa node-id in get_mempolicy().

Error Log
---------
tst_test.c:1096: INFO: Timeout per run is 0h 50m 00s
tst_numa.c:190: INFO: Found 2 NUMA memory nodes
set_mempolicy01.c:63: PASS: set_mempolicy(MPOL_BIND) node 0
tst_numa.c:26: INFO: Node 0 allocated 16 pages
tst_numa.c:26: INFO: Node 8 allocated 0 pages
set_mempolicy01.c:82: PASS: child: Node 0 allocated 16
set_mempolicy01.c:63: PASS: set_mempolicy(MPOL_BIND) node 8
tst_numa.c:92: WARN: get_mempolicy(...) returned invalid node 8
tst_numa.c:92: WARN: get_mempolicy(...) returned invalid node 8
tst_numa.c:92: WARN: get_mempolicy(...) returned invalid node 8
...
tst_numa.c:26: INFO: Node 0 allocated 0 pages
tst_numa.c:26: INFO: Node 8 allocated 0 pages
set_mempolicy01.c:86: FAIL: child: Node 8 allocated 0, expected 16

lscpu
-----
Architecture:        ppc64le
...
CPU(s):              128
Core(s) per socket:  16
Socket(s):           2
NUMA node(s):        2
Model name:          POWER9, altivec supported
...
NUMA node0 CPU(s):   0-63
NUMA node8 CPU(s):   64-127

Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Cyril Hrubis <chrubis@suse.cz>
---
 libs/libltpnuma/tst_numa.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/libs/libltpnuma/tst_numa.c b/libs/libltpnuma/tst_numa.c
index 0ba6daf39..56c8640ff 100644
--- a/libs/libltpnuma/tst_numa.c
+++ b/libs/libltpnuma/tst_numa.c
@@ -88,8 +88,9 @@ void tst_nodemap_count_pages(struct tst_nodemap *nodes,
 		if (ret < 0)
 			tst_brk(TBROK | TERRNO, "get_mempolicy() failed");
 
-		if (node < 0 || (unsigned int)node >= nodes->cnt) {
-			tst_res(TWARN, "get_mempolicy(...) returned invalid node %i\n", node);
+		if (node < 0) {
+			tst_res(TWARN,
+				"get_mempolicy(...) returned invalid node %i\n", node);
 			continue;
 		}
 
-- 
2.20.1


  reply	other threads:[~2019-05-08  8:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08  8:44 [LTP] [PATCH v2 1/2] numa: fix numa test error with non-continuous nodes Li Wang
2019-05-08  8:44 ` Li Wang [this message]
2019-05-09  6:45   ` [LTP] [PATCH v2 2/2] libltpnuma: remove restrictions on numa node-id Balamuruhan S
2019-05-09  8:00     ` Li Wang
2019-05-09  9:23       ` Balamuruhan S
2019-05-09 15:50     ` Jan Stancek
2019-05-14 14:30     ` Cyril Hrubis
2019-05-09  7:16 ` [LTP] [PATCH v2 1/2] numa: fix numa test error with non-continuous nodes Balamuruhan S
2019-05-09  7:54   ` Li Wang
2019-05-09  9:19     ` Balamuruhan S
2019-05-09 10:00       ` Li Wang
2019-05-14 15:06         ` Cyril Hrubis
2021-11-10 10:54           ` Richard Palethorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508084447.18191-2-liwang@redhat.com \
    --to=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.