From: Lee Jones <lee.jones@linaro.org>
To: Daniel Gomez <dagmcr@gmail.com>
Cc: linux-kernel@vger.kernel.org, javier@dowhile0.org
Subject: Re: [PATCH] spi: TI power management: add missing of table registration
Date: Wed, 8 May 2019 11:27:01 +0100 [thread overview]
Message-ID: <20190508102701.GI3995@dell> (raw)
In-Reply-To: <1555960190-8645-1-git-send-email-dagmcr@gmail.com>
The subject line is not correct. This is an MFD driver.
When submitting you should follow the convention for the subsystem you
are patching against. The following command is helpful:
`git log --oneline -- <SUBSYSTEM>`
I will fix it for you this time (and for the other patch I see).
On Mon, 22 Apr 2019, Daniel Gomez wrote:
> MODULE_DEVICE_TABLE(of, <of_match_table> should be called to complete DT
> OF mathing mechanism and register it.
>
> Before this patch:
> modinfo drivers/mfd/tps65912-spi.ko | grep alias
> alias: spi:tps65912
>
> After this patch:
> modinfo drivers/mfd/tps65912-spi.ko | grep alias
> alias: of:N*T*Cti,tps65912C*
> alias: of:N*T*Cti,tps65912
> alias: spi:tps65912
>
> Reported-by: Javier Martinez Canillas <javier@dowhile0.org>
> Signed-off-by: Daniel Gomez <dagmcr@gmail.com>
> ---
> drivers/mfd/tps65912-spi.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-05-08 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-22 19:09 [PATCH] spi: TI power management: add missing of table registration Daniel Gomez
2019-05-08 10:27 ` Lee Jones [this message]
2019-05-11 8:28 ` Daniel G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508102701.GI3995@dell \
--to=lee.jones@linaro.org \
--cc=dagmcr@gmail.com \
--cc=javier@dowhile0.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.