From: Masami Hiramatsu <mhiramat@kernel.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Andreas Ziegler <andreas.ziegler@fau.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 3/3] tracing: probeevent: Fix to make the type of $comm string
Date: Wed, 8 May 2019 12:24:03 +0900 [thread overview]
Message-ID: <20190508122403.73cce014a6f7d66e0835e2be@kernel.org> (raw)
In-Reply-To: <20190507174758.1D5FA205C9@mail.kernel.org>
On Tue, 07 May 2019 17:47:57 +0000
Sasha Levin <sashal@kernel.org> wrote:
> Hi,
>
> [This is an automated email]
>
> This commit has been processed because it contains a "Fixes:" tag,
> fixing commit: 35abb67de744 tracing: expose current->comm to [ku]probe events.
>
> The bot has tested the following trees: v5.0.13, v4.19.40, v4.14.116, v4.9.173.
>
> v5.0.13: Build OK!
> v4.19.40: Failed to apply! Possible dependencies:
> 40b53b771806 ("tracing: probeevent: Add array type support")
> 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
> 56de76305279 ("tracing: probeevent: Cleanup print argument functions")
> 60c2e0cebfd0 ("tracing: probeevent: Add symbol type")
> eeb07b061500 ("tracing: probeevent: Cleanup argument field definition")
> f451bc89d835 ("tracing: probeevent: Unify fetch type tables")
>
> v4.14.116: Failed to apply! Possible dependencies:
> 40b53b771806 ("tracing: probeevent: Add array type support")
> 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function")
> 4bebdc7a85aa ("bpf: add helper bpf_perf_prog_read_value")
> 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
> 60c2e0cebfd0 ("tracing: probeevent: Add symbol type")
> 908432ca84fc ("bpf: add helper bpf_perf_event_read_value for perf event array map")
> 97562633bcba ("bpf: perf event change needed for subsequent bpf helpers")
> 9802d86585db ("bpf: add a bpf_override_function helper")
> b4da3340eae2 ("tracing/kprobe: bpf: Check error injectable event is on function entry")
> cd86d1fd2102 ("bpf: Adding helper function bpf_getsockops")
> dd0bb688eaa2 ("bpf: add a bpf_override_function helper")
> de8f3a83b0a0 ("bpf: add meta pointer for direct access")
> f3edacbd697f ("bpf: Revert bpf_overrid_function() helper changes.")
> f451bc89d835 ("tracing: probeevent: Unify fetch type tables")
>
> v4.9.173: Failed to apply! Possible dependencies:
> 17bedab27231 ("bpf: xdp: Allow head adjustment in XDP prog")
> 1d9995771fcb ("s390: update defconfigs")
> 23a4e389bdc7 ("nfp: create separate define for max number of vectors")
> 40b53b771806 ("tracing: probeevent: Add array type support")
> 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function")
> 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code")
> 60c2e0cebfd0 ("tracing: probeevent: Add symbol type")
> 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme")
> 68453c7a8973 ("nfp: centralize runtime reconfiguration logic")
> 6b0b7551428e ("perf/core: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS")
> 7ff5c83a1deb ("nfp: simplify nfp_net_poll()")
> 9802d86585db ("bpf: add a bpf_override_function helper")
> a4b562bb8ebd ("nfp: use unsigned int for vector/ring counts")
> b4da3340eae2 ("tracing/kprobe: bpf: Check error injectable event is on function entry")
> cbeaf7aa733a ("nfp: bring back support for different ring counts")
> ccc109b8ed24 ("net/mlx4_en: Add TX_XDP for CQ types")
> dd0bb688eaa2 ("bpf: add a bpf_override_function helper")
> e390b55d5aef ("bpf: make bpf_xdp_adjust_head support mandatory")
> ecd63a0217d5 ("nfp: add XDP support in the driver")
> f18f97ac43d7 ("tracing/kprobes: Add a helper method to return number of probe hits")
> f3edacbd697f ("bpf: Revert bpf_overrid_function() helper changes.")
> f451bc89d835 ("tracing: probeevent: Unify fetch type tables")
>
>
> How should we proceed with this patch?
>
Thanks for the report! I missed the Fixes tag. I realized that the comm type
check was done in other place in older kernel. This bug was introduced by
commit 533059281ee5 ("tracing: probeevent: Introduce new argument fetching code").
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2019-05-08 3:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 13:55 [PATCH v3 0/3] tracing: probeevent: Fix probe argument parser and handler Masami Hiramatsu
2019-05-07 13:55 ` [PATCH v3 1/3] tracing: uprobes: Re-enable $comm support for uprobe events Masami Hiramatsu
2019-05-07 13:55 ` [PATCH v3 2/3] tracing: probeevent: Do not accumulate on ret variable Masami Hiramatsu
2019-05-07 13:56 ` [PATCH v3 3/3] tracing: probeevent: Fix to make the type of $comm string Masami Hiramatsu
[not found] ` <20190507174758.1D5FA205C9@mail.kernel.org>
2019-05-08 3:24 ` Masami Hiramatsu [this message]
2019-05-08 3:29 ` Steven Rostedt
2019-05-08 4:57 ` Masami Hiramatsu
2019-05-08 2:10 ` [PATCH v3 0/3] tracing: probeevent: Fix probe argument parser and handler Steven Rostedt
2019-05-08 4:59 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508122403.73cce014a6f7d66e0835e2be@kernel.org \
--to=mhiramat@kernel.org \
--cc=andreas.ziegler@fau.de \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.