From: Cleber Rosa <crosa@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PULL 10/19] tests/boot_linux_console: increase timeout
Date: Wed, 8 May 2019 10:39:53 -0400 [thread overview]
Message-ID: <20190508143953.GA32662@localhost.localdomain> (raw)
In-Reply-To: <20190508102824.ysts2k4xesxzmh67@sirius.home.kraxel.org>
On Wed, May 08, 2019 at 12:28:24PM +0200, Gerd Hoffmann wrote:
> On Thu, May 02, 2019 at 09:41:21PM -0300, Eduardo Habkost wrote:
> > From: Cleber Rosa <crosa@redhat.com>
> >
> > When running on very low powered environments, some tests may time out
> > causing false negatives. As a conservative change, and for
> > considering that human time (investigating false negatives) is worth
> > more than some extra machine cycles (and time), let's increase the
> > overall timeout.
>
> Tests can also timeout due to slow downloads of test kernels.
> Any chance to run the downloads without timeout?
I acknowledge this is an issue, and have thought about two possible
ways to solve it:
1) Downloading/caching/checking all the test assets in a job "pre-tests"
plugin. This would involve/require:
- https://trello.com/c/WPd4FrIy/1479-add-support-to-specify-assets-in-test-docstring
- https://trello.com/c/CKP7YS6G/1481-on-cache-check-for-asset-fetcher
2) Report the test phase (say, setUp()) to the test runner, which
would allow the runner to:
- Not take that time into account for the test (similar to
https://github.com/avocado-framework/avocado/pull/3076)
- Retry the setUp a number of times (if the test opts in or doesn't
opt out)
I'm very much interested in your opinion so we can evolve the idea into
implementation.
Thanks!
- Cleber
>
> cheers,
> Gerd
>
next prev parent reply other threads:[~2019-05-08 14:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 0:41 [Qemu-devel] [PULL 00/19] Python queue, 2019-05-02 Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 01/19] tests/acceptance: show avocado test execution by default Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 02/19] tests/acceptance: improve docstring on pick_default_qemu_bin() Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 03/19] tests/acceptance: fix doc reference to avocado_qemu directory Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 04/19] tests/acceptance: introduce arch parameter and attribute Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 05/19] tests/acceptance: use "arch:" tag to filter target specific tests Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 06/19] tests/acceptance: look for target architecture in test tags first Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 07/19] tests/boot_linux_console: rename the x86_64 after the arch and machine Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 08/19] tests/boot_linux_console: update the x86_64 kernel Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 09/19] tests/boot_linux_console: add common kernel command line options Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 10/19] tests/boot_linux_console: increase timeout Eduardo Habkost
2019-05-08 10:28 ` Gerd Hoffmann
2019-05-08 14:39 ` Cleber Rosa [this message]
2019-05-09 4:40 ` Gerd Hoffmann
2019-05-09 18:12 ` Cleber Rosa
2019-05-10 6:06 ` Gerd Hoffmann
2019-05-03 0:41 ` [Qemu-devel] [PULL 11/19] tests/boot_linux_console: refactor the console watcher into utility method Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 12/19] scripts/qemu.py: support adding a console with the default serial device Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 13/19] tests/boot_linux_console: add a test for mips + malta Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 14/19] tests/boot_linux_console: add a test for mips64el " Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 15/19] tests/boot_linux_console: add a test for aarch64 + virt Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 16/19] tests/boot_linux_console: add a test for arm " Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 17/19] tests/boot_linux_console: add a test for s390x + s390-ccw-virtio Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 18/19] tests/boot_linux_console: add a test for alpha + clipper Eduardo Habkost
2019-05-03 0:41 ` [Qemu-devel] [PULL 19/19] configure: automatically pick python3 is available Eduardo Habkost
2019-05-03 16:41 ` Thomas Huth
2019-05-03 16:54 ` Daniel P. Berrangé
2019-05-03 16:54 ` Daniel P. Berrangé
2019-05-03 16:56 ` Daniel P. Berrangé
2019-05-03 16:56 ` Daniel P. Berrangé
2019-05-03 17:04 ` Philippe Mathieu-Daudé
2019-05-04 6:41 ` Thomas Huth
2019-05-04 6:41 ` Thomas Huth
2019-05-03 21:00 ` Eduardo Habkost
2019-05-03 21:00 ` Eduardo Habkost
2019-05-03 21:34 ` Eduardo Habkost
2019-05-03 21:34 ` Eduardo Habkost
2019-05-04 7:17 ` Thomas Huth
2019-05-04 7:17 ` Thomas Huth
2019-05-03 15:02 ` [Qemu-devel] [PULL 00/19] Python queue, 2019-05-02 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508143953.GA32662@localhost.localdomain \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.