All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote
Date: Wed, 8 May 2019 19:43:10 +0200	[thread overview]
Message-ID: <20190508194310.23789f8e@gmx.net> (raw)
In-Reply-To: <87ef59l84u.fsf@dell.be.48ers.dk>

Hello *,

On Wed, 08 May 2019 09:26:09 +0200, Peter Korsgaard <peter@korsgaard.com> wrote:

> >>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
>
>  > On 07/05/2019 23:02, Peter Korsgaard wrote:
>  >>>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
>  >>
>  >> > Hello Peter,
>  >> > On Tue,  7 May 2019 22:35:21 +0200
>  >> > Peter Seiderer <ps.report@gmx.net> wrote:
>  >>
>  >> >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>  >> >> ---
>  >> >> package/assimp/assimp.mk | 2 +-
>  >> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>  >>
>  >> > Thanks for all those patches. I think it would be useful to extend the
>  >> > check-package logic to check that such UTF-8 quotes/spaces don't get
>  >> > re-added.
>  >>
>  >> Agreed!
>
>  >  I think in Config.in, *.mk and *.hash we should never need any non-ascii
>  > character, so that check would be easy.

First draft, checking only the .mk files, just sent out, see [1]...

>
> I am not so sure about Config.in. If you look at:
>
> package/intel-mediasdk/Config.in
> package/imagemagick/Config.in
> package/zeromq/Config.in
> package/directfb/Config.in
>
> They have UTF-8 copyright characters, a funny e in bezier and the OE in
> zeromq.
>

- do not check (and keep as is)
- whitelist for some special characters (per file?)
- convert to plain ascii, e.g: (R), bezier, zeromq (without the specail zero)...

Regards,
Peter

[1] https://patchwork.ozlabs.org/patch/1097166/

  reply	other threads:[~2019-05-08 17:43 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-07 20:35 [Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote by ascii single quote Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 02/28] package/ffmpeg: replace utf-8 space by ascii character Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 03/28] package/libglu: replace utf-8 apostrophe by ascii single quote Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 04/28] package/libopenssl: replace utf-8 quote " Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 05/28] package/qemu: replace utf-8 space by ascii character Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 06/28] package/reaver: " Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 07/28] package/sysklogd: " Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 08/28] package/tekui: " Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 09/28] package/vde2: " Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 10/28] package/capnproto: replace utf-8 apostrophe by ascii single quote Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 11/28] package/collectd: replace utf-8 quote " Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 12/28] package/jemalloc: eplace utf-8 space by ascii character Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 13/28] package/libunwind: replace " Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 14/28] package/madplay: replace utf-8 hyphen by ascii hyphen Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 15/28] package/mksh: replace utf-8 apostrophe by ascii single quote Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 16/28] package/mpfr: replace utf-8 space by ascii character Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 17/28] package/pngquant: replace utf-8 hyphen by ascii hyphen Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 18/28] package/python-gunicorn: replace utf-8 quote by ascii single quote Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 19/28] package/python-idna: " Peter Seiderer
2019-05-07 20:35 ` [Buildroot] [PATCH v1 20/28] package/python-mutagen: replace utf-8 apostrophe " Peter Seiderer
2019-05-07 20:52 ` [Buildroot] [PATCH v1 01/28] package/assimp: replace utf-8 quote " Thomas Petazzoni
2019-05-07 21:02   ` Peter Korsgaard
2019-05-07 23:17     ` Arnout Vandecappelle
2019-05-08  7:26       ` Peter Korsgaard
2019-05-08 17:43         ` Peter Seiderer [this message]
2019-05-07 21:03 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190508194310.23789f8e@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.