From: Sasha Levin <sashal@kernel.org>
To: Dexuan Cui <decui@microsoft.com>
Cc: Adrian Vladu <avladu@cloudbasesolutions.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Alessandro Pilotti <apilotti@cloudbasesolutions.com>
Subject: Re: [PATCH v2] hv: tools: fixed Python pep8/flake8 warnings for lsvmbus
Date: Wed, 8 May 2019 21:09:41 -0400 [thread overview]
Message-ID: <20190509010941.GT1747@sasha-vm> (raw)
In-Reply-To: <PU1P153MB016957AD2B1C356FA1BFB1A8BF310@PU1P153MB0169.APCP153.PROD.OUTLOOK.COM>
On Tue, May 07, 2019 at 05:02:47AM +0000, Dexuan Cui wrote:
>> From: Adrian Vladu <avladu@cloudbasesolutions.com>
>> Sent: Monday, May 6, 2019 10:34 AM
>> To: linux-kernel@vger.kernel.org
>> Cc: Adrian Vladu <avladu@cloudbasesolutions.com>; KY Srinivasan
>> <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Stephen
>> Hemminger <sthemmin@microsoft.com>; Sasha Levin <sashal@kernel.org>;
>> Dexuan Cui <decui@microsoft.com>; Alessandro Pilotti
>> <apilotti@cloudbasesolutions.com>
>> Subject: [PATCH v2] hv: tools: fixed Python pep8/flake8 warnings for lsvmbus
>>
>> Fixed pep8/flake8 python style code for lsvmbus tool.
>>
>> The TAB indentation was on purpose ignored (pep8 rule W191) to make
>> sure the code is complying with the Linux code guideline.
>> The following command do not show any warnings now:
>> pep8 --ignore=W191 lsvmbus
>> flake8 --ignore=W191 lsvmbus
>>
>> Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
>>
>> Cc: "K. Y. Srinivasan" <kys@microsoft.com>
>> Cc: Haiyang Zhang <haiyangz@microsoft.com>
>> Cc: Stephen Hemminger <sthemmin@microsoft.com>
>> Cc: Sasha Levin <sashal@kernel.org>
>> Cc: Dexuan Cui <decui@microsoft.com>
>> Cc: Alessandro Pilotti <apilotti@cloudbasesolutions.com>
[...]
>Looks good to me. Thanks, Adrian!
>
>Reviewed-by: Dexuan Cui <decui@microsoft.com>
Queued for hyperv-fixes, thanks!
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-05-09 1:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-06 17:27 [PATCH] hv: tools: fixed Python pep8/flake8 warnings for lsvmbus Adrian Vladu
2019-05-06 17:33 ` [PATCH v2] " Adrian Vladu
2019-05-07 5:02 ` Dexuan Cui
2019-05-09 1:09 ` Sasha Levin [this message]
2019-07-30 14:53 ` Adrian Vladu
2019-07-30 22:25 ` Sasha Levin
2019-07-31 8:51 ` Adrian Vladu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509010941.GT1747@sasha-vm \
--to=sashal@kernel.org \
--cc=apilotti@cloudbasesolutions.com \
--cc=avladu@cloudbasesolutions.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.