From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D172C04AB1 for ; Thu, 9 May 2019 07:12:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E2BC621019 for ; Thu, 9 May 2019 07:12:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=onstation.org header.i=@onstation.org header.b="T6AQPGcd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726476AbfEIHMp (ORCPT ); Thu, 9 May 2019 03:12:45 -0400 Received: from onstation.org ([52.200.56.107]:57424 "EHLO onstation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726192AbfEIHMp (ORCPT ); Thu, 9 May 2019 03:12:45 -0400 Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: masneyb) by onstation.org (Postfix) with ESMTPSA id 57C7A3E93E; Thu, 9 May 2019 07:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=onstation.org; s=default; t=1557385963; bh=Jb3P351PcNcvj6RN68GVuceqLFPSl29qLpr7PA9LBkI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=T6AQPGcd6DudjY2velB/ZZ5XXAJ8cIHX9sjlYmzwHNrit2iKxINLDAugSQrGe+HHD qkHUXbu/zRWVy6kdw6TAJuJ2CFoOWcrVg251Dfo8Px+nsp+C48v6w4oP5+Jf3xuFcB IPJUj1RpNsNKuGEE2VzV59bh7KMGuIuk8yZI2dIs= Date: Thu, 9 May 2019 03:12:43 -0400 From: Brian Masney To: Bjorn Andersson Cc: Rob Clark , Sean Paul , dri-devel , linux-arm-msm , freedreno , David Airlie , Daniel Vetter , Linux Kernel Mailing List , Linus Walleij Subject: Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support Message-ID: <20190509071243.GA27143@basecamp> References: <20190505130413.32253-1-masneyb@onstation.org> <20190505130413.32253-5-masneyb@onstation.org> <20190507063902.GA2085@tuxbook-pro> <20190509021616.GA26228@basecamp> <20190509030047.GE2085@tuxbook-pro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190509030047.GE2085@tuxbook-pro> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, May 08, 2019 at 08:00:47PM -0700, Bjorn Andersson wrote: > On Wed 08 May 19:25 PDT 2019, Rob Clark wrote: > > > On Wed, May 8, 2019 at 7:16 PM Brian Masney wrote: > > > > > > On Mon, May 06, 2019 at 11:39:02PM -0700, Bjorn Andersson wrote: > > > > On Sun 05 May 06:04 PDT 2019, Brian Masney wrote: > > > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi > > > > [..] > > > > > + clocks = <&mmcc MDSS_MDP_CLK>, > > > > > + <&mmcc MDSS_AHB_CLK>, > > > > > + <&mmcc MDSS_AXI_CLK>, > > > > > + <&mmcc MDSS_BYTE0_CLK>, > > > > > + <&mmcc MDSS_PCLK0_CLK>, > > > > > + <&mmcc MDSS_ESC0_CLK>, > > > > > + <&mmcc MMSS_MISC_AHB_CLK>; > > > > > + clock-names = "mdp_core", > > > > > + "iface", > > > > > + "bus", > > > > > + "byte", > > > > > + "pixel", > > > > > + "core", > > > > > + "core_mmss"; > > > > > > > > Unless I enable MMSS_MMSSNOC_AXI_CLK and MMSS_S0_AXI_CLK I get some > > > > underrun error from DSI. You don't see anything like this? > > > > > > > > (These clocks are controlled by msm_bus downstream and should be driven > > > > by interconnect upstream) > > > > > > > > > > > > Apart from this, I think this looks nice. Happy to see the progress. > > > > > > No, I'm not seeing an underrun errors from the DSI. I think the clocks > > > are fine since I'm able to get this working with 4.17 using these same > > > clocks. I just sent out v2 and the cover letter has some details, along > > > with the full dmesg. > > > > since we don't have interconnect driver for 8974, I guess there is > > some chance that things work or not based on how lk leaves things? > > > > Right, I guess the bootloader on my device does not leave the busses > ticking - perhaps there's a boot splash involved on Brian's device? > > Regardless, this works on Nexus 5 and allows Brian to make further > progress so I'm all for merging it. There is a boot splash on the Nexus 5 and that may explain a behavior that I observed. I attempted to add reset GPIO support to the simple panel driver and the screen will clear but nothing will come on the screen after a hard reset, even on 4.17. To be sure, I got the timing information for how long to leave the GPIO high and low from the downstream MSM 3.4 sources. That's when I had a script port all of the ~400 panel on commands in the downstream device tree to a new panel driver. With the latest kernel kernel having a delay showing the console text, I observe a brief second where the boot splash is shown along with the startup text from Linux. A full refresh is performed and the boot splash goes away. I don't see this with the 4.17 kernel; perhaps maybe the full refresh occurs quick enough that its not noticeable. Can you point me to where the interconnect API is in the downstream MSM 3.4 sources? https://github.com/AICP/kernel_lge_hammerhead It looks like its in drivers/interconnect/ in the upstream sources. Brian From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Masney Subject: Re: [PATCH RFC 4/6] ARM: dts: msm8974: add display support Date: Thu, 9 May 2019 03:12:43 -0400 Message-ID: <20190509071243.GA27143@basecamp> References: <20190505130413.32253-1-masneyb@onstation.org> <20190505130413.32253-5-masneyb@onstation.org> <20190507063902.GA2085@tuxbook-pro> <20190509021616.GA26228@basecamp> <20190509030047.GE2085@tuxbook-pro> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190509030047.GE2085@tuxbook-pro> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Bjorn Andersson Cc: Sean Paul , David Airlie , linux-arm-msm , Linus Walleij , Linux Kernel Mailing List , dri-devel , Rob Clark , Daniel Vetter , freedreno List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXkgMDgsIDIwMTkgYXQgMDg6MDA6NDdQTSAtMDcwMCwgQmpvcm4gQW5kZXJzc29u IHdyb3RlOgo+IE9uIFdlZCAwOCBNYXkgMTk6MjUgUERUIDIwMTksIFJvYiBDbGFyayB3cm90ZToK PiAKPiA+IE9uIFdlZCwgTWF5IDgsIDIwMTkgYXQgNzoxNiBQTSBCcmlhbiBNYXNuZXkgPG1hc25l eWJAb25zdGF0aW9uLm9yZz4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIE1vbiwgTWF5IDA2LCAyMDE5 IGF0IDExOjM5OjAyUE0gLTA3MDAsIEJqb3JuIEFuZGVyc3NvbiB3cm90ZToKPiA+ID4gPiBPbiBT dW4gMDUgTWF5IDA2OjA0IFBEVCAyMDE5LCBCcmlhbiBNYXNuZXkgd3JvdGU6Cj4gPiA+ID4gPiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvcWNvbS1tc204OTc0LmR0c2kgYi9hcmNoL2Fy bS9ib290L2R0cy9xY29tLW1zbTg5NzQuZHRzaQo+ID4gPiA+IFsuLl0KPiA+ID4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICBjbG9ja3MgPSA8Jm1tY2MgTURTU19NRFBfQ0xLPiwKPiA+ ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8Jm1tY2MgTURTU19B SEJfQ0xLPiwKPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8 Jm1tY2MgTURTU19BWElfQ0xLPiwKPiA+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICA8Jm1tY2MgTURTU19CWVRFMF9DTEs+LAo+ID4gPiA+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIDwmbW1jYyBNRFNTX1BDTEswX0NMSz4sCj4gPiA+ID4g PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPCZtbWNjIE1EU1NfRVNDMF9D TEs+LAo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwmbW1j YyBNTVNTX01JU0NfQUhCX0NMSz47Cj4gPiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgY2xvY2stbmFtZXMgPSAibWRwX2NvcmUiLAo+ID4gPiA+ID4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgImlmYWNlIiwKPiA+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJidXMiLAo+ID4gPiA+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImJ5dGUiLAo+ID4gPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInBpeGVsIiwKPiA+ID4gPiA+ICsgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjb3JlIiwKPiA+ID4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJjb3JlX21tc3MiOwo+ID4g PiA+Cj4gPiA+ID4gVW5sZXNzIEkgZW5hYmxlIE1NU1NfTU1TU05PQ19BWElfQ0xLIGFuZCBNTVNT X1MwX0FYSV9DTEsgSSBnZXQgc29tZQo+ID4gPiA+IHVuZGVycnVuIGVycm9yIGZyb20gRFNJLiBZ b3UgZG9uJ3Qgc2VlIGFueXRoaW5nIGxpa2UgdGhpcz8KPiA+ID4gPgo+ID4gPiA+IChUaGVzZSBj bG9ja3MgYXJlIGNvbnRyb2xsZWQgYnkgbXNtX2J1cyBkb3duc3RyZWFtIGFuZCBzaG91bGQgYmUg ZHJpdmVuCj4gPiA+ID4gYnkgaW50ZXJjb25uZWN0IHVwc3RyZWFtKQo+ID4gPiA+Cj4gPiA+ID4K PiA+ID4gPiBBcGFydCBmcm9tIHRoaXMsIEkgdGhpbmsgdGhpcyBsb29rcyBuaWNlLiBIYXBweSB0 byBzZWUgdGhlIHByb2dyZXNzLgo+ID4gPgo+ID4gPiBObywgSSdtIG5vdCBzZWVpbmcgYW4gdW5k ZXJydW4gZXJyb3JzIGZyb20gdGhlIERTSS4gSSB0aGluayB0aGUgY2xvY2tzCj4gPiA+IGFyZSBm aW5lIHNpbmNlIEknbSBhYmxlIHRvIGdldCB0aGlzIHdvcmtpbmcgd2l0aCA0LjE3IHVzaW5nIHRo ZXNlIHNhbWUKPiA+ID4gY2xvY2tzLiBJIGp1c3Qgc2VudCBvdXQgdjIgYW5kIHRoZSBjb3ZlciBs ZXR0ZXIgaGFzIHNvbWUgZGV0YWlscywgYWxvbmcKPiA+ID4gd2l0aCB0aGUgZnVsbCBkbWVzZy4K PiA+IAo+ID4gc2luY2Ugd2UgZG9uJ3QgaGF2ZSBpbnRlcmNvbm5lY3QgZHJpdmVyIGZvciA4OTc0 LCBJIGd1ZXNzIHRoZXJlIGlzCj4gPiBzb21lIGNoYW5jZSB0aGF0IHRoaW5ncyB3b3JrIG9yIG5v dCBiYXNlZCBvbiBob3cgbGsgbGVhdmVzIHRoaW5ncz8KPiA+IAo+IAo+IFJpZ2h0LCBJIGd1ZXNz IHRoZSBib290bG9hZGVyIG9uIG15IGRldmljZSBkb2VzIG5vdCBsZWF2ZSB0aGUgYnVzc2VzCj4g dGlja2luZyAtIHBlcmhhcHMgdGhlcmUncyBhIGJvb3Qgc3BsYXNoIGludm9sdmVkIG9uIEJyaWFu J3MgZGV2aWNlPwo+IAo+IFJlZ2FyZGxlc3MsIHRoaXMgd29ya3Mgb24gTmV4dXMgNSBhbmQgYWxs b3dzIEJyaWFuIHRvIG1ha2UgZnVydGhlcgo+IHByb2dyZXNzIHNvIEknbSBhbGwgZm9yIG1lcmdp bmcgaXQuCgpUaGVyZSBpcyBhIGJvb3Qgc3BsYXNoIG9uIHRoZSBOZXh1cyA1IGFuZCB0aGF0IG1h eSBleHBsYWluIGEgYmVoYXZpb3IKdGhhdCBJIG9ic2VydmVkLiBJIGF0dGVtcHRlZCB0byBhZGQg cmVzZXQgR1BJTyBzdXBwb3J0IHRvIHRoZSBzaW1wbGUKcGFuZWwgZHJpdmVyIGFuZCB0aGUgc2Ny ZWVuIHdpbGwgY2xlYXIgYnV0IG5vdGhpbmcgd2lsbCBjb21lIG9uIHRoZQpzY3JlZW4gYWZ0ZXIg YSBoYXJkIHJlc2V0LCBldmVuIG9uIDQuMTcuIFRvIGJlIHN1cmUsIEkgZ290IHRoZSB0aW1pbmcK aW5mb3JtYXRpb24gZm9yIGhvdyBsb25nIHRvIGxlYXZlIHRoZSBHUElPIGhpZ2ggYW5kIGxvdyBm cm9tIHRoZQpkb3duc3RyZWFtIE1TTSAzLjQgc291cmNlcy4gVGhhdCdzIHdoZW4gSSBoYWQgYSBz Y3JpcHQgcG9ydCBhbGwgb2YgdGhlCn40MDAgcGFuZWwgb24gY29tbWFuZHMgaW4gdGhlIGRvd25z dHJlYW0gZGV2aWNlIHRyZWUgdG8gYSBuZXcgcGFuZWwKZHJpdmVyLgoKV2l0aCB0aGUgbGF0ZXN0 IGtlcm5lbCBrZXJuZWwgaGF2aW5nIGEgZGVsYXkgc2hvd2luZyB0aGUgY29uc29sZSB0ZXh0LApJ IG9ic2VydmUgYSBicmllZiBzZWNvbmQgd2hlcmUgdGhlIGJvb3Qgc3BsYXNoIGlzIHNob3duIGFs b25nIHdpdGggdGhlCnN0YXJ0dXAgdGV4dCBmcm9tIExpbnV4LiBBIGZ1bGwgcmVmcmVzaCBpcyBw ZXJmb3JtZWQgYW5kIHRoZSBib290CnNwbGFzaCBnb2VzIGF3YXkuIEkgZG9uJ3Qgc2VlIHRoaXMg d2l0aCB0aGUgNC4xNyBrZXJuZWw7IHBlcmhhcHMgbWF5YmUKdGhlIGZ1bGwgcmVmcmVzaCBvY2N1 cnMgcXVpY2sgZW5vdWdoIHRoYXQgaXRzIG5vdCBub3RpY2VhYmxlLgoKQ2FuIHlvdSBwb2ludCBt ZSB0byB3aGVyZSB0aGUgaW50ZXJjb25uZWN0IEFQSSBpcyBpbiB0aGUgZG93bnN0cmVhbQpNU00g My40IHNvdXJjZXM/IGh0dHBzOi8vZ2l0aHViLmNvbS9BSUNQL2tlcm5lbF9sZ2VfaGFtbWVyaGVh ZApJdCBsb29rcyBsaWtlIGl0cyBpbiBkcml2ZXJzL2ludGVyY29ubmVjdC8gaW4gdGhlIHVwc3Ry ZWFtIHNvdXJjZXMuCgpCcmlhbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9m cmVlZHJlbm8=