From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: Amit Shah <amit@kernel.org>,
Kashyap Chamarthy <kchamart@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org,
"Richard W . M . Jones" <rjones@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [RFC] rng-random: allow to use getrandom()
Date: Thu, 9 May 2019 14:29:31 +0100 [thread overview]
Message-ID: <20190509132931.GY31299@redhat.com> (raw)
In-Reply-To: <20190509132234.22103-1-lvivier@redhat.com>
On Thu, May 09, 2019 at 03:22:34PM +0200, Laurent Vivier wrote:
> Add a parameter to select the rng-random backend mode,
> from a file or from qemu_guest_getrandom():
>
> -object rng-random,id=rng0,mode=file or
> -object rng-random,id=rng0,mode=getrandom
>
> by default mode is file
I don't really see any benefit in overloading the existing rng-random
object with a completely different impl. There are already two distinct
backends, so we should just add a third "rng-builtin" which uses the
QEMU built-in APIs for collecting rand data.
This makes it trivial to detect support for this feature by simply
looking for existance of the new object class.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2019-05-09 13:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 13:22 [Qemu-devel] [RFC] rng-random: allow to use getrandom() Laurent Vivier
2019-05-09 13:29 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509132931.GY31299@redhat.com \
--to=berrange@redhat.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=kchamart@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.