From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>
Subject: Re: [PATCH net-next 00/11] net: stmmac: Selftests
Date: Thu, 9 May 2019 20:00:05 +0200 [thread overview]
Message-ID: <20190509180005.GA16272@Red> (raw)
In-Reply-To: <78EB27739596EE489E55E81C33FEC33A0B47AC7F@DE02WEMBXB.internal.synopsys.com>
On Thu, May 09, 2019 at 10:11:53AM +0000, Jose Abreu wrote:
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Thu, May 09, 2019 at 10:04:16
>
> > What means 1 for "Perfect Filter UC" ?
>
> Thank you for the testing :)
>
> 1 means that either the expected packet was not received or that the
> filter did not work.
>
> For GMAC there is the need to set the HPF bit in order for the test to
> pass. Do you have such bit in your HW ? It should be in EMAC_RX_FRM_FLT
> register.
The problem was missing IFF_UNICAST_FLT, so netcore put the device in promiscous when adding an unicast address.
Next step will be to enable Flow Control, but I will start a new thread for that.
>
> > I have added my patch below
>
> Do you want me to add your patch to the series ? If you send me with
> git-send-email I can apply it with your SoB.
>
I will do.
I will send the patch for IFF_UNICAST_FLT appart since it fixes a bug.
Regards
prev parent reply other threads:[~2019-05-09 18:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 7:51 [PATCH net-next 00/11] net: stmmac: Selftests Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 01/11] net: stmmac: Add MAC loopback callback to HWIF Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 02/11] net: stmmac: dwmac100: Add MAC loopback support Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 03/11] net: stmmac: dwmac1000: " Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 04/11] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 05/11] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 06/11] net: stmmac: Switch MMC functions to HWIF callbacks Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 07/11] net: stmmac: dwmac1000: Also pass control frames while in promisc mode Jose Abreu
2019-05-08 12:04 ` Andrew Lunn
2019-05-08 14:53 ` Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 08/11] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 09/11] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 10/11] net: stmmac: Introduce selftests support Jose Abreu
2019-05-09 2:23 ` Andrew Lunn
2019-05-09 8:25 ` Jose Abreu
2019-05-09 12:21 ` Andrew Lunn
2019-05-09 15:11 ` Jose Abreu
2019-05-08 7:51 ` [PATCH net-next 11/11] net: stmmac: dwmac1000: Fix Hash Filter Jose Abreu
2019-05-08 15:46 ` [PATCH net-next 00/11] net: stmmac: Selftests David Miller
2019-05-08 19:50 ` Andrew Lunn
2019-05-09 8:17 ` Jose Abreu
2019-05-09 16:05 ` Jose Abreu
2019-05-09 9:04 ` Corentin Labbe
2019-05-09 10:11 ` Jose Abreu
2019-05-09 18:00 ` Corentin Labbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509180005.GA16272@Red \
--to=clabbe.montjoie@gmail.com \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.