From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A5DC04AB1 for ; Thu, 9 May 2019 19:08:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D63B20656 for ; Thu, 9 May 2019 19:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557428882; bh=wX84Yw04EcHoKPJ42rtdSkVbSZ/pUfHQ31PdzNRHkY8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=IrAMpAUSC+miRg81zxLokqvekEyB7EyLmJiwJbkJmkGfFzGV4NT9IxUjpCalGLtBQ Wn/g+dGjTHxDs8J7ehz+ESRHgAx8B15FJvYL8hOeO8BN0zB4ZbIal/wBTdm7tgBmJr LD85m3LzQaS8NYJ8AlqHzpd6TXyDyaPeVFbJJmck= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbfEITIB (ORCPT ); Thu, 9 May 2019 15:08:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:37296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727330AbfEISp0 (ORCPT ); Thu, 9 May 2019 14:45:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 506982183E; Thu, 9 May 2019 18:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427525; bh=wX84Yw04EcHoKPJ42rtdSkVbSZ/pUfHQ31PdzNRHkY8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PDsj5BYMmUv1ru6OPoXDOJ9GAQk7JEiNczmojL+HQ/6ecNRC3lC2SR/LBpaUUkGm3 M9nMybStJgSftfxwbOgNTWVtJr/Y4PEWuGXKDt8LJCf21K4nakSfJvXGJg7e+Tz4ot GVK/DMG0GAdAb3O9vnbwEn2N5iakZAAuM+KMnoP4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , CK Hu , Sasha Levin Subject: [PATCH 4.14 15/42] drm/mediatek: Fix an error code in mtk_hdmi_dt_parse_pdata() Date: Thu, 9 May 2019 20:42:04 +0200 Message-Id: <20190509181255.733941862@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181252.616018683@linuxfoundation.org> References: <20190509181252.616018683@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 2d85978341e6a32e7443d9f28639da254d53f400 ] We don't want to overwrite "ret", it already holds the correct error code. The "regmap" variable might be a valid pointer as this point. Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support") Signed-off-by: Dan Carpenter Signed-off-by: CK Hu Signed-off-by: Sasha Levin --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index aba27ea9cea5c..a33a1918463de 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c @@ -1473,7 +1473,6 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi, if (IS_ERR(regmap)) ret = PTR_ERR(regmap); if (ret) { - ret = PTR_ERR(regmap); dev_err(dev, "Failed to get system configuration registers: %d\n", ret); -- 2.20.1