From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 108FAC04AB1 for ; Thu, 9 May 2019 18:45:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DAD892184B for ; Thu, 9 May 2019 18:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427548; bh=z6EV2YqeNqyzk6UyHzkUV9Ct71LipZFSYBUnn+0Bhao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o9RAclaeiWTLXC1tB5flSukCJS9A9QW8qUveC+Ol9cLUFk+gp5B8WYIUtB/NJUjRc mxz+2EhDdLWdnBMtFbEKI5CO2FYGuL9B3/ytIPBYxo28YNNrARQHyAushETNCv0MaZ lg2fI7y+pCEhOcvWVjZqdCShs4rzFONUCSMtl3zI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727417AbfEISpr (ORCPT ); Thu, 9 May 2019 14:45:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:37714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfEISpo (ORCPT ); Thu, 9 May 2019 14:45:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3818E21848; Thu, 9 May 2019 18:45:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427543; bh=z6EV2YqeNqyzk6UyHzkUV9Ct71LipZFSYBUnn+0Bhao=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W2aeFfTcTG+NdkazBuxnfAQcPDchAExi8md8nkV4CYFfhx5FrMhHLwNeeBCspNiDu jh225zk/mDsM3p9tGJy/PVUlv1Qb8sbCcvLyZdPecbX/SuekQ9SsFwykIsv2DCcc6V 701nK7sUZdGvOwRhS2qbk090FS74zzHppEkB00F0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qian Cai , "Tobin C. Harding" , Tejun Heo , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.14 21/42] slab: fix a crash by reading /proc/slab_allocators Date: Thu, 9 May 2019 20:42:10 +0200 Message-Id: <20190509181256.958774323@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181252.616018683@linuxfoundation.org> References: <20190509181252.616018683@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit fcf88917dd435c6a4cb2830cb086ee58605a1d85 ] The commit 510ded33e075 ("slab: implement slab_root_caches list") changes the name of the list node within "struct kmem_cache" from "list" to "root_caches_node", but leaks_show() still use the "list" which causes a crash when reading /proc/slab_allocators. You need to have CONFIG_SLAB=y and CONFIG_MEMCG=y to see the problem, because without MEMCG all slab caches are root caches, and the "list" node happens to be the right one. Fixes: 510ded33e075 ("slab: implement slab_root_caches list") Signed-off-by: Qian Cai Reviewed-by: Tobin C. Harding Cc: Tejun Heo Cc: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- mm/slab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/slab.c b/mm/slab.c index f4658468b23e1..843ecea9e336b 100644 --- a/mm/slab.c +++ b/mm/slab.c @@ -4299,7 +4299,8 @@ static void show_symbol(struct seq_file *m, unsigned long address) static int leaks_show(struct seq_file *m, void *p) { - struct kmem_cache *cachep = list_entry(p, struct kmem_cache, list); + struct kmem_cache *cachep = list_entry(p, struct kmem_cache, + root_caches_node); struct page *page; struct kmem_cache_node *n; const char *name; -- 2.20.1