From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF0F2C04AB1 for ; Thu, 9 May 2019 18:47:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1703217F5 for ; Thu, 9 May 2019 18:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427639; bh=WE7DH8v4uGIWCVhMwzNdRbqkimb09nk1+twnWPRqxgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eigsU1a8iDI6Niv6oN9YJIGfOhqbqOXri7JgL2Jdbsx1Od3diwQw/qNREc0GSw/bs DfnDwga93X+/CgNvaJILRh82OoqsJwiIZY09nVYU0/WqnTCr/b/WO0RKGn7+nVUbvU ibw1u1Vgo/g4iNtMGA1fom2xbI5wgzXqis4ZOvrw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727796AbfEISrS (ORCPT ); Thu, 9 May 2019 14:47:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:39824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727769AbfEISrQ (ORCPT ); Thu, 9 May 2019 14:47:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAFC1217F9; Thu, 9 May 2019 18:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427636; bh=WE7DH8v4uGIWCVhMwzNdRbqkimb09nk1+twnWPRqxgg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hq+Wu8uWbSbS9mNkoKHrqEUpRjxDrsfyu7na0jH42aaqlDJXjoQh7CX/EktJ4CjaF 1ihQMpf9SgLhUY+V7ywbNj6iY9GAcDkfMfZ46pXyl0PxHY8dZ3i8xV23drr122j4Fz aS2gg72nEDzNbt1QfHpztUBVo0cl6b2bcrZ7ht7M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Suresh Udipi , Eugeniu Rosca , Christian Gromm Subject: [PATCH 4.19 06/66] staging: most: cdev: fix chrdev_region leak in mod_exit Date: Thu, 9 May 2019 20:41:41 +0200 Message-Id: <20190509181302.485638271@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181301.719249738@linuxfoundation.org> References: <20190509181301.719249738@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suresh Udipi commit af708900e9a48c0aa46070c8a8cdf0608a1d2025 upstream. It looks like v4.18-rc1 commit [0] which upstreams mld-1.8.0 commit [1] missed to fix the memory leak in mod_exit function. Do it now. [0] aba258b7310167 ("staging: most: cdev: fix chrdev_region leak") [1] https://github.com/microchip-ais/linux/commit/a2d8f7ae7ea381 ("staging: most: cdev: fix leak for chrdev_region") Signed-off-by: Suresh Udipi Signed-off-by: Eugeniu Rosca Acked-by: Christian Gromm Fixes: aba258b73101 ("staging: most: cdev: fix chrdev_region leak") Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/staging/most/cdev/cdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/most/cdev/cdev.c +++ b/drivers/staging/most/cdev/cdev.c @@ -546,7 +546,7 @@ static void __exit mod_exit(void) destroy_cdev(c); destroy_channel(c); } - unregister_chrdev_region(comp.devno, 1); + unregister_chrdev_region(comp.devno, CHRDEV_REGION_SIZE); ida_destroy(&comp.minor_id); class_destroy(comp.class); }