From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA46CC04AB1 for ; Thu, 9 May 2019 19:02:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8446F2177E for ; Thu, 9 May 2019 19:02:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557428577; bh=JK/5JR/7YtZJJUdPo/D55Ry48Dg3sEHVwCpXds88SSM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=qizTKjb/uehNJEZBuXe9UfwYNogiFdhINNym1QjzAXwBeQN7GvSkGBjWiK4gB92gm CFeIzrZpKlz18rjgeuHtQsbdW8Wu/Vc6FyRM6nY+RTVPdsnOVjeTvlSFQrRzVPmRBA ugkksDcUg2yTcTEvErwX8InK3gf60hV0+Dy9OqtQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727162AbfEITCz (ORCPT ); Thu, 9 May 2019 15:02:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:43158 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727533AbfEIStp (ORCPT ); Thu, 9 May 2019 14:49:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1795217F9; Thu, 9 May 2019 18:49:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557427785; bh=JK/5JR/7YtZJJUdPo/D55Ry48Dg3sEHVwCpXds88SSM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LrvBmYII/stieGFHLq2YpoBYXua7a5XW/C5R2LmGU97CYxls3Mytwt18po2J8NHIO gdYDp6naEPWvz+YFKsbaZxpm6UpH1X1kxqD5cRc7U+/c2Rd65ue3adp1yoNJYrXGVb k4Jjj2QxIflIgwv+wxMyEBrug02sSnLMrWwfGnIk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Joerg Roedel , Sasha Levin Subject: [PATCH 4.19 49/66] iommu/amd: Set exclusion range correctly Date: Thu, 9 May 2019 20:42:24 +0200 Message-Id: <20190509181306.879324525@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190509181301.719249738@linuxfoundation.org> References: <20190509181301.719249738@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 3c677d206210f53a4be972211066c0f1cd47fe12 ] The exlcusion range limit register needs to contain the base-address of the last page that is part of the range, as bits 0-11 of this register are treated as 0xfff by the hardware for comparisons. So correctly set the exclusion range in the hardware to the last page which is _in_ the range. Fixes: b2026aa2dce44 ('x86, AMD IOMMU: add functions for programming IOMMU MMIO space') Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/amd_iommu_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c index be3801d43d48b..3a1d30304f7e9 100644 --- a/drivers/iommu/amd_iommu_init.c +++ b/drivers/iommu/amd_iommu_init.c @@ -356,7 +356,7 @@ static void iommu_write_l2(struct amd_iommu *iommu, u8 address, u32 val) static void iommu_set_exclusion_range(struct amd_iommu *iommu) { u64 start = iommu->exclusion_start & PAGE_MASK; - u64 limit = (start + iommu->exclusion_length) & PAGE_MASK; + u64 limit = (start + iommu->exclusion_length - 1) & PAGE_MASK; u64 entry; if (!iommu->exclusion_start) -- 2.20.1