All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raul Rangel <rrangel@chromium.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mmc@vger.kernel.org, djkurtz@google.com,
	adrian.hunter@intel.com, zwisler@chromium.org,
	linux-kernel@vger.kernel.org,
	Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH 1/2] mmc: v4.14: Fix null pointer dereference in mmc_init_request
Date: Thu, 9 May 2019 12:42:34 -0600	[thread overview]
Message-ID: <20190509184234.GA197434@google.com> (raw)
In-Reply-To: <20190509060456.GA17096@infradead.org>

On Wed, May 08, 2019 at 11:04:56PM -0700, Christoph Hellwig wrote:
> On Wed, May 08, 2019 at 12:58:32PM -0600, Raul E Rangel wrote:
> > It is possible for queuedata to be cleared in mmc_cleanup_queue before
> > the request has been started.
> 
> Errm.  I think we need to fix that problem instead of working around it.
So mmc_request_fn already has a null check, it was just missing on
mmc_init_request.

I could move `blk_cleanup_queue(q)` above `q->queuedata = NULL` and the
lock. So that would mean cherry-picking
https://lore.kernel.org/patchwork/patch/856512/ and then a patch with
moving blk_cleanup_queue.

Should I do that instead?

Thanks,
Raul

  reply	other threads:[~2019-05-09 18:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-08 18:58 [PATCH 1/2] mmc: v4.14: Fix null pointer dereference in mmc_init_request Raul E Rangel
2019-05-08 18:58 ` [PATCH 2/2] mmc: v4.14: Kill the request if the queuedata has been removed Raul E Rangel
2019-05-09  6:04 ` [PATCH 1/2] mmc: v4.14: Fix null pointer dereference in mmc_init_request Christoph Hellwig
2019-05-09 18:42   ` Raul Rangel [this message]
2019-05-13 17:19     ` Raul Rangel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190509184234.GA197434@google.com \
    --to=rrangel@chromium.org \
    --cc=adrian.hunter@intel.com \
    --cc=djkurtz@google.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=zwisler@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.