From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Thu, 9 May 2019 20:30:28 +0200 From: Halil Pasic Subject: Re: [PATCH 09/10] virtio/s390: use DMA memory for ccw I/O and classic notifiers In-Reply-To: References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-10-pasic@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20190509203028.5b75eaa2.pasic@linux.ibm.com> Sender: kvm-owner@vger.kernel.org List-Archive: List-Post: To: Pierre Morel Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, Cornelia Huck , Martin Schwidefsky , Sebastian Ott , virtualization@lists.linux-foundation.org, "Michael S. Tsirkin" , Christoph Hellwig , Thomas Huth , Christian Borntraeger , Viktor Mihajlovski , Vasily Gorbik , Janosch Frank , Claudio Imbrenda , Farhan Ali , Eric Farman List-ID: On Thu, 9 May 2019 15:30:08 +0200 Pierre Morel wrote: > On 08/05/2019 16:46, Pierre Morel wrote: > > On 26/04/2019 20:32, Halil Pasic wrote: > >> Before virtio-ccw could get away with not using DMA API for the pieces of > >> memory it does ccw I/O with. With protected virtualization this has to > >> change, since the hypervisor needs to read and sometimes also write these > >> pieces of memory. > >> > >> The hypervisor is supposed to poke the classic notifiers, if these are > >> used, out of band with regards to ccw I/O. So these need to be allocated > >> as DMA memory (which is shared memory for protected virtualization > >> guests). > >> > >> Let us factor out everything from struct virtio_ccw_device that needs to > >> be DMA memory in a satellite that is allocated as such. > >> > ... > >> +                       sizeof(indicators(vcdev))); > > > > should be sizeof(long) ? If something different then sizeof(u64) IMHO. > > > > This is a recurrent error, but it is not an issue because the size of > > the indicators is unsigned long as the size of the pointer. I don't think there is an error, let alone a recurrent one. > > > > Regards, > > Pierre > > > > Here too, with the problem of the indicator size handled: I've laid out my view in a response to your comment on patch #8. > Reviewed-by: Pierre Morel Thanks! Halil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Halil Pasic Subject: Re: [PATCH 09/10] virtio/s390: use DMA memory for ccw I/O and classic notifiers Date: Thu, 9 May 2019 20:30:28 +0200 Message-ID: <20190509203028.5b75eaa2.pasic@linux.ibm.com> References: <20190426183245.37939-1-pasic@linux.ibm.com> <20190426183245.37939-10-pasic@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Pierre Morel Cc: Vasily Gorbik , linux-s390@vger.kernel.org, Thomas Huth , Claudio Imbrenda , kvm@vger.kernel.org, Sebastian Ott , "Michael S. Tsirkin" , Cornelia Huck , Eric Farman , virtualization@lists.linux-foundation.org, Christoph Hellwig , Martin Schwidefsky , Farhan Ali , Viktor Mihajlovski , Janosch Frank List-Id: virtualization@lists.linuxfoundation.org T24gVGh1LCA5IE1heSAyMDE5IDE1OjMwOjA4ICswMjAwClBpZXJyZSBNb3JlbCA8cG1vcmVsQGxp bnV4LmlibS5jb20+IHdyb3RlOgoKPiBPbiAwOC8wNS8yMDE5IDE2OjQ2LCBQaWVycmUgTW9yZWwg d3JvdGU6Cj4gPiBPbiAyNi8wNC8yMDE5IDIwOjMyLCBIYWxpbCBQYXNpYyB3cm90ZToKPiA+PiBC ZWZvcmUgdmlydGlvLWNjdyBjb3VsZCBnZXQgYXdheSB3aXRoIG5vdCB1c2luZyBETUEgQVBJIGZv ciB0aGUgcGllY2VzIG9mCj4gPj4gbWVtb3J5IGl0IGRvZXMgY2N3IEkvTyB3aXRoLiBXaXRoIHBy b3RlY3RlZCB2aXJ0dWFsaXphdGlvbiB0aGlzIGhhcyB0bwo+ID4+IGNoYW5nZSwgc2luY2UgdGhl IGh5cGVydmlzb3IgbmVlZHMgdG8gcmVhZCBhbmQgc29tZXRpbWVzIGFsc28gd3JpdGUgdGhlc2UK PiA+PiBwaWVjZXMgb2YgbWVtb3J5Lgo+ID4+Cj4gPj4gVGhlIGh5cGVydmlzb3IgaXMgc3VwcG9z ZWQgdG8gcG9rZSB0aGUgY2xhc3NpYyBub3RpZmllcnMsIGlmIHRoZXNlIGFyZQo+ID4+IHVzZWQs IG91dCBvZiBiYW5kIHdpdGggcmVnYXJkcyB0byBjY3cgSS9PLiBTbyB0aGVzZSBuZWVkIHRvIGJl IGFsbG9jYXRlZAo+ID4+IGFzIERNQSBtZW1vcnkgKHdoaWNoIGlzIHNoYXJlZCBtZW1vcnkgZm9y IHByb3RlY3RlZCB2aXJ0dWFsaXphdGlvbgo+ID4+IGd1ZXN0cykuCj4gPj4KPiA+PiBMZXQgdXMg ZmFjdG9yIG91dCBldmVyeXRoaW5nIGZyb20gc3RydWN0IHZpcnRpb19jY3dfZGV2aWNlIHRoYXQg bmVlZHMgdG8KPiA+PiBiZSBETUEgbWVtb3J5IGluIGEgc2F0ZWxsaXRlIHRoYXQgaXMgYWxsb2Nh dGVkIGFzIHN1Y2guCj4gPj4KPiAuLi4KPiA+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgc2l6ZW9mKGluZGljYXRvcnModmNkZXYpKSk7Cj4gPiAKPiA+IHNo b3VsZCBiZSBzaXplb2YobG9uZykgPwoKSWYgc29tZXRoaW5nIGRpZmZlcmVudCB0aGVuIHNpemVv Zih1NjQpIElNSE8uCj4gPiAKPiA+IFRoaXMgaXMgYSByZWN1cnJlbnQgZXJyb3IsIGJ1dCBpdCBp cyBub3QgYW4gaXNzdWUgYmVjYXVzZSB0aGUgc2l6ZSBvZgo+ID4gdGhlIGluZGljYXRvcnMgaXMg dW5zaWduZWQgbG9uZyBhcyB0aGUgc2l6ZSBvZiB0aGUgcG9pbnRlci4KCkkgZG9uJ3QgdGhpbmsg dGhlcmUgaXMgYW4gZXJyb3IsIGxldCBhbG9uZSBhIHJlY3VycmVudCBvbmUuCgo+ID4gCj4gPiBS ZWdhcmRzLAo+ID4gUGllcnJlCj4gPiAKPiAKPiBIZXJlIHRvbywgd2l0aCB0aGUgcHJvYmxlbSBv ZiB0aGUgaW5kaWNhdG9yIHNpemUgaGFuZGxlZDoKCkkndmUgbGFpZCBvdXQgbXkgdmlldyBpbiBh IHJlc3BvbnNlIHRvIHlvdXIgY29tbWVudCBvbiBwYXRjaCAjOC4KCj4gUmV2aWV3ZWQtYnk6IFBp ZXJyZSBNb3JlbDxwbW9yZWxAbGludXguaWJtLmNvbT4KClRoYW5rcyEKSGFsaWwKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1h aWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRw czovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXph dGlvbg==