From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.9 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id AE99E7D2EF for ; Fri, 10 May 2019 04:50:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726967AbfEJEu4 (ORCPT ); Fri, 10 May 2019 00:50:56 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:43736 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726284AbfEJEu4 (ORCPT ); Fri, 10 May 2019 00:50:56 -0400 Received: from callcc.thunk.org ([66.31.38.53]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x4A4livR031694 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 May 2019 00:47:45 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id 11AEE420024; Fri, 10 May 2019 00:47:44 -0400 (EDT) Date: Fri, 10 May 2019 00:47:43 -0400 From: "Theodore Ts'o" To: Logan Gunthorpe Cc: Frank Rowand , Tim.Bird@sony.com, knut.omang@oracle.com, gregkh@linuxfoundation.org, brendanhiggins@google.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20190510044743.GA6889@mit.edu> Mail-Followup-To: Theodore Ts'o , Logan Gunthorpe , Frank Rowand , Tim.Bird@sony.com, knut.omang@oracle.com, gregkh@linuxfoundation.org, brendanhiggins@google.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com References: <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, May 09, 2019 at 05:40:48PM -0600, Logan Gunthorpe wrote: > > Based on some of the other commenters, I was under the impression that > kselftests had in-kernel tests but I'm not sure where or if they exist. If > they do exists, it seems like it would make sense to convert those to kunit > and have Kunit tests run-able in a VM or baremetal instance. There are kselftests tests which are shell scripts which load a module, and the module runs the in-kernel code. However, I didn't see much infrastructure for the in-kernel test code; the one or two test modules called from kselftests looked pretty ad hoc to me. That's why I used the "vise grips" analogy. You can use a pair of vise grips like a monkey wrench; but it's not really a monkey wrench, and might not be the best tool to loosen or tighten nuts and bolts. - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 From: tytso at mit.edu (Theodore Ts'o) Date: Fri, 10 May 2019 00:47:43 -0400 Subject: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework In-Reply-To: <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> References: <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> Message-ID: <20190510044743.GA6889@mit.edu> On Thu, May 09, 2019 at 05:40:48PM -0600, Logan Gunthorpe wrote: > > Based on some of the other commenters, I was under the impression that > kselftests had in-kernel tests but I'm not sure where or if they exist. If > they do exists, it seems like it would make sense to convert those to kunit > and have Kunit tests run-able in a VM or baremetal instance. There are kselftests tests which are shell scripts which load a module, and the module runs the in-kernel code. However, I didn't see much infrastructure for the in-kernel test code; the one or two test modules called from kselftests looked pretty ad hoc to me. That's why I used the "vise grips" analogy. You can use a pair of vise grips like a monkey wrench; but it's not really a monkey wrench, and might not be the best tool to loosen or tighten nuts and bolts. - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 From: tytso@mit.edu (Theodore Ts'o) Date: Fri, 10 May 2019 00:47:43 -0400 Subject: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework In-Reply-To: <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> References: <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> Message-ID: <20190510044743.GA6889@mit.edu> Content-Type: text/plain; charset="UTF-8" Message-ID: <20190510044743.om4cQepB6PxHMAyIDkPkR0hLDIpvLQFvKpYoZ7vcTL0@z> On Thu, May 09, 2019@05:40:48PM -0600, Logan Gunthorpe wrote: > > Based on some of the other commenters, I was under the impression that > kselftests had in-kernel tests but I'm not sure where or if they exist. If > they do exists, it seems like it would make sense to convert those to kunit > and have Kunit tests run-able in a VM or baremetal instance. There are kselftests tests which are shell scripts which load a module, and the module runs the in-kernel code. However, I didn't see much infrastructure for the in-kernel test code; the one or two test modules called from kselftests looked pretty ad hoc to me. That's why I used the "vise grips" analogy. You can use a pair of vise grips like a monkey wrench; but it's not really a monkey wrench, and might not be the best tool to loosen or tighten nuts and bolts. - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9ECAD2125ADF8 for ; Thu, 9 May 2019 21:48:54 -0700 (PDT) Date: Fri, 10 May 2019 00:47:43 -0400 From: "Theodore Ts'o" Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20190510044743.GA6889@mit.edu> References: <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com, brendanhiggins@google.com, dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com, mpe@ellerman.id.au, linux-kselftest@vger.kernel.org, shuah@kernel.org, robh@kernel.org, linux-nvdimm@lists.01.org, Frank Rowand , knut.omang@oracle.com, kieran.bingham@ideasonboard.com, wfg@linux.intel.com, joel@jms.id.au, rientjes@google.com, jdike@addtoit.com, dan.carpenter@oracle.com, devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org, Tim.Bird@sony.com, linux-um@lists.infradead.org, rostedt@goodmis.org, julia.lawall@lip6.fr, kunit-dev@googlegroups.com, richard@nod.at, sboyd@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, daniel@ffwll.ch, keescook@google.com, linux-fsdevel@vger.kernel.org, khilman@baylibre.com List-ID: On Thu, May 09, 2019 at 05:40:48PM -0600, Logan Gunthorpe wrote: > > Based on some of the other commenters, I was under the impression that > kselftests had in-kernel tests but I'm not sure where or if they exist. If > they do exists, it seems like it would make sense to convert those to kunit > and have Kunit tests run-able in a VM or baremetal instance. There are kselftests tests which are shell scripts which load a module, and the module runs the in-kernel code. However, I didn't see much infrastructure for the in-kernel test code; the one or two test modules called from kselftests looked pretty ad hoc to me. That's why I used the "vise grips" analogy. You can use a pair of vise grips like a monkey wrench; but it's not really a monkey wrench, and might not be the best tool to loosen or tighten nuts and bolts. - Ted _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hOxSs-00031f-Sf for linux-um@lists.infradead.org; Fri, 10 May 2019 04:49:00 +0000 Date: Fri, 10 May 2019 00:47:43 -0400 From: "Theodore Ts'o" Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20190510044743.GA6889@mit.edu> References: <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Logan Gunthorpe Cc: pmladek@suse.com, linux-doc@vger.kernel.org, amir73il@gmail.com, brendanhiggins@google.com, dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com, mpe@ellerman.id.au, linux-kselftest@vger.kernel.org, shuah@kernel.org, robh@kernel.org, linux-nvdimm@lists.01.org, Frank Rowand , knut.omang@oracle.com, kieran.bingham@ideasonboard.com, wfg@linux.intel.com, joel@jms.id.au, rientjes@google.com, jdike@addtoit.com, dan.carpenter@oracle.com, devicetree@vger.kernel.org, linux-kbuild@vger.kernel.org, Tim.Bird@sony.com, linux-um@lists.infradead.org, rostedt@goodmis.org, julia.lawall@lip6.fr, dan.j.williams@intel.com, kunit-dev@googlegroups.com, richard@nod.at, sboyd@kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mcgrof@kernel.org, daniel@ffwll.ch, keescook@google.com, linux-fsdevel@vger.kernel.org, khilman@baylibre.com On Thu, May 09, 2019 at 05:40:48PM -0600, Logan Gunthorpe wrote: > > Based on some of the other commenters, I was under the impression that > kselftests had in-kernel tests but I'm not sure where or if they exist. If > they do exists, it seems like it would make sense to convert those to kunit > and have Kunit tests run-able in a VM or baremetal instance. There are kselftests tests which are shell scripts which load a module, and the module runs the in-kernel code. However, I didn't see much infrastructure for the in-kernel test code; the one or two test modules called from kselftests looked pretty ad hoc to me. That's why I used the "vise grips" analogy. You can use a pair of vise grips like a monkey wrench; but it's not really a monkey wrench, and might not be the best tool to loosen or tighten nuts and bolts. - Ted _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Ts'o" Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework Date: Fri, 10 May 2019 00:47:43 -0400 Message-ID: <20190510044743.GA6889@mit.edu> References: <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <8914afef-1e66-e6e3-f891-5855768d3018-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Logan Gunthorpe Cc: pmladek-IBi9RG/b67k@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, amir73il-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, brendanhiggins-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Alexander.Levin-0li6OtcxBFHby3iVrkZq2A@public.gmane.org, mpe-Gsx/Oe8HsFggBc27wqDAHg@public.gmane.org, linux-kselftest-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shuah-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, Frank Rowand , knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, kieran.bingham-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, wfg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org, rientjes-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, jdike-OPE4K8JWMJJBDgjK7y7TUQ@public.gmane.org, dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kbuild-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tim.Bird-7U/KSKJipcs@public.gmane.org, linux-um-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org, julia.lawall-L2FTfq7BK8M@public.gmane.org, kunit-dev-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, richard-/L3Ra7n9ekc@public.gmane.org, sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mcgrof-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, daniel-/w4YWyX8dFk@public.gmane.org, keescook-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, May 09, 2019 at 05:40:48PM -0600, Logan Gunthorpe wrote: > > Based on some of the other commenters, I was under the impression that > kselftests had in-kernel tests but I'm not sure where or if they exist. If > they do exists, it seems like it would make sense to convert those to kunit > and have Kunit tests run-able in a VM or baremetal instance. There are kselftests tests which are shell scripts which load a module, and the module runs the in-kernel code. However, I didn't see much infrastructure for the in-kernel test code; the one or two test modules called from kselftests looked pretty ad hoc to me. That's why I used the "vise grips" analogy. You can use a pair of vise grips like a monkey wrench; but it's not really a monkey wrench, and might not be the best tool to loosen or tighten nuts and bolts. - Ted