All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: laurentiu.tudor@nxp.com, hch@lst.de, stern@rowland.harvard.edu,
	gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	marex@denx.de, leoyang.li@nxp.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/3] prerequisites for device reserved local mem rework
Date: Fri, 10 May 2019 17:53:35 +0200	[thread overview]
Message-ID: <20190510155335.GA32010@lst.de> (raw)
In-Reply-To: <e6410453-9ca3-4bdc-3c74-654333f2806f@arm.com>

On Fri, May 10, 2019 at 04:03:37PM +0100, Robin Murphy wrote:
> Hi Laurentiu,
>
> On 10/05/2019 15:56,  wrote:
>> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>>
>> For HCs that have local memory, replace the current DMA API usage
>> with a genalloc generic allocator to manage the mappings for these
>> devices.
>> This is in preparation for dropping the existing "coherent" dma
>> mem declaration APIs. Current implementation was relying on a short
>> circuit in the DMA API that in the end, was acting as an allocator
>> for these type of devices.
>>
>> Only compiled tested, so any volunteers willing to test are most welcome.
>
> Based on my diggings into this in the past, I would expect that you need to 
> do something about hcd_alloc_coherent() as well.

Yep.  And it might make sense to share the code for that and the
ohci internal allocations with a helper.

      parent reply	other threads:[~2019-05-10 15:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-10 14:56 [RFC PATCH 0/3] prerequisites for device reserved local mem rework laurentiu.tudor
2019-05-10 14:56 ` [RFC PATCH 1/3] ohci-hcd: use genalloc for USB HCs with local memory laurentiu.tudor
2019-05-10 14:56 ` [RFC PATCH 2/3] usb: host: ohci-sm501: init genalloc for " laurentiu.tudor
2019-05-10 14:56 ` [RFC PATCH 3/3] usb: host: ohci-tmio: " laurentiu.tudor
2019-05-10 15:03 ` [RFC PATCH 0/3] prerequisites for device reserved local mem rework Robin Murphy
2019-05-10 15:12   ` Laurentiu Tudor
2019-05-10 15:53   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190510155335.GA32010@lst.de \
    --to=hch@lst.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurentiu.tudor@nxp.com \
    --cc=leoyang.li@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=robin.murphy@arm.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.