Re: [Qemu-devel] [PATCH v2] chardev/char-i2c: Implement Linux I2C character device

[Ernest Esene <eroken1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Thu, May 09, 2019 at 02:00:56PM +0100, Stefan Hajnoczi wrote:
> On Sat, May 04, 2019 at 07:11:19PM +0100, Ernest Esene wrote:
> > Add support for Linux I2C character device for I2C device passthrough
> > For example:
> > -chardev linux-i2c,address=0x46,path=/dev/i2c-N,id=i2c-chardev
> 
> There is a mixture of "linux-i2c" and "char-i2c" names in this patch,
> which I find confusing.  Maybe you changed your mind while writing this
> code.  There are two options:
> 
> 1. Call it "linux-i2c".  Other host operating systems will need their
>    own equivalent objects.
> 
> 2. Call it "char-i2c" and make all the parameters optional since they
>    are likely to work differently on other host operating systems.
> 
> I tend towards the second approach because I think I2C is simple enough
> that a single user-visible object can work on all host operating
> systems.
> 
> Please make the naming consistent in the next revision of this patch.

My coding skills is limited to only Linux, I prefer the first approach
as is makes it easy.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]