From: "Theodore Ts'o" <tytso@mit.edu>
To: Chengguang Xu <cgxu519@gmail.com>
Cc: jack@suse.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] jbd2: fix potential double free
Date: Fri, 10 May 2019 21:37:01 -0400 [thread overview]
Message-ID: <20190511013701.GD2534@mit.edu> (raw)
In-Reply-To: <1557484608-23514-1-git-send-email-cgxu519@gmail.com>
On Fri, May 10, 2019 at 06:36:48PM +0800, Chengguang Xu wrote:
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 37e16d969925..0f1ac43d0560 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -2299,7 +2299,7 @@ static void jbd2_journal_destroy_slabs(void)
> }
> }
>
> -static int jbd2_journal_create_slab(size_t size)
> +static int __init jbd2_journal_create_slab(size_t size)
> {
> static DEFINE_MUTEX(jbd2_slab_create_mutex);
> int i = order_base_2(size) - 10;
I had to remove this hunk. It's incorrect, since jbd2_journal_load
calls this function when mounting file systems. So it can't be marked
__init.
- Ted
prev parent reply other threads:[~2019-05-11 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 10:36 [PATCH v2] jbd2: fix potential double free Chengguang Xu
2019-05-11 0:18 ` Theodore Ts'o
2019-05-11 1:37 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190511013701.GD2534@mit.edu \
--to=tytso@mit.edu \
--cc=cgxu519@gmail.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.