From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: "Joel Fernandes (Google)" <joel@joelfernandes.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Adrian Ratiu" <adrian.ratiu@collabora.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"atish patra" <atishp04@gmail.com>,
bpf@vger.kernel.org, "Brendan Gregg" <bgregg@netflix.com>,
"Brendan Gregg" <brendan.d.gregg@gmail.com>,
"Daniel Colascione" <dancol@google.com>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
duyuchao <yuchao.du@unisoc.com>,
"Guenter Roeck" <groeck@chromium.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Karim Yaghmour" <karim.yaghmour@opersys.com>,
"Kees Cook" <keescook@chromium.org>,
"Cc: Android Kernel" <kernel-team@android.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
linux-trace-devel@vger.kernel.org,
"Manjo Raja Rao" <linux@manojrajarao.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Michał Gregorczyk" <michalgr@fb.com>,
"Michal Gregorczyk" <michalgr@live.com>,
"Mohammad Husain" <russoue@gmail.com>,
"Olof Johansson" <olof@lixom.net>,
"Qais Yousef" <qais.yousef@arm.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Shuah Khan" <shuah@kernel.org>,
"Srinivas Ramana" <sramana@codeaurora.org>,
"Tamir Carmeli" <carmeli.tamir@gmail.com>,
"Yonghong Song" <yhs@fb.com>
Subject: Re: [PATCH 3/3] kheaders: Make it depend on sysfs
Date: Sat, 11 May 2019 08:02:03 +0200 [thread overview]
Message-ID: <20190511060203.GA18650@kroah.com> (raw)
In-Reply-To: <CAK7LNATeJqmE29M=Y1Vexg8nnRdr3qUDkq1BejN7t2_106PgVg@mail.gmail.com>
On Sat, May 11, 2019 at 09:52:04AM +0900, Masahiro Yamada wrote:
> On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google)
> <joel@joelfernandes.org> wrote:
> >
> > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
> > depend on SYSFS as it makes no sense to enable this feature without it.
>
>
> And, it also makes no sense to break the feature by 1/3,
> then fix it by 3/3.
>
>
> Why don't you squash this?
I agree, this belongs in patch 1/3.
WARNING: multiple messages have this Message-ID (diff)
From: gregkh at linuxfoundation.org (Greg Kroah-Hartman)
Subject: [PATCH 3/3] kheaders: Make it depend on sysfs
Date: Sat, 11 May 2019 08:02:03 +0200 [thread overview]
Message-ID: <20190511060203.GA18650@kroah.com> (raw)
In-Reply-To: <CAK7LNATeJqmE29M=Y1Vexg8nnRdr3qUDkq1BejN7t2_106PgVg@mail.gmail.com>
On Sat, May 11, 2019 at 09:52:04AM +0900, Masahiro Yamada wrote:
> On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google)
> <joel at joelfernandes.org> wrote:
> >
> > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
> > depend on SYSFS as it makes no sense to enable this feature without it.
>
>
> And, it also makes no sense to break the feature by 1/3,
> then fix it by 3/3.
>
>
> Why don't you squash this?
I agree, this belongs in patch 1/3.
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Subject: [PATCH 3/3] kheaders: Make it depend on sysfs
Date: Sat, 11 May 2019 08:02:03 +0200 [thread overview]
Message-ID: <20190511060203.GA18650@kroah.com> (raw)
Message-ID: <20190511060203.Vvp795LX8XUR3pxIkX-deKa8MBBoa-50dIYxrUvtCu4@z> (raw)
In-Reply-To: <CAK7LNATeJqmE29M=Y1Vexg8nnRdr3qUDkq1BejN7t2_106PgVg@mail.gmail.com>
On Sat, May 11, 2019@09:52:04AM +0900, Masahiro Yamada wrote:
> On Sat, May 11, 2019 at 6:05 AM Joel Fernandes (Google)
> <joel@joelfernandes.org> wrote:
> >
> > The kheaders archive is exposed through SYSFS in /sys/kernel/. Make it
> > depend on SYSFS as it makes no sense to enable this feature without it.
>
>
> And, it also makes no sense to break the feature by 1/3,
> then fix it by 3/3.
>
>
> Why don't you squash this?
I agree, this belongs in patch 1/3.
next prev parent reply other threads:[~2019-05-11 6:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 21:02 [PATCH 0/3] kheaders fixes for -rc Joel Fernandes (Google)
2019-05-10 21:02 ` Joel Fernandes (Google)
2019-05-10 21:02 ` joel
2019-05-10 21:02 ` [PATCH 1/3] kheaders: Move from proc to sysfs Joel Fernandes (Google)
2019-05-10 21:02 ` Joel Fernandes (Google)
2019-05-10 21:02 ` joel
2019-05-10 21:02 ` [PATCH 2/3] kheaders: Do not regenerate archive if config is not changed Joel Fernandes (Google)
2019-05-10 21:02 ` Joel Fernandes (Google)
2019-05-10 21:02 ` joel
2019-05-10 21:02 ` [PATCH 3/3] kheaders: Make it depend on sysfs Joel Fernandes (Google)
2019-05-10 21:02 ` Joel Fernandes (Google)
2019-05-10 21:02 ` joel
2019-05-11 0:52 ` Masahiro Yamada
2019-05-11 0:52 ` Masahiro Yamada
2019-05-11 0:52 ` yamada.masahiro
2019-05-11 6:02 ` Greg Kroah-Hartman [this message]
2019-05-11 6:02 ` Greg Kroah-Hartman
2019-05-11 6:02 ` gregkh
2019-05-11 16:17 ` Joel Fernandes
2019-05-11 16:17 ` Joel Fernandes
2019-05-11 16:17 ` joel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190511060203.GA18650@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrian.ratiu@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=atishp04@gmail.com \
--cc=bgregg@netflix.com \
--cc=bpf@vger.kernel.org \
--cc=brendan.d.gregg@gmail.com \
--cc=carmeli.tamir@gmail.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dancol@google.com \
--cc=daniel@iogearbox.net \
--cc=dietmar.eggemann@arm.com \
--cc=groeck@chromium.org \
--cc=joel@joelfernandes.org \
--cc=karim.yaghmour@opersys.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-devel@vger.kernel.org \
--cc=linux@manojrajarao.com \
--cc=mhiramat@kernel.org \
--cc=michalgr@fb.com \
--cc=michalgr@live.com \
--cc=olof@lixom.net \
--cc=qais.yousef@arm.com \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=russoue@gmail.com \
--cc=shuah@kernel.org \
--cc=sramana@codeaurora.org \
--cc=yamada.masahiro@socionext.com \
--cc=yhs@fb.com \
--cc=yuchao.du@unisoc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.