From: Andrew Lunn <andrew@lunn.ch>
To: Vicente Bergas <vicencb@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Serge Semin <fancer.lancer@gmail.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: net: phy: realtek: regression, kernel null pointer dereference
Date: Sat, 11 May 2019 17:08:19 +0200 [thread overview]
Message-ID: <20190511150819.GF4889@lunn.ch> (raw)
In-Reply-To: <11446b0b-c8a4-4e5f-bfa0-0892b500f467@gmail.com>
On Sat, May 11, 2019 at 04:46:40PM +0200, Vicente Bergas wrote:
> On Friday, May 10, 2019 10:28:06 PM CEST, Heiner Kallweit wrote:
> >On 10.05.2019 17:05, Vicente Bergas wrote:
> >>Hello,
> >>there is a regression on linux v5.1-9573-gb970afcfcabd with a kernel null
> >>pointer dereference.
> >>The issue is the commit f81dadbcf7fd067baf184b63c179fc392bdb226e
> >> net: phy: realtek: Add rtl8211e rx/tx delays config ...
> >The page operation callbacks are missing in the RTL8211E driver.
> >I just submitted a fix adding these callbacks to few Realtek PHY drivers
> >including RTl8211E. This should fix the issue.
>
> Hello Heiner,
> just tried your patch and indeed the NPE is gone. But still no network...
> The MAC <-> PHY link was working before, so, maybe the rgmii delays are not
> correctly configured.
Hi Vicente
What phy-mode do you have in device tree? Have you tried the others?
rmgii
rmgii-id
rmgii-rxid
rmgii-txid
Andrew
next prev parent reply other threads:[~2019-05-11 15:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 15:05 net: phy: realtek: regression, kernel null pointer dereference Vicente Bergas
2019-05-10 20:28 ` Heiner Kallweit
2019-05-10 21:18 ` Vicente Bergas
2019-05-11 14:46 ` Vicente Bergas
2019-05-11 14:56 ` Heiner Kallweit
2019-05-11 15:06 ` Vicente Bergas
2019-05-13 10:29 ` Serge Semin
2019-05-13 10:51 ` Serge Semin
2019-05-13 12:19 ` Vicente Bergas
2019-05-13 12:42 ` Serge Semin
2019-05-13 12:51 ` Andrew Lunn
2019-05-13 13:01 ` Serge Semin
2019-05-13 13:33 ` Vicente Bergas
2019-05-13 7:29 ` Serge Semin
2019-05-11 15:08 ` Andrew Lunn [this message]
2019-05-11 15:16 ` Vicente Bergas
2019-05-11 15:25 ` Andrew Lunn
2019-05-10 21:04 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190511150819.GF4889@lunn.ch \
--to=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=fancer.lancer@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.