From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca
Date: Mon, 13 May 2019 10:41:28 +0200 [thread overview]
Message-ID: <20190513084127.GA3127@localhost.localdomain> (raw)
In-Reply-To: <87r293ugia.fsf@purkki.adurom.net>
[-- Attachment #1: Type: text/plain, Size: 846 bytes --]
> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>
> > Introduce a knob in mt7603 debugfs in order to enable/disable
> > edcca processing
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>
> It's good to explain what edcca does and how the file is used supposed
> to be used. In other words, have a small introduction for the user.
Hi Kalle,
edcca is used for adjusting energy detect based on CCA thresholds.
The code was already there so I just reported the acronym.
>
> > @@ -48,6 +77,7 @@ void mt7603_init_debugfs(struct mt7603_dev *dev)
> > if (!dir)
> > return;
> >
> > + debugfs_create_file("edcca", 0400, dir, dev, &fops_edcca);
>
> Why 0400 and not 0600?
yes, right. There is the same issue in mt76x02 code, I will fix both of them.
Thx.
Regards,
Lorenzo
>
> --
> Kalle Valo
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-05-13 8:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1557591530.git.lorenzo@kernel.org>
2019-05-11 16:38 ` [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca Lorenzo Bianconi
2019-05-13 4:26 ` Kalle Valo
2019-05-13 8:41 ` Lorenzo Bianconi [this message]
2019-05-13 9:48 ` Stanislaw Gruszka
2019-05-15 9:33 ` Stanislaw Gruszka
2019-05-15 9:43 ` Lorenzo Bianconi
2019-05-15 9:54 ` Stanislaw Gruszka
2019-05-15 10:03 ` Lorenzo Bianconi
2019-05-15 10:33 ` Stanislaw Gruszka
2019-05-15 11:13 ` Lorenzo Bianconi
2019-05-15 11:46 ` Stanislaw Gruszka
2019-05-15 12:07 ` Lorenzo Bianconi
2019-05-15 13:48 ` Stanislaw Gruszka
2019-05-15 13:59 ` Stanislaw Gruszka
2019-05-13 12:37 ` Kalle Valo
2019-05-13 15:41 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513084127.GA3127@localhost.localdomain \
--to=lorenzo@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.