From: Randy MacLeod <Randy.MacLeod@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: [PATCH 5/5] valgrind: fix call/cachegrind ptests
Date: Mon, 13 May 2019 23:57:16 -0400 [thread overview]
Message-ID: <20190514035716.27376-5-Randy.MacLeod@windriver.com> (raw)
In-Reply-To: <20190514035716.27376-1-Randy.MacLeod@windriver.com>
Use the *_annotate executables from ${bindir}
Actually install cachegrind/tests/a.c since it is used by
the call/cachegrind/tests/ann[12].vgtest files.
With this change and the previous commits, the ptest results
on qemux86-64 when invoked with:
runqemu qemux86 kvm nographic slirp qemuparams="-m 2048"
are:
=== Test Summary ===
TOTAL: 159
PASSED: 149
FAILED: 1
SKIPPED: 9
Only drd/tests/pth_detached3 remains to be fixed.
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
---
meta/recipes-devtools/valgrind/valgrind_3.15.0.bb | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/meta/recipes-devtools/valgrind/valgrind_3.15.0.bb b/meta/recipes-devtools/valgrind/valgrind_3.15.0.bb
index 8fecdefb91..f8b6b003a1 100644
--- a/meta/recipes-devtools/valgrind/valgrind_3.15.0.bb
+++ b/meta/recipes-devtools/valgrind/valgrind_3.15.0.bb
@@ -160,6 +160,8 @@ do_install_ptest() {
cd $saved_dir
done
+ # Hide then restore a.c that is used by ann[12].vgtest in call/cachegrind
+ mv ${D}${PTEST_PATH}/cachegrind/tests/a.c ${D}${PTEST_PATH}/cachegrind/tests/a_c
# clean out build artifacts before building the rpm
find ${D}${PTEST_PATH} \
\( -name "Makefile*" \
@@ -168,6 +170,14 @@ do_install_ptest() {
-o -name "*.S" \
-o -name "*.h" \) \
-exec rm {} \;
+ mv ${D}${PTEST_PATH}/cachegrind/tests/a_c ${D}${PTEST_PATH}/cachegrind/tests/a.c
+
+ # find *_annotate in ${bindir} for yocto build
+ sed -i s:\.\./\.\./cachegrind/cg_annotate:${bindir}/cg_annotate: ${D}${PTEST_PATH}/cachegrind/tests/ann1.vgtest
+ sed -i s:\.\./\.\./cachegrind/cg_annotate:${bindir}/cg_annotate: ${D}${PTEST_PATH}/cachegrind/tests/ann2.vgtest
+
+ sed -i s:\.\./\.\./callgrind/callgrind_annotate:${bindir}/callgrind_annotate: ${D}${PTEST_PATH}/callgrind/tests/ann1.vgtest
+ sed -i s:\.\./\.\./callgrind/callgrind_annotate:${bindir}/callgrind_annotate: ${D}${PTEST_PATH}/callgrind/tests/ann2.vgtest
# needed by massif tests
cp ${B}/massif/ms_print ${D}${PTEST_PATH}/massif/ms_print
--
2.17.0
prev parent reply other threads:[~2019-05-14 3:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 3:57 [PATCH 1/5] valgrind: fix vg_regtest return code Randy MacLeod
2019-05-14 3:57 ` [PATCH 2/5] valgrind: do not strip the package or ptests Randy MacLeod
2019-05-14 14:08 ` Richard Purdie
2019-05-14 17:54 ` Randy MacLeod
2019-05-14 21:32 ` richard.purdie
2019-05-14 21:42 ` Randy MacLeod
2019-05-14 21:46 ` richard.purdie
2019-05-15 2:22 ` Randy MacLeod
2019-05-15 19:11 ` Randy MacLeod
2019-05-20 21:15 ` Khem Raj
2019-05-15 1:17 ` Mittal, Anuj
2019-05-20 20:52 ` Khem Raj
2019-05-14 16:44 ` Burton, Ross
2019-05-14 3:57 ` [PATCH 3/5] valgrind: update the ptest subdirs list Randy MacLeod
2019-05-14 3:57 ` [PATCH 4/5] valgrind: adjust test filters and expected output Randy MacLeod
2019-05-14 3:57 ` Randy MacLeod [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514035716.27376-5-Randy.MacLeod@windriver.com \
--to=randy.macleod@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.