From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A1E0C04AB4 for ; Tue, 14 May 2019 07:50:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B7B1208CA for ; Tue, 14 May 2019 07:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557820208; bh=2hYvjl0agVugFiEaz+VAjZeVDOvB29I05dwS1wphxew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hKV0E8YLM19/GGW/UFL9wBbJPKk+tLTLJx9P0SYs17ad7CrN09WRQbc/GCmmkH+Qo qxnG9z5h2WGDYuDj4Uf0N1Rpnp7FLJTsEI73mQv0OTwy6PQQA1abk5W/YxaUKxJVJp i+9NofVwPfv2RqURSZQuCwAcObLjZxvDsEsDrFoA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbfENHuH (ORCPT ); Tue, 14 May 2019 03:50:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:35906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbfENHuH (ORCPT ); Tue, 14 May 2019 03:50:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22B7D2086A; Tue, 14 May 2019 07:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557820206; bh=2hYvjl0agVugFiEaz+VAjZeVDOvB29I05dwS1wphxew=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FVAbOq97ogNjMcBSLf9RCSG16YChQuTEBmtDJR1olrZkZ/i2YskfgnTWqQAEkYtQ9 cqFC9LIt9Ikedby/n2mzXo63wyCyf6EoiOFo6A8v9rQPRSDBdtpmB/6Xg3xkHja5oU AQqIznT4koM0toFuiMVYlu339f2z6fM/gXNfZxsQ= Date: Tue, 14 May 2019 09:50:04 +0200 From: Greg Kroah-Hartman To: Nobuhiro Iwamatsu , Sasha Levin Cc: stable@kernel.org, Alistair Strachan , Florian Weimer , Carlos O'Donell , "H. J. Lu" , Borislav Petkov , Laura Abbott , Andy Lutomirski , "H. Peter Anvin" , Ingo Molnar , Joel Fernandes , kernel-team@android.com, stable , Thomas Gleixner , X86 ML Subject: Re: [PATCH for 4.4, 4.9 and 4.14] x86/vdso: Pass --eh-frame-hdr to the linker Message-ID: <20190514075004.GD27017@kroah.com> References: <20190514073429.17537-1-nobuhiro1.iwamatsu@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190514073429.17537-1-nobuhiro1.iwamatsu@toshiba.co.jp> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, May 14, 2019 at 04:34:29PM +0900, Nobuhiro Iwamatsu wrote: > From: Alistair Strachan > > commit cd01544a268ad8ee5b1dfe42c4393f1095f86879 upstream. > > Commit > > 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") > > accidentally broke unwinding from userspace, because ld would strip the > .eh_frame sections when linking. > > Originally, the compiler would implicitly add --eh-frame-hdr when > invoking the linker, but when this Makefile was converted from invoking > ld via the compiler, to invoking it directly (like vmlinux does), > the flag was missed. (The EH_FRAME section is important for the VDSO > shared libraries, but not for vmlinux.) > > Fix the problem by explicitly specifying --eh-frame-hdr, which restores > parity with the old method. > > See relevant bug reports for additional info: > > https://bugzilla.kernel.org/show_bug.cgi?id=201741 > https://bugzilla.redhat.com/show_bug.cgi?id=1659295 > > Fixes: 379d98ddf413 ("x86: vdso: Use $LD instead of $CC to link") > Reported-by: Florian Weimer > Reported-by: Carlos O'Donell > Reported-by: "H. J. Lu" > Signed-off-by: Alistair Strachan > Signed-off-by: Borislav Petkov > Tested-by: Laura Abbott > Cc: Andy Lutomirski > Cc: Carlos O'Donell > Cc: "H. Peter Anvin" > Cc: Ingo Molnar > Cc: Joel Fernandes > Cc: kernel-team@android.com > Cc: Laura Abbott > Cc: stable > Cc: Thomas Gleixner > Cc: X86 ML > Link: https://lkml.kernel.org/r/20181214223637.35954-1-astrachan@google.com > Signed-off-by: Nobuhiro Iwamatsu > --- > arch/x86/entry/vdso/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This is already in the 4.14 stable queue. Sasha, how did you tools miss it for 4.4 and 4.9? thanks, greg k-h