From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Raul E Rangel <rrangel@chromium.org>
Cc: stable@vger.kernel.org, linux-mmc@vger.kernel.org,
djkurtz@google.com, adrian.hunter@intel.com,
zwisler@chromium.org, "Linus Walleij" <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, "Chris Boot" <bootc@bootc.net>,
"Clément Péron" <peron.clem@gmail.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>
Subject: Re: [stable/4.14.y PATCH 0/3] mmc: Fix a potential resource leak when shutting down request queue.
Date: Tue, 14 May 2019 11:19:34 +0200 [thread overview]
Message-ID: <20190514091933.GA27269@kroah.com> (raw)
In-Reply-To: <20190513175521.84955-1-rrangel@chromium.org>
On Mon, May 13, 2019 at 11:55:18AM -0600, Raul E Rangel wrote:
> I think we should cherry-pick 41e3efd07d5a02c80f503e29d755aa1bbb4245de
> https://lore.kernel.org/patchwork/patch/856512/ into 4.14. It fixes a
> potential resource leak when shutting down the request queue.
Potential meaning "it does happen", or "it can happen if we do this", or
just "maybe it might happen, we really do not know?"
> Once this patch is applied, there is a potential for a null pointer dereference.
> That's what the second patch fixes.
What is the git id of that upstream fix?
> The third patch is just an optimization to stop processing earlier.
That's not how stable kernels work :(
> See https://patchwork.kernel.org/patch/10925469/ for the initial motivation.
I don't understand the motivation from that link at all :(
> This commit applies to v4.14.116. It is already included in 4.19. 4.19 doesn't
> suffer from the null pointer dereference because later commits migrate the mmc
> stack to blk-mq.
What are those later commits?
> I tested this patch set by randomly connecting/disconnecting the SD
> card. I got over 189650 itarations without a problem.
And if you do not have these patches, on 4.14.y, how many iterations
cause a problem? If you just apply the first patch, does that work?
_EVERY_ time we take a patch that is not upstream, something usually is
broken and needs to be fixed. We have a long long long history of this,
so if you want to have a patch that is not upstream applied to a stable
kernel release, you need a whole lot of justification and explanation
and begging. And you need to be around to fix the fallout for when it
breaks :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-05-14 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 17:55 [stable/4.14.y PATCH 0/3] mmc: Fix a potential resource leak when shutting down request queue Raul E Rangel
2019-05-13 17:55 ` [stable/4.14.y PATCH 1/3] mmc: block: Simplify cleaning up the queue Raul E Rangel
2019-05-13 17:55 ` [stable/4.14.y PATCH 2/3] mmc: Fix null pointer dereference in mmc_init_request Raul E Rangel
2019-05-13 20:12 ` Greg KH
2019-05-13 17:55 ` [stable/4.14.y PATCH 3/3] mmc: Kill the request if the queuedata has been removed Raul E Rangel
2019-05-13 20:12 ` Greg KH
2019-05-14 0:43 ` [stable/4.14.y PATCH 0/3] mmc: Fix a potential resource leak when shutting down request queue Sasha Levin
2019-05-14 9:19 ` Greg Kroah-Hartman [this message]
2019-06-19 16:46 ` Raul Rangel
2019-06-19 17:09 ` Greg Kroah-Hartman
2019-06-19 18:23 ` Raul Rangel
2019-06-19 18:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514091933.GA27269@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrian.hunter@intel.com \
--cc=bootc@bootc.net \
--cc=djkurtz@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=peron.clem@gmail.com \
--cc=rrangel@chromium.org \
--cc=stable@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zwisler@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.