diff for duplicates of <20190514103451.GA1694@mwanda> diff --git a/a/1.txt b/N1/1.txt index 39a79bb..1e29efb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ The code is trying to check that all the padding is zeroed out and it does this: - entry->padding[0] = entry->padding[1] = entry->padding[2] = 0 + entry->padding[0] == entry->padding[1] == entry->padding[2] == 0 Assume everything is zeroed correctly, then the first comparison is true, the next comparison is false and false is equal to zero so the @@ -13,7 +13,7 @@ Also the error message was copy and pasted from an earlier error and it wasn't correct. Fixes: 7edcb7343327 ("KVM: selftests: Add hyperv_cpuid test") -Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) @@ -23,11 +23,11 @@ index 9a21e912097c..63b9fc3fdfbe 100644 --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries, - TEST_ASSERT(entry->flags = 0, + TEST_ASSERT(entry->flags == 0, ".flags field should be zero"); -- TEST_ASSERT(entry->padding[0] = entry->padding[1] -- = entry->padding[2] = 0, +- TEST_ASSERT(entry->padding[0] == entry->padding[1] +- == entry->padding[2] == 0, - ".index field should be zero"); + TEST_ASSERT(!entry->padding[0] && !entry->padding[1] && + !entry->padding[2], "padding should be zero"); diff --git a/a/content_digest b/N1/content_digest index 3f2244e..6d82451 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,19 +1,12 @@ - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "From\0dan.carpenter at oracle.com (Dan Carpenter)\0" "Subject\0[PATCH] KVM: selftests: Fix a condition in test_hv_cpuid()\0" - "Date\0Tue, 14 May 2019 10:34:51 +0000\0" - "To\0Paolo Bonzini <pbonzini@redhat.com>" - " Vitaly Kuznetsov <vkuznets@redhat.com>\0" - "Cc\0Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Shuah Khan <shuah@kernel.org> - kvm@vger.kernel.org - linux-kselftest@vger.kernel.org - " kernel-janitors@vger.kernel.org\0" + "Date\0Tue, 14 May 2019 13:34:51 +0300\0" "\00:1\0" "b\0" "The code is trying to check that all the padding is zeroed out and it\n" "does this:\n" "\n" - " entry->padding[0] = entry->padding[1] = entry->padding[2] = 0\n" + " entry->padding[0] == entry->padding[1] == entry->padding[2] == 0\n" "\n" "Assume everything is zeroed correctly, then the first comparison is\n" "true, the next comparison is false and false is equal to zero so the\n" @@ -25,7 +18,7 @@ "wasn't correct.\n" "\n" "Fixes: 7edcb7343327 (\"KVM: selftests: Add hyperv_cpuid test\")\n" - "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>\n" "---\n" " tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 5 ++---\n" " 1 file changed, 2 insertions(+), 3 deletions(-)\n" @@ -35,11 +28,11 @@ "--- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c\n" "+++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c\n" "@@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,\n" - " \t\tTEST_ASSERT(entry->flags = 0,\n" + " \t\tTEST_ASSERT(entry->flags == 0,\n" " \t\t\t \".flags field should be zero\");\n" " \n" - "-\t\tTEST_ASSERT(entry->padding[0] = entry->padding[1]\n" - "-\t\t\t = entry->padding[2] = 0,\n" + "-\t\tTEST_ASSERT(entry->padding[0] == entry->padding[1]\n" + "-\t\t\t == entry->padding[2] == 0,\n" "-\t\t\t \".index field should be zero\");\n" "+\t\tTEST_ASSERT(!entry->padding[0] && !entry->padding[1] &&\n" "+\t\t\t !entry->padding[2], \"padding should be zero\");\n" @@ -49,4 +42,4 @@ "-- \n" 2.20.1 -815526458884eaf3f8e049c962135542f62372ed0d8306a5db6f92050fcdc9bb +12b3aa34070013b4835664b2f4603b24570474efb96127142936d4e96cfa6d56
diff --git a/a/1.txt b/N2/1.txt index 39a79bb..1e29efb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,7 +1,7 @@ The code is trying to check that all the padding is zeroed out and it does this: - entry->padding[0] = entry->padding[1] = entry->padding[2] = 0 + entry->padding[0] == entry->padding[1] == entry->padding[2] == 0 Assume everything is zeroed correctly, then the first comparison is true, the next comparison is false and false is equal to zero so the @@ -13,7 +13,7 @@ Also the error message was copy and pasted from an earlier error and it wasn't correct. Fixes: 7edcb7343327 ("KVM: selftests: Add hyperv_cpuid test") -Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> +Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com> --- tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) @@ -23,11 +23,11 @@ index 9a21e912097c..63b9fc3fdfbe 100644 --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries, - TEST_ASSERT(entry->flags = 0, + TEST_ASSERT(entry->flags == 0, ".flags field should be zero"); -- TEST_ASSERT(entry->padding[0] = entry->padding[1] -- = entry->padding[2] = 0, +- TEST_ASSERT(entry->padding[0] == entry->padding[1] +- == entry->padding[2] == 0, - ".index field should be zero"); + TEST_ASSERT(!entry->padding[0] && !entry->padding[1] && + !entry->padding[2], "padding should be zero"); diff --git a/a/content_digest b/N2/content_digest index 3f2244e..325e783 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,19 +1,12 @@ - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "From\0dan.carpenter@oracle.com (Dan Carpenter)\0" "Subject\0[PATCH] KVM: selftests: Fix a condition in test_hv_cpuid()\0" - "Date\0Tue, 14 May 2019 10:34:51 +0000\0" - "To\0Paolo Bonzini <pbonzini@redhat.com>" - " Vitaly Kuznetsov <vkuznets@redhat.com>\0" - "Cc\0Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" - Shuah Khan <shuah@kernel.org> - kvm@vger.kernel.org - linux-kselftest@vger.kernel.org - " kernel-janitors@vger.kernel.org\0" + "Date\0Tue, 14 May 2019 13:34:51 +0300\0" "\00:1\0" "b\0" "The code is trying to check that all the padding is zeroed out and it\n" "does this:\n" "\n" - " entry->padding[0] = entry->padding[1] = entry->padding[2] = 0\n" + " entry->padding[0] == entry->padding[1] == entry->padding[2] == 0\n" "\n" "Assume everything is zeroed correctly, then the first comparison is\n" "true, the next comparison is false and false is equal to zero so the\n" @@ -25,7 +18,7 @@ "wasn't correct.\n" "\n" "Fixes: 7edcb7343327 (\"KVM: selftests: Add hyperv_cpuid test\")\n" - "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>\n" + "Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>\n" "---\n" " tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c | 5 ++---\n" " 1 file changed, 2 insertions(+), 3 deletions(-)\n" @@ -35,11 +28,11 @@ "--- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c\n" "+++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c\n" "@@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,\n" - " \t\tTEST_ASSERT(entry->flags = 0,\n" + " \t\tTEST_ASSERT(entry->flags == 0,\n" " \t\t\t \".flags field should be zero\");\n" " \n" - "-\t\tTEST_ASSERT(entry->padding[0] = entry->padding[1]\n" - "-\t\t\t = entry->padding[2] = 0,\n" + "-\t\tTEST_ASSERT(entry->padding[0] == entry->padding[1]\n" + "-\t\t\t == entry->padding[2] == 0,\n" "-\t\t\t \".index field should be zero\");\n" "+\t\tTEST_ASSERT(!entry->padding[0] && !entry->padding[1] &&\n" "+\t\t\t !entry->padding[2], \"padding should be zero\");\n" @@ -49,4 +42,4 @@ "-- \n" 2.20.1 -815526458884eaf3f8e049c962135542f62372ed0d8306a5db6f92050fcdc9bb +dc41f48144a9060d3e27486d2d57523c9029768539142a596bb4c6511014076f
diff --git a/a/1.txt b/N3/1.txt index 39a79bb..6c0b3f4 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -1,7 +1,7 @@ The code is trying to check that all the padding is zeroed out and it does this: - entry->padding[0] = entry->padding[1] = entry->padding[2] = 0 + entry->padding[0] == entry->padding[1] == entry->padding[2] == 0 Assume everything is zeroed correctly, then the first comparison is true, the next comparison is false and false is equal to zero so the @@ -23,11 +23,11 @@ index 9a21e912097c..63b9fc3fdfbe 100644 --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c @@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries, - TEST_ASSERT(entry->flags = 0, + TEST_ASSERT(entry->flags == 0, ".flags field should be zero"); -- TEST_ASSERT(entry->padding[0] = entry->padding[1] -- = entry->padding[2] = 0, +- TEST_ASSERT(entry->padding[0] == entry->padding[1] +- == entry->padding[2] == 0, - ".index field should be zero"); + TEST_ASSERT(!entry->padding[0] && !entry->padding[1] && + !entry->padding[2], "padding should be zero"); diff --git a/a/content_digest b/N3/content_digest index 3f2244e..9190fcc 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -1,6 +1,6 @@ "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0[PATCH] KVM: selftests: Fix a condition in test_hv_cpuid()\0" - "Date\0Tue, 14 May 2019 10:34:51 +0000\0" + "Date\0Tue, 14 May 2019 13:34:51 +0300\0" "To\0Paolo Bonzini <pbonzini@redhat.com>" " Vitaly Kuznetsov <vkuznets@redhat.com>\0" "Cc\0Radim Kr\304\215m\303\241\305\231 <rkrcmar@redhat.com>" @@ -13,7 +13,7 @@ "The code is trying to check that all the padding is zeroed out and it\n" "does this:\n" "\n" - " entry->padding[0] = entry->padding[1] = entry->padding[2] = 0\n" + " entry->padding[0] == entry->padding[1] == entry->padding[2] == 0\n" "\n" "Assume everything is zeroed correctly, then the first comparison is\n" "true, the next comparison is false and false is equal to zero so the\n" @@ -35,11 +35,11 @@ "--- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c\n" "+++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c\n" "@@ -58,9 +58,8 @@ static void test_hv_cpuid(struct kvm_cpuid2 *hv_cpuid_entries,\n" - " \t\tTEST_ASSERT(entry->flags = 0,\n" + " \t\tTEST_ASSERT(entry->flags == 0,\n" " \t\t\t \".flags field should be zero\");\n" " \n" - "-\t\tTEST_ASSERT(entry->padding[0] = entry->padding[1]\n" - "-\t\t\t = entry->padding[2] = 0,\n" + "-\t\tTEST_ASSERT(entry->padding[0] == entry->padding[1]\n" + "-\t\t\t == entry->padding[2] == 0,\n" "-\t\t\t \".index field should be zero\");\n" "+\t\tTEST_ASSERT(!entry->padding[0] && !entry->padding[1] &&\n" "+\t\t\t !entry->padding[2], \"padding should be zero\");\n" @@ -49,4 +49,4 @@ "-- \n" 2.20.1 -815526458884eaf3f8e049c962135542f62372ed0d8306a5db6f92050fcdc9bb +01e6b997135f67c193d1d280b06126ce1998fc503347b2104575994aeb5913e1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.