From: Oleg Nesterov <oleg@redhat.com>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: use down_read_killable for locking mmap_sem in access_remote_vm
Date: Wed, 15 May 2019 16:28:28 +0200 [thread overview]
Message-ID: <20190515142828.GA18892@redhat.com> (raw)
In-Reply-To: <155790847881.2798.7160461383704600177.stgit@buzz>
> @@ -4348,7 +4348,9 @@ int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
> void *old_buf = buf;
> int write = gup_flags & FOLL_WRITE;
>
> - down_read(&mm->mmap_sem);
> + if (down_read_killable(&mm->mmap_sem))
> + return 0;
> +
I too think that "return 0" looks a bit strange even if correct, to me
"return -EINTR" would look better.
But I won't insist, this is cosmetic.
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2019-05-15 14:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 8:21 [PATCH] mm: use down_read_killable for locking mmap_sem in access_remote_vm Konstantin Khlebnikov
2019-05-15 8:38 ` Michal Koutný
2019-05-15 8:48 ` Konstantin Khlebnikov
2019-05-16 17:00 ` Michal Koutný
2019-05-15 11:49 ` Matthew Wilcox
2019-05-15 14:28 ` Oleg Nesterov [this message]
2019-05-17 12:51 ` [PATCH] " Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515142828.GA18892@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.