From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Rob Clark <robdclark@chromium.org>,
Rob Clark <robdclark@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC 2/3] arm64: dts: qcom: sdm845-cheza: Re-add reserved memory
Date: Wed, 15 May 2019 16:41:23 -0700 [thread overview]
Message-ID: <20190515234123.GP31438@minitux> (raw)
In-Reply-To: <CAD=FV=Vgiej=+hCZ_Eekoa4FJfpKxhOge8Wy29EEmtjB8JeF9g@mail.gmail.com>
On Wed 15 May 14:50 PDT 2019, Doug Anderson wrote:
> Hi,
>
> On Tue, May 14, 2019 at 9:10 PM Rob Clark <robdclark@chromium.org> wrote:
>
> > On Mon, May 13, 2019 at 3:48 PM Doug Anderson <dianders@chromium.org> wrote:
> > >
> > > Hi,
> > >
> > > On Thu, May 9, 2019 at 11:44 AM Rob Clark <robdclark@gmail.com> wrote:
> > >
> > > > From: Douglas Anderson <dianders@chromium.org>
> > > >
> > > > Let's fixup the reserved memory to re-add the things we deleted in
> > > > ("CHROMIUM: arm64: dts: qcom: sdm845-cheza: Temporarily delete
> > > > reserved-mem changes") in a way that plays nicely with the new
> > > > upstream definitions.
> > >
> > > The message above makes no sense since that commit you reference isn't
> > > in upstream.
> > >
> > > ...but in any case, why not squash this in with the previous commit?
> >
> > Yeah, I should have mentioned this was my intention, I just left it
> > unsquashed since (at the time) it was something I had cherry-picked on
> > top of current 4.19 cros kernel..
> >
> > anyways, I pushed an (unsquashed, converted to fixup!'s) update to:
> >
> > https://github.com/freedreno/kernel-msm/commits/wip/cheza-dtb-upstreaming
> >
> > which has updates based on you're review comments (at least assuming I
> > understood them correctly).. plus some unrelated to cheza-dt patches
> > on top to get things actually working (ie. ignore everything on top of
> > the fixup!'s)
>
> Looks OK to me. Are you going to post this? Bjorn / Andy: do you
> guys have opinions here?
>
I think this is a good opportunity to get people with Cheza off 4.19, so
I'm all for landing this upstream.
Regards,
Bjorn
>
> > I didn't see any comments on the 'delete zap-shader' patch, so
> > hopefully that means what I did there was a sane (or at least not
> > insane) way to handle android/linux tz vs what we have on cheza?
>
> I wasn't CCed, so I assumed you were looking for feedback from others
> on that one. ;-) Oh, but I guess Jordan and Bjorn also weren't
> CCed... In any case, I replied now.
next prev parent reply other threads:[~2019-05-16 1:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 18:44 [RFC 0/3] arm64: dts: qcom: add cheza support Rob Clark
2019-05-09 18:44 ` [RFC 1/3] arm64: dts: qcom: sdm845-cheza: add initial cheza dt Rob Clark
2019-05-13 22:47 ` Doug Anderson
2019-05-09 18:44 ` [RFC 2/3] arm64: dts: qcom: sdm845-cheza: Re-add reserved memory Rob Clark
2019-05-13 22:48 ` Doug Anderson
2019-05-15 4:09 ` Rob Clark
2019-05-15 19:24 ` Jordan Crouse
2019-05-15 21:50 ` Doug Anderson
2019-05-15 23:41 ` Bjorn Andersson [this message]
2019-05-09 18:44 ` [RFC 3/3] arm64: dts: qcom: sdm845-cheza: delete zap-shader Rob Clark
2019-05-15 21:43 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515234123.GP31438@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.