From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] iputils: Bump to version s20190324
Date: Thu, 16 May 2019 08:08:42 +0200 [thread overview]
Message-ID: <20190516060840.GA28502@dell5510> (raw)
In-Reply-To: <20190514184217.67249ce9@windsurf>
Hi Thomas,
> It looks mostly good, but I have a few nits and questions.
> First, the commit should be prefixed by "package/iputils", not just
> "iputils", and "Bump" should be "bump", i.e lowercase.
Thanks for pointing out buildroot preference (I always wondered whether use
'packages/' prefix; lowercase after colon is much preferred generally, but
I've seen often upercase, so I adapt to it).
> This of course I
> had fixed locally, but I had more nits/questions, so I couldn't apply
> as-is.
...
> > -IPUTILS_MAKE_OPTS = $(TARGET_CONFIGURE_OPTS) USE_SYSFS=no USE_IDN=no\
> So the USE_SYSFS=no and USE_IDN=no are no longer needed / no longer
> exist ?
Thanks for review, sorry for silly errors.
I've fixed all questions in v3 (using new release I didn't need to backport
build fixes).
Kind regards,
Petr
prev parent reply other threads:[~2019-05-16 6:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 22:45 [Buildroot] [PATCH v2 1/1] iputils: Bump to version s20190324 Petr Vorel
2019-05-14 16:42 ` Thomas Petazzoni
2019-05-16 6:08 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190516060840.GA28502@dell5510 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.