From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDCD7C04AB4 for ; Thu, 16 May 2019 08:01:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0BE82089E for ; Thu, 16 May 2019 08:01:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="49Giz7gV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727050AbfEPIBM (ORCPT ); Thu, 16 May 2019 04:01:12 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:40522 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727031AbfEPIBK (ORCPT ); Thu, 16 May 2019 04:01:10 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4G7sZNd186504; Thu, 16 May 2019 08:01:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2018-07-02; bh=XjxXgAqaqUjsrzcHSUSublBDZN9GxzyE8r5lZWsNZpQ=; b=49Giz7gVN20USfU7zLrTgt14zEz69jubVn/xf4Sntz+VLczeOCXM3llaHmEzBY1zIO+O QGjfUNLLZMo6kkCzCFO7PjceYW9aUkulm4S8b2xG1ckHqnPrTVvfXv27zCkVhOgmhz6D ZNBwhBxLHTpArGxIf/1DorxMLk2DoDley9tNJhlXGZNhNmpGr0/NPVPWosOc9r3sSdxz pkh9LhabA6FSzvvFPvkWDj9s6KRRlHsuQNjUdwKLaYLTkAFUzLUTIMGC2FOdx81kopsn MqMmtzToNz/0o/1RXEAMzD/UHYxmdq88TQ50kT089eXhvMwlEoHNeuTITPKcHFzuO8UW fQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2sdq1qsgh0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 May 2019 08:01:04 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x4G7xqr1173721; Thu, 16 May 2019 08:01:04 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2sggdt1snv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 16 May 2019 08:01:04 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x4G813m4016960; Thu, 16 May 2019 08:01:03 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 16 May 2019 01:01:02 -0700 Date: Thu, 16 May 2019 11:00:56 +0300 From: Dan Carpenter To: Hariprasad Kelam Cc: Greg Kroah-Hartman , Hardik Singh Rathore , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: core: rtw_recv: fix warning Comparison to NULL Message-ID: <20190516080056.GH31203@kadam> References: <20190515174536.GA4965@hari-Inspiron-1545> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515174536.GA4965@hari-Inspiron-1545> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9258 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905160054 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9258 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905160054 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 15, 2019 at 11:15:36PM +0530, Hariprasad Kelam wrote: > @@ -1042,7 +1042,7 @@ sint sta2ap_data_frame( > } > > *psta = rtw_get_stainfo(pstapriv, pattrib->src); > - if (*psta == NULL) { > + if (!*psta == NULL) { ^^^^^^^^^^^^^^ It's surprising that this didn't cause some kind of warning somewhere... > RT_TRACE(_module_rtl871x_recv_c_, _drv_err_, ("can't get psta under AP_MODE; drop pkt\n")); > DBG_871X("issue_deauth to sta =" MAC_FMT " for the reason(7)\n", MAC_ARG(pattrib->src)); > regards, dan carpenter