From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: Regression in xen-unstable due to commit 3802ecbaa9eb36 Date: Thu, 16 May 2019 12:57:35 +0200 Message-ID: <20190516125735.6c1bf1ca.ohering@suse.com> References: <1ae5e201-04d0-2f78-878f-2e3a3e213b62@suse.com> <20190516110735.67e19d15.ohering@suse.com> <20190516104540.7hiqsn6qjeaam2c6@Air-de-Roger> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1850854028604749198==" Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hRE51-00071m-Nk for xen-devel@lists.xenproject.org; Thu, 16 May 2019 10:57:43 +0000 In-Reply-To: <20190516104540.7hiqsn6qjeaam2c6@Air-de-Roger> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Roger Pau =?UTF-8?B?TW9ubsOp?= Cc: Juergen Gross , Wei Liu , Ian Jackson , xen-devel List-Id: xen-devel@lists.xenproject.org --===============1850854028604749198== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/WIdtaROZ2VCemD2o8GefReS"; protocol="application/pgp-signature" --Sig_/WIdtaROZ2VCemD2o8GefReS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Thu, 16 May 2019 12:45:40 +0200 schrieb Roger Pau Monn=C3=A9 : > Having a field in build_info with a default value that depends on > fields outside of build_info is problematic, since not all callers of > libxl__domain_build_info_setdefault have access to libxl_domain_config. One option would be a new API that gets a libxl_domain_config and which calls libxl__domain_set_device_model, libxl__domain_create_info_setdefault and libxl__domain_build_info_setdefault. To me it looks like create_domain can not build a proper d_config all on its own, it just has not enough info. Olaf --Sig_/WIdtaROZ2VCemD2o8GefReS Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCXN1CHwAKCRBdQqD6ppg2 fsN0AKDQBG4D/Nyh+IFwIgmk7Yyv3nEGyQCgzCnUzbJ/xeKtLCyVOFDrEE4OZew= =nju0 -----END PGP SIGNATURE----- --Sig_/WIdtaROZ2VCemD2o8GefReS-- --===============1850854028604749198== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============1850854028604749198==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEA53C04AAF for ; Thu, 16 May 2019 10:58:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 897662070D for ; Thu, 16 May 2019 10:58:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 897662070D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hRE53-00072W-7C; Thu, 16 May 2019 10:57:45 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hRE51-00071m-Nk for xen-devel@lists.xenproject.org; Thu, 16 May 2019 10:57:43 +0000 X-Inumbo-ID: 6bffc3fe-77c9-11e9-a165-c37ec909e434 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 6bffc3fe-77c9-11e9-a165-c37ec909e434; Thu, 16 May 2019 10:57:40 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E1682AFD6; Thu, 16 May 2019 10:57:38 +0000 (UTC) Date: Thu, 16 May 2019 12:57:35 +0200 From: Olaf Hering To: Roger Pau =?UTF-8?B?TW9ubsOp?= Message-ID: <20190516125735.6c1bf1ca.ohering@suse.com> In-Reply-To: <20190516104540.7hiqsn6qjeaam2c6@Air-de-Roger> References: <1ae5e201-04d0-2f78-878f-2e3a3e213b62@suse.com> <20190516110735.67e19d15.ohering@suse.com> <20190516104540.7hiqsn6qjeaam2c6@Air-de-Roger> X-Mailer: Claws Mail 2019.04.26 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Subject: Re: [Xen-devel] Regression in xen-unstable due to commit 3802ecbaa9eb36 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , Wei Liu , Ian Jackson , xen-devel Content-Type: multipart/mixed; boundary="===============1850854028604749198==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190516105735.XqUxy8rfr9iDj8VGn-Fkrew3ARG0AhYhegYk9_tNC_c@z> --===============1850854028604749198== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/WIdtaROZ2VCemD2o8GefReS"; protocol="application/pgp-signature" --Sig_/WIdtaROZ2VCemD2o8GefReS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am Thu, 16 May 2019 12:45:40 +0200 schrieb Roger Pau Monn=C3=A9 : > Having a field in build_info with a default value that depends on > fields outside of build_info is problematic, since not all callers of > libxl__domain_build_info_setdefault have access to libxl_domain_config. One option would be a new API that gets a libxl_domain_config and which calls libxl__domain_set_device_model, libxl__domain_create_info_setdefault and libxl__domain_build_info_setdefault. To me it looks like create_domain can not build a proper d_config all on its own, it just has not enough info. Olaf --Sig_/WIdtaROZ2VCemD2o8GefReS Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCXN1CHwAKCRBdQqD6ppg2 fsN0AKDQBG4D/Nyh+IFwIgmk7Yyv3nEGyQCgzCnUzbJ/xeKtLCyVOFDrEE4OZew= =nju0 -----END PGP SIGNATURE----- --Sig_/WIdtaROZ2VCemD2o8GefReS-- --===============1850854028604749198== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============1850854028604749198==--