From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: Regression in xen-unstable due to commit 3802ecbaa9eb36 Date: Thu, 16 May 2019 13:38:57 +0200 Message-ID: <20190516133857.742e4f13.ohering@suse.com> References: <1ae5e201-04d0-2f78-878f-2e3a3e213b62@suse.com> <20190516110735.67e19d15.ohering@suse.com> <20190516104540.7hiqsn6qjeaam2c6@Air-de-Roger> <20190516125735.6c1bf1ca.ohering@suse.com> <20190516112450.GW2798@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4344895836808377484==" Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hREj5-0002o4-6U for xen-devel@lists.xenproject.org; Thu, 16 May 2019 11:39:07 +0000 In-Reply-To: <20190516112450.GW2798@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Wei Liu Cc: Juergen Gross , xen-devel , Ian Jackson , Roger Pau =?UTF-8?B?TW9ubsOp?= List-Id: xen-devel@lists.xenproject.org --===============4344895836808377484== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/rCcMbuleSmr=hZMmtAYln1Z"; protocol="application/pgp-signature" --Sig_/rCcMbuleSmr=hZMmtAYln1Z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 16 May 2019 12:24:50 +0100 schrieb Wei Liu : > The problem with this approach is that it doesn't help existing libxl > users. They will need to be fixed by calling this new API. If the API needs to be changed, a LIBXL_HAVE_ came with the change. I'm not sure how to fix this without changing some API. libxl__domain_build_info_setdefault would need a d_config to make a usable decision. The callers do not have a d_config. And what their calles have is an incomplete d_config because libxl lacks a public API to properly populate missing defaults in d_config. To me it looks like something like libxl_domain_config_finish(libxl_domain_= config*) is missing now. Maybe I am just misunderstanding what you trying to say, but to me it looks like freemem() would need to call an updated libxl public API anyway. Surely not freemem itself, but xl:create_domain as a whole. Olaf --Sig_/rCcMbuleSmr=hZMmtAYln1Z Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCXN1L0QAKCRBdQqD6ppg2 fk1QAJ9sVUkYV/bAQeMpVGi76Ssg/MAjuACg8CVs0nmd5+fWfSvF+EsofXELfqY= =q0Yv -----END PGP SIGNATURE----- --Sig_/rCcMbuleSmr=hZMmtAYln1Z-- --===============4344895836808377484== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============4344895836808377484==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61955C04AAF for ; Thu, 16 May 2019 11:39:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3952F20833 for ; Thu, 16 May 2019 11:39:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3952F20833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hREj6-0002oX-Tf; Thu, 16 May 2019 11:39:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hREj5-0002o4-6U for xen-devel@lists.xenproject.org; Thu, 16 May 2019 11:39:07 +0000 X-Inumbo-ID: 343f6d92-77cf-11e9-b3fe-c785963200b9 Received: from mx1.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 343f6d92-77cf-11e9-b3fe-c785963200b9; Thu, 16 May 2019 11:39:03 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 91722AFBF; Thu, 16 May 2019 11:39:02 +0000 (UTC) Date: Thu, 16 May 2019 13:38:57 +0200 From: Olaf Hering To: Wei Liu Message-ID: <20190516133857.742e4f13.ohering@suse.com> In-Reply-To: <20190516112450.GW2798@zion.uk.xensource.com> References: <1ae5e201-04d0-2f78-878f-2e3a3e213b62@suse.com> <20190516110735.67e19d15.ohering@suse.com> <20190516104540.7hiqsn6qjeaam2c6@Air-de-Roger> <20190516125735.6c1bf1ca.ohering@suse.com> <20190516112450.GW2798@zion.uk.xensource.com> X-Mailer: Claws Mail 2019.04.26 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Subject: Re: [Xen-devel] Regression in xen-unstable due to commit 3802ecbaa9eb36 X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Juergen Gross , xen-devel , Ian Jackson , Roger Pau =?UTF-8?B?TW9ubsOp?= Content-Type: multipart/mixed; boundary="===============4344895836808377484==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190516113857.-VcaTk2pavj-DhfMDYPLZYtvdTL-K0HwKoPu1lHtfxM@z> --===============4344895836808377484== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/rCcMbuleSmr=hZMmtAYln1Z"; protocol="application/pgp-signature" --Sig_/rCcMbuleSmr=hZMmtAYln1Z Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 16 May 2019 12:24:50 +0100 schrieb Wei Liu : > The problem with this approach is that it doesn't help existing libxl > users. They will need to be fixed by calling this new API. If the API needs to be changed, a LIBXL_HAVE_ came with the change. I'm not sure how to fix this without changing some API. libxl__domain_build_info_setdefault would need a d_config to make a usable decision. The callers do not have a d_config. And what their calles have is an incomplete d_config because libxl lacks a public API to properly populate missing defaults in d_config. To me it looks like something like libxl_domain_config_finish(libxl_domain_= config*) is missing now. Maybe I am just misunderstanding what you trying to say, but to me it looks like freemem() would need to call an updated libxl public API anyway. Surely not freemem itself, but xl:create_domain as a whole. Olaf --Sig_/rCcMbuleSmr=hZMmtAYln1Z Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCXN1L0QAKCRBdQqD6ppg2 fk1QAJ9sVUkYV/bAQeMpVGi76Ssg/MAjuACg8CVs0nmd5+fWfSvF+EsofXELfqY= =q0Yv -----END PGP SIGNATURE----- --Sig_/rCcMbuleSmr=hZMmtAYln1Z-- --===============4344895836808377484== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============4344895836808377484==--