From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F351CC04AAF for ; Thu, 16 May 2019 23:25:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C10F82070D for ; Thu, 16 May 2019 23:25:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="OEzT3yeI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbfEPXZ1 (ORCPT ); Thu, 16 May 2019 19:25:27 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41887 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726666AbfEPXZ1 (ORCPT ); Thu, 16 May 2019 19:25:27 -0400 Received: by mail-pg1-f195.google.com with SMTP id z3so2299463pgp.8 for ; Thu, 16 May 2019 16:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/CBAL7ziIilFr4+6cSFD+fB4hY4nta8zjkUko7+t7ZY=; b=OEzT3yeIG+tU1P2txqT+HuWmNI+RqOGYK1meZsH1GEV6z/m2X+J8LMxM60P8tqxUZc lseBoeS+upXVripcBe6yx7gaUtGbkYO1UYq/+7PlGbIwpoIRDbBvQROcMA1uyQq6pcby XBpDqjXxsvOO8tCEDHkxPt+gRA2vCpa2GjolcqRdKKKa+01nIT1OsUJv8e64Z/B4no92 Y2sxhV4zI2awJVeCEvfLBmXgqpvhht3BdbvEyaOTxCz4M8y1ZnDRPKXdEUkfZONu+QwE Cdte098mCvIDHrh6NR794vD73NuZyLYiTpD700Wx/lOK9QCe+ZaazY+r/SdCnmZaElvZ JtsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/CBAL7ziIilFr4+6cSFD+fB4hY4nta8zjkUko7+t7ZY=; b=gxzhxQ4aPnbuiWGINogXeCKHj4FJtm3aZQBSwd8fFLGyIgHAkymqz2/sprITSuv+/l StomZFi6vJkudlaDQIx6ZbWp+Un0RxrV5HmcWC1oIfcdWLS6WX0P0HSHSsuazZ5m1X/k 76wwreAoPEXssB3kkfQwl2IBkQNzAYQuTseqYKRwcXpc5SQA3jppAKTEhh6V6itbEm/q iWAGEPhxMy7l9g+wHMy82v0yFSMwIM6neOxBoAl3+2esPS5DWmKk3GEGMHOZUrAM0CMj t+cCVF06X37GrcjSIFrcxoojUrq0D7k6OUTFgt9zLqouAKvgiAIWLcFpA7QaGN17ksgG bcng== X-Gm-Message-State: APjAAAVltfUKveMlPh8KrSQpuAGtDlrfQ7+bHeaxgUwaUFDZN/yosjnl RZdFamoL3utwY+w15sn3pNvz1Q== X-Google-Smtp-Source: APXvYqzFutdViqEsg6s4Naj7gr4QHnXUIId7UOF4ecSL+mRePIasDB28+rtypiEWa7VdWcBA9L+c5g== X-Received: by 2002:a63:7989:: with SMTP id u131mr44898655pgc.180.1558049126774; Thu, 16 May 2019 16:25:26 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id i22sm7701552pfa.127.2019.05.16.16.25.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 16:25:26 -0700 (PDT) Date: Thu, 16 May 2019 16:25:19 -0700 From: Stephen Hemminger To: Jakub Kicinski Cc: netdev@vger.kernel.org, davem@davemloft.net, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org, Stephen Hemminger Subject: Re: [PATCH net 3/3] netdevice: clarify meaning of rx_handler_result Message-ID: <20190516162519.06910fa9@hermes.lan> In-Reply-To: <20190516152543.729c6cb0@cakuba.netronome.com> References: <20190516215423.14185-1-sthemmin@microsoft.com> <20190516215423.14185-4-sthemmin@microsoft.com> <20190516152543.729c6cb0@cakuba.netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, 16 May 2019 15:25:43 -0700 Jakub Kicinski wrote: > On Thu, 16 May 2019 14:54:23 -0700, Stephen Hemminger wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index 44b47e9df94a..56f613561909 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -374,10 +374,10 @@ typedef enum gro_result gro_result_t; > > > > /* > > * enum rx_handler_result - Possible return values for rx_handlers. > > - * @RX_HANDLER_CONSUMED: skb was consumed by rx_handler, do not process it > > - * further. > > - * @RX_HANDLER_ANOTHER: Do another round in receive path. This is indicated in > > - * case skb->dev was changed by rx_handler. > > + * @RX_HANDLER_CONSUMED: skb was consumed by rx_handler. > > + * Do not process it further. > > + * @RX_HANDLER_ANOTHER: skb->dev was modified by rx_handler, > > + * Do another round in receive path. This is indicated in > > s/ This is indicated in// Thanks, left over from previous version forgot to trim.