From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1hRX47-0003lV-Hu for mharc-grub-devel@gnu.org; Fri, 17 May 2019 03:14:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hRX45-0003kL-7O for grub-devel@gnu.org; Fri, 17 May 2019 03:14:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hRX43-0007ot-EQ for grub-devel@gnu.org; Fri, 17 May 2019 03:14:01 -0400 Received: from smtp2.provo.novell.com ([137.65.250.81]:47757) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hRX41-0007cZ-MC for grub-devel@gnu.org; Fri, 17 May 2019 03:13:58 -0400 Received: from mazu (prva10-snat226-2.provo.novell.com [137.65.226.36]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Fri, 17 May 2019 01:13:24 -0600 Date: Fri, 17 May 2019 15:13:20 +0800 From: Michael Chang To: The development of GNU GRUB Cc: Neil MacLeod Subject: Re: gcc9.1 and f2fs Message-ID: <20190517071320.GC31228@mazu> Mail-Followup-To: The development of GNU GRUB , Neil MacLeod References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 137.65.250.81 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2019 07:14:02 -0000 Hello John, Except for lacking commit message and SOB, the fix is LGTM. You could add my Reviewed-by: Michael Chang if you resend the patch to mailing list with those missing message fixed. Thanks, Michael On Mon, May 06, 2019 at 07:59:42PM +0200, John Paul Adrian Glaubitz wrote: > On 5/6/19 7:15 PM, Neil MacLeod wrote: > > Does anyone have a patch? > > Try the attached patch. > > Adrian > > -- > .''`. John Paul Adrian Glaubitz > : :' : Debian Developer - glaubitz@debian.org > `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de > `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913 > >From b0d03dd5605220d0d23d72e662f10ce7b02a54a6 Mon Sep 17 00:00:00 2001 > From: John Paul Adrian Glaubitz > Date: Mon, 6 May 2019 19:55:01 +0200 > Subject: [PATCH] f2fs: Disable gcc9 -Waddress-of-packed-member > > --- > grub-core/fs/f2fs.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/grub-core/fs/f2fs.c b/grub-core/fs/f2fs.c > index 1cad2615f..0dd09bc23 100644 > --- a/grub-core/fs/f2fs.c > +++ b/grub-core/fs/f2fs.c > @@ -1235,6 +1235,12 @@ grub_f2fs_utf16_to_utf8 (grub_uint16_t *in_buf_le) > return out_buf; > } > > + > +#if __GNUC__ >= 9 > +#pragma GCC diagnostic push > +#pragma GCC diagnostic ignored "-Waddress-of-packed-member" > +#endif > + > static grub_err_t > grub_f2fs_label (grub_device_t device, char **label) > { > @@ -1255,6 +1261,10 @@ grub_f2fs_label (grub_device_t device, char **label) > return grub_errno; > } > > +#if __GNUC__ >= 9 > +#pragma GCC diagnostic pop > +#endif > + > static grub_err_t > grub_f2fs_uuid (grub_device_t device, char **uuid) > { > -- > 2.20.1 > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel