From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH v1] libxl: fix device_model_version related assert Date: Fri, 17 May 2019 10:24:45 +0200 Message-ID: <20190517102445.709835c8.olaf@aepfle.de> References: <20190516125000.23559-1-olaf@aepfle.de> <20190516133013.GG2798@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8565585243473874945==" Return-path: Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hRYAm-0001q8-K7 for xen-devel@lists.xenproject.org; Fri, 17 May 2019 08:25:01 +0000 In-Reply-To: <20190516133013.GG2798@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Wei Liu Cc: xen-devel@lists.xenproject.org, Ian Jackson List-Id: xen-devel@lists.xenproject.org --===============8565585243473874945== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_//8c7EknW2ybWI_Gj=g4myKt"; protocol="application/pgp-signature" --Sig_//8c7EknW2ybWI_Gj=g4myKt Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 16 May 2019 14:30:13 +0100 schrieb Wei Liu : > @@ -457,6 +457,12 @@ int libxl_domain_need_memory(libxl_ctx *ctx, > + if (!b_info->device_model_version) > + b_info->device_model_version =3D LIBXL_DEVICE_MODEL_XXX; I think this will work and should be applied to unbreak staging. The proposed libxl_domain_config_finalyze(libxl_domain_config*) in the other thread about the regression will most likely be ugly. Something more elegant has to be found. Olaf --Sig_//8c7EknW2ybWI_Gj=g4myKt Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCXN5vzQAKCRBdQqD6ppg2 fi90AKCT0PecpQuXD8S90Kg37FUlNhKPUQCg8IQn2RHvfQeGSU5n5A2CNd9gIic= =kGgl -----END PGP SIGNATURE----- --Sig_//8c7EknW2ybWI_Gj=g4myKt-- --===============8565585243473874945== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============8565585243473874945==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC2A0C04AB4 for ; Fri, 17 May 2019 08:25:17 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C32A20818 for ; Fri, 17 May 2019 08:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=aepfle.de header.i=@aepfle.de header.b="smjSdr9G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C32A20818 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aepfle.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hRYAo-0001qD-1S; Fri, 17 May 2019 08:25:02 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hRYAm-0001q8-K7 for xen-devel@lists.xenproject.org; Fri, 17 May 2019 08:25:01 +0000 X-Inumbo-ID: 41bdbaf4-787d-11e9-8980-bc764e045a96 Received: from mo6-p00-ob.smtp.rzone.de (unknown [2a01:238:20a:202:5300::12]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 41bdbaf4-787d-11e9-8980-bc764e045a96; Fri, 17 May 2019 08:24:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1558081497; s=strato-dkim-0002; d=aepfle.de; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=ikKw8LttSyVJFQTL+m7syHlWpHYIZRIyMh9UT462qtw=; b=smjSdr9GagSeiAJEkcM0c2ArG/KmHX7nAQeSXJpC5KFHgpKTZpeDMGnKC72J/9pjcg VnbBHcByoESX0VQYkoq2MIXTifaQVaMSxeEfdjlqXOhcf23VsmogpBDoHSwSHSfuKQrF X2u4G9yrqgXMdW5NwlXu0T2Kl99y+E92viWkePYOzRB+rPmWXDsLqj6p9ioqmkLeapJp QdI1Pw9SlVtPR+rL/tdDswmG7Ra/KIA1+cAEewfE9x4evzGYAK2XoyYHbh/moZhoSBa8 /qZyyNL0YzmY7Qkv3vUfez3wXueHW/QYCACY4iyWBU4SnWC0NYgPxr6y0w+1N9d96Plr uBvw== X-RZG-AUTH: ":P2EQZWCpfu+qG7CngxMFH1J+3q8wa/QED/SSGq+wjGiUC4AUztn93FPS2dyuYM9k3Q==" X-RZG-CLASS-ID: mo00 Received: from sender by smtp.strato.de (RZmta 44.20 SBL|AUTH) with ESMTPSA id U080cav4H8OsIAz (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Fri, 17 May 2019 10:24:54 +0200 (CEST) Date: Fri, 17 May 2019 10:24:45 +0200 From: Olaf Hering To: Wei Liu Message-ID: <20190517102445.709835c8.olaf@aepfle.de> In-Reply-To: <20190516133013.GG2798@zion.uk.xensource.com> References: <20190516125000.23559-1-olaf@aepfle.de> <20190516133013.GG2798@zion.uk.xensource.com> X-Mailer: Claws Mail 2019.05.14 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v1] libxl: fix device_model_version related assert X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: xen-devel@lists.xenproject.org, Ian Jackson Content-Type: multipart/mixed; boundary="===============8565585243473874945==" Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" Message-ID: <20190517082445.OBTUUMDnixzSGh6X10QW_BLZvmyRWdqw0sXpX7QLN6I@z> --===============8565585243473874945== Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_//8c7EknW2ybWI_Gj=g4myKt"; protocol="application/pgp-signature" --Sig_//8c7EknW2ybWI_Gj=g4myKt Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Am Thu, 16 May 2019 14:30:13 +0100 schrieb Wei Liu : > @@ -457,6 +457,12 @@ int libxl_domain_need_memory(libxl_ctx *ctx, > + if (!b_info->device_model_version) > + b_info->device_model_version =3D LIBXL_DEVICE_MODEL_XXX; I think this will work and should be applied to unbreak staging. The proposed libxl_domain_config_finalyze(libxl_domain_config*) in the other thread about the regression will most likely be ugly. Something more elegant has to be found. Olaf --Sig_//8c7EknW2ybWI_Gj=g4myKt Content-Type: application/pgp-signature Content-Description: Digitale Signatur von OpenPGP -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCXN5vzQAKCRBdQqD6ppg2 fi90AKCT0PecpQuXD8S90Kg37FUlNhKPUQCg8IQn2RHvfQeGSU5n5A2CNd9gIic= =kGgl -----END PGP SIGNATURE----- --Sig_//8c7EknW2ybWI_Gj=g4myKt-- --===============8565585243473874945== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0 cy54ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== --===============8565585243473874945==--