From: Lee Jones <lee.jones@linaro.org>
To: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Cc: "David S. Miller" <davem@davemloft.net>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lib: Correct comment of prandom_seed
Date: Fri, 17 May 2019 11:50:30 +0100 [thread overview]
Message-ID: <20190517105030.GV4319@dell> (raw)
In-Reply-To: <AM0PR07MB44176BAB0BA6ACAAA8C6DC88FD0B0@AM0PR07MB4417.eurprd07.prod.outlook.com>
On Fri, 17 May 2019, Philippe Mazenauer wrote:
> Variable 'entropy' was wrongly documented as 'seed', changed comment to
> reflect actual variable name.
>
> ../lib/random32.c:179: warning: Function parameter or member 'entropy' not described in 'prandom_seed'
> ../lib/random32.c:179: warning: Excess function parameter 'seed' description in 'prandom_seed'
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
> ---
> lib/random32.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Looks reasonable:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-05-17 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 10:44 [PATCH] lib: Correct comment of prandom_seed Philippe Mazenauer
2019-05-17 10:50 ` Lee Jones [this message]
2019-05-17 18:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190517105030.GV4319@dell \
--to=lee.jones@linaro.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philippe.mazenauer@outlook.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.