All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Uma Shankar <uma.shankar@intel.com>
Cc: dcastagna@chromium.org, jonas@kwiboo.se,
	intel-gfx@lists.freedesktop.org, emil.l.velikov@gmail.com,
	dri-devel@lists.freedesktop.org, seanpaul@chromium.org
Subject: Re: [v11 05/12] drm/i915: Attach HDR metadata property to connector
Date: Fri, 17 May 2019 17:06:38 +0300	[thread overview]
Message-ID: <20190517140638.GT24299@intel.com> (raw)
In-Reply-To: <1558015817-12025-6-git-send-email-uma.shankar@intel.com>

On Thu, May 16, 2019 at 07:40:10PM +0530, Uma Shankar wrote:
> Attach HDR metadata property to connector object.
> 
> v2: Rebase
> 
> v3: Updated the property name as per updated name
> while creating hdr metadata property
> 
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_hdmi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index 2a4086c..92597d8 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -2724,6 +2724,8 @@ static void intel_hdmi_destroy(struct drm_connector *connector)
>  
>  	drm_connector_attach_content_type_property(connector);
>  	connector->state->picture_aspect_ratio = HDMI_PICTURE_ASPECT_NONE;
> +	drm_object_attach_property(&connector->base,
> +				   connector->dev->mode_config.hdr_output_metadata_property, 0);

I think this needs a platform check. We shouldn't expose this on
platforms that can't actually transmit the infoframe.

>  
>  	if (!HAS_GMCH(dev_priv))
>  		drm_connector_attach_max_bpc_property(connector, 8, 12);
> -- 
> 1.9.1

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-05-17 14:06 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16 14:10 [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer Uma Shankar
2019-05-16 14:10 ` [v11 01/12] drm: Add HDR source metadata property Uma Shankar
2019-05-16 14:10 ` [v11 02/12] drm: Add reference counting on HDR metadata blob Uma Shankar
2019-05-16 14:10 ` [v11 03/12] drm: Parse HDR metadata info from EDID Uma Shankar
2019-05-16 14:10 ` [v11 04/12] drm: Enable HDR infoframe support Uma Shankar
2019-05-16 14:10 ` [v11 05/12] drm/i915: Attach HDR metadata property to connector Uma Shankar
2019-05-17 14:06   ` Ville Syrjälä [this message]
2019-05-17 16:19     ` [v12 " Uma Shankar
2019-05-16 14:10 ` [v11 06/12] drm/i915: Write HDR infoframe and send to panel Uma Shankar
2019-05-17 14:06   ` Ville Syrjälä
2019-05-17 16:20     ` [v12 " Uma Shankar
2019-05-18 10:39       ` [v13 " Uma Shankar
2019-05-16 14:10 ` [v11 07/12] drm: Add HLG EOTF Uma Shankar
2019-05-16 14:10 ` [v11 08/12] drm/i915: Enable infoframes on GLK+ for HDR Uma Shankar
2019-05-17 14:01   ` Ville Syrjälä
2019-05-17 16:22     ` [v12 " Uma Shankar
2019-05-16 14:10 ` [v11 09/12] drm/i915:Enabled Modeset when HDR Infoframe changes Uma Shankar
2019-05-16 14:10 ` [v11 10/12] drm/i915: Added DRM Infoframe handling for BYT/CHT Uma Shankar
2019-05-16 14:10 ` [v11 11/12] video/hdmi: Add Unpack function for DRM infoframe Uma Shankar
2019-05-16 14:10 ` [v11 12/12] drm/i915: Add state readout " Uma Shankar
2019-05-16 14:12 ` ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev11) Patchwork
2019-05-16 14:37 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-16 19:35 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-17 16:07 ` ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev14) Patchwork
2019-05-17 16:34 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-18  3:18 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-05-18 10:27 ` ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev15) Patchwork
2019-05-18 10:47 ` ✓ Fi.CI.BAT: success " Patchwork
2019-05-18 15:47 ` ✓ Fi.CI.IGT: " Patchwork
2019-05-22 20:45 ` [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer Ville Syrjälä
2019-05-23  8:09   ` Jani Nikula
2019-05-23  8:41     ` [Intel-gfx] " Daniel Vetter
2019-05-28 11:35   ` Maarten Lankhorst
2019-05-28 11:43     ` Shankar, Uma
2019-05-29  9:43 ` Daniel Vetter
2019-05-29 13:58   ` Shankar, Uma
2019-05-29 15:03     ` [Intel-gfx] " Daniel Vetter
2019-05-29 17:28       ` Shankar, Uma
2019-05-29 17:35         ` Daniel Vetter
2019-05-29 17:39           ` [Intel-gfx] " Shankar, Uma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517140638.GT24299@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dcastagna@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jonas@kwiboo.se \
    --cc=seanpaul@chromium.org \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.