From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:c793:0:0:0:0:0 with SMTP id l19csp4361103wrg; Sun, 19 May 2019 18:03:35 -0700 (PDT) X-Google-Smtp-Source: APXvYqxbv11u8RPD2uc1W2wLlGH4H4dVJG00bzP2ThdqvftF3cM872iO7uPwPyq/P9K2WMzjYs/i X-Received: by 2002:a17:906:1f55:: with SMTP id d21mr34889676ejk.87.1558314215287; Sun, 19 May 2019 18:03:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558314215; cv=none; d=google.com; s=arc-20160816; b=ph8r3p9+VRUWvL+AGXkk9RWcbU48323SN+sBxit0RMYq1r+pRF/eo+bvQ26YRQt+I1 upgTtQWT5DuRwA40WugAa64DNbakESPz2L5Aikq4HoNODOp+Cn4A1+fJNA0yqbV6Y+TO CRfjQimUDl4gbuU8s5DLPTqP8uZcTwgjHI5BNlo6NQ6ml8c7xE7v4vtVjAfUGrNzuCNV uWE/TLmpMzmzVXhZOE9s6PhNRGKpOeQW8FMt8vthfWHBsHrOeHrvS2BUYAFCj/tQBqkf IPcr93bOVWFE4vADjC4WvWAUallaowcYfvO1+f4X9g6GDiJkMornjWchpqk2AN5l3V4z bSRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from; bh=3NFgEDg0K5EJZFI752dxWGlVjvIxazz+OSi8ODMo23I=; b=p5MLKpPi0+8mY9Ip/cWMDJ95tcRcjHHImLeVP2JXF59th2oT+XfVxJYPNYeyb98QZk AyZ7pb/j2yqXUF+s4KYveDxouLeLqTgA0MNDTWxGcpmMohKJkaHyWzDATi3W8iVLW0lA i73ZFrRHxgLYbCBxCfMyxuUqBNi66+KPTBdccvULkBMm1aPVOW/OdtBxiFcb20216hvq HJrHYcojntiDV/T+3jOECkGqIorm93P3MGHCY59dpfg6/DghrDpKsuoOruj9x6k69TSi zgj9M0p9xa8PfeFcuCW8dOLoiTvvOS6jUEmgLOZSGtbnboOe5Ca+2Qaxst2AM4HATx87 9uiA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id x8si5336245eje.313.2019.05.19.18.03.35 for (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 19 May 2019 18:03:35 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from localhost ([127.0.0.1]:55725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSWiE-0002Mt-6x for alex.bennee@linaro.org; Sun, 19 May 2019 21:03:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSWff-0000if-3U for qemu-devel@nongnu.org; Sun, 19 May 2019 21:00:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hSWfd-0006ci-UD for qemu-devel@nongnu.org; Sun, 19 May 2019 21:00:55 -0400 Received: from mga04.intel.com ([192.55.52.120]:13790) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hSWfb-0006aZ-QQ; Sun, 19 May 2019 21:00:52 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 May 2019 18:00:51 -0700 X-ExtLoop1: 1 Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by orsmga008.jf.intel.com with ESMTP; 19 May 2019 18:00:49 -0700 From: Wei Yang To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Date: Mon, 20 May 2019 08:59:53 +0800 Message-Id: <20190520005957.6953-3-richardw.yang@linux.intel.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190520005957.6953-1-richardw.yang@linux.intel.com> References: <20190520005957.6953-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.120 Subject: [Qemu-devel] [PATCH v5 2/6] hw/arm/virt-acpi-build: remove unnecessary variable mcfg_start X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, peter.maydell@linaro.org, thuth@redhat.com, mst@redhat.com, shannon.zhaosl@gmail.com, Wei Yang , imammedo@redhat.com, philmd@redhat.com Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: ELsqVsnXhpeJ mcfg_start points to the start of MCFG table and is used in build_header. While this information could be derived from mcfg. This patch removes the unnecessary variable mcfg_start. Signed-off-by: Wei Yang Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé --- hw/arm/virt-acpi-build.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index bf9c0bc2f4..12dbaf3846 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -552,7 +552,6 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) const MemMapEntry *memmap = vms->memmap; int ecam_id = VIRT_ECAM_ID(vms->highmem_ecam); int len = sizeof(*mcfg) + sizeof(mcfg->allocation[0]); - int mcfg_start = table_data->len; mcfg = acpi_data_push(table_data, len); mcfg->allocation[0].address = cpu_to_le64(memmap[ecam_id].base); @@ -563,8 +562,7 @@ build_mcfg(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) mcfg->allocation[0].end_bus_number = PCIE_MMCFG_BUS(memmap[ecam_id].size - 1); - build_header(linker, table_data, (void *)(table_data->data + mcfg_start), - "MCFG", table_data->len - mcfg_start, 1, NULL, NULL); + build_header(linker, table_data, (void *)mcfg, "MCFG", len, 1, NULL, NULL); } /* GTDT */ -- 2.19.1