From: Sandeep Patil <sspatil@android.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis
Date: Mon, 20 May 2019 12:17:29 +0800 [thread overview]
Message-ID: <20190520041730.28238-1-sspatil@android.com> (raw)
This is an RFC patch to demonstrate that most of the pthread_* calls
in the open_posix_testsuite seem to be doing the return value checks
incorrectly. Most posix_* apis return positive errno on failure and 0 on
success.
PATCH 1/1 demonstrates the fixes needed for pthread_sigmask/6-1 for
example. This pattern is fairly widespread in open_posix_testsuite.
After going through the documentation in the project, I wasn't sure if I
tested this correctly. After building, I tried the following
$ cd testcases/open_posix_testsuite
$ ./bin/run_tesit.sh conformance/interfaces/pthread_sigmask pthread_sigmask_6-1.run-test
...and that keeps running into test being skipped due to missing file.
(I do have pthread_sigmask_6-1.run-test in place).
So, consider this build tested only for now. I'd love to know how we can
test this and if we are still using the testsuite, then I am happy to
fix rest of the places where its broken.
Sandeep Patil (1):
open_posix_testsuite/pthread_sigmask: fix return value checks
.../interfaces/pthread_sigmask/6-1.c | 69 +++++++++++--------
1 file changed, 40 insertions(+), 29 deletions(-)
--
2.21.0.1020.gf2820cf01a-goog
next reply other threads:[~2019-05-20 4:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 4:17 Sandeep Patil [this message]
2019-05-20 4:17 ` [LTP] [RFC PATCH 1/1] open_posix_testsuite/pthread_sigmask: fix return value checks Sandeep Patil
2019-05-20 9:53 ` Cyril Hrubis
2019-05-21 4:40 ` Sandeep Patil
2019-05-21 11:46 ` Cyril Hrubis
2019-05-20 9:49 ` [LTP] [RFC PATCH 0/1] Fix return value checks for posix apis Cyril Hrubis
2019-05-21 4:41 ` Sandeep Patil
2019-05-21 11:48 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520041730.28238-1-sspatil@android.com \
--to=sspatil@android.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.