From mboxrd@z Thu Jan 1 00:00:00 1970 From: "james qian wang (Arm Technology China)" Date: Mon, 20 May 2019 05:37:55 +0000 Subject: Re: drm/komeda: Potential error pointer dereference Message-Id: <20190520053748.GA1724@james-ThinkStation-P300> List-Id: References: <20190503122525.GA29695@mwanda> In-Reply-To: <20190503122525.GA29695@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: David Airlie , "kernel-janitors@vger.kernel.org" , nd , Liviu Dudau , "dri-devel@lists.freedesktop.org" Hi Dan On Fri, May 03, 2019 at 03:25:25PM +0300, Dan Carpenter wrote: > We need to check whether drm_atomic_get_crtc_state() returns an error > pointer before dereferencing "crtc_st". > > Fixes: 7d31b9e7a550 ("drm/komeda: Add komeda_plane/plane_helper_funcs") > Signed-off-by: Dan Carpenter > Acked-by: Liviu Dudau > --- > drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c > index 07ed0cc1bc44..c7e5fc6e5500 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_plane.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_plane.c > @@ -64,7 +64,7 @@ komeda_plane_atomic_check(struct drm_plane *plane, > return 0; > > crtc_st = drm_atomic_get_crtc_state(state->state, state->crtc); > - if (!crtc_st->enable) { > + if (IS_ERR(crtc_st) || !crtc_st->enable) { > DRM_DEBUG_ATOMIC("Cannot update plane on a disabled CRTC.\n"); > return -EINVAL; > } Thank you for the fixing. -- Reviewed-by: James Qian Wang (Arm Technology China) From mboxrd@z Thu Jan 1 00:00:00 1970 From: "james qian wang (Arm Technology China)" Subject: Re: drm/komeda: Potential error pointer dereference Date: Mon, 20 May 2019 05:37:55 +0000 Message-ID: <20190520053748.GA1724@james-ThinkStation-P300> References: <20190503122525.GA29695@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130043.outbound.protection.outlook.com [40.107.13.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6709A8915F for ; Mon, 20 May 2019 05:37:59 +0000 (UTC) In-Reply-To: <20190503122525.GA29695@mwanda> Content-Language: en-US Content-ID: <3ED8629A5D8EBD49B046F77750C758AD@eurprd08.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: David Airlie , "kernel-janitors@vger.kernel.org" , nd , Liviu Dudau , "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org SGkgRGFuIAoKT24gRnJpLCBNYXkgMDMsIDIwMTkgYXQgMDM6MjU6MjVQTSArMDMwMCwgRGFuIENh cnBlbnRlciB3cm90ZToKPiBXZSBuZWVkIHRvIGNoZWNrIHdoZXRoZXIgZHJtX2F0b21pY19nZXRf Y3J0Y19zdGF0ZSgpIHJldHVybnMgYW4gZXJyb3IKPiBwb2ludGVyIGJlZm9yZSBkZXJlZmVyZW5j aW5nICJjcnRjX3N0Ii4KPiAKPiBGaXhlczogN2QzMWI5ZTdhNTUwICgiZHJtL2tvbWVkYTogQWRk IGtvbWVkYV9wbGFuZS9wbGFuZV9oZWxwZXJfZnVuY3MiKQo+IFNpZ25lZC1vZmYtYnk6IERhbiBD YXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KPiBBY2tlZC1ieTogTGl2aXUgRHVk YXUgPGxpdml1LmR1ZGF1QGFybS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hcm0vZGlz cGxheS9rb21lZGEva29tZWRhX3BsYW5lLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKSwgMSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2Fy bS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfcGxhbmUuYwo+IGluZGV4IDA3ZWQwY2MxYmM0NC4uYzdl NWZjNmU1NTAwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxheS9rb21l ZGEva29tZWRhX3BsYW5lLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29t ZWRhL2tvbWVkYV9wbGFuZS5jCj4gQEAgLTY0LDcgKzY0LDcgQEAga29tZWRhX3BsYW5lX2F0b21p Y19jaGVjayhzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCQlyZXR1cm4gMDsKPiAgCj4gIAlj cnRjX3N0ID0gZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZS0+c3RhdGUsIHN0YXRlLT5j cnRjKTsKPiAtCWlmICghY3J0Y19zdC0+ZW5hYmxlKSB7Cj4gKwlpZiAoSVNfRVJSKGNydGNfc3Qp IHx8ICFjcnRjX3N0LT5lbmFibGUpIHsKPiAgCQlEUk1fREVCVUdfQVRPTUlDKCJDYW5ub3QgdXBk YXRlIHBsYW5lIG9uIGEgZGlzYWJsZWQgQ1JUQy5cbiIpOwo+ICAJCXJldHVybiAtRUlOVkFMOwo+ ICAJfQoKVGhhbmsgeW91IGZvciB0aGUgZml4aW5nLgotLSAKUmV2aWV3ZWQtYnk6IEphbWVzIFFp YW4gV2FuZyAoQXJtIFRlY2hub2xvZ3kgQ2hpbmEpIDxqYW1lcy5xaWFuLndhbmdAYXJtLmNvbT4K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs