All of lore.kernel.org
 help / color / mirror / Atom feed
From: hare@suse.de (Hannes Reinecke)
Subject: [PATCH 4/4] nvme-fc: align nvme_fc_delete_association() with exit path
Date: Mon, 20 May 2019 08:36:24 +0200	[thread overview]
Message-ID: <20190520063624.50338-5-hare@suse.de> (raw)
In-Reply-To: <20190520063624.50338-1-hare@suse.de>

nvme_fc_delete_association() should align with the exit path in
nvme_fc_create_association() to ensure we are able to handle the
failure case properly.

Signed-off-by: Hannes Reinecke <hare at suse.com>
---
 drivers/nvme/host/fc.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
index 71b22139e78b..ed9f4affbe10 100644
--- a/drivers/nvme/host/fc.c
+++ b/drivers/nvme/host/fc.c
@@ -2836,6 +2836,11 @@ nvme_fc_delete_association(struct nvme_fc_ctrl *ctrl)
 	ctrl->flags &= ~FCCTRL_TERMIO;
 	spin_unlock_irq(&ctrl->lock);
 
+	if (ctrl->ctrl.tagset) {
+		nvme_fc_delete_hw_io_queues(ctrl);
+		nvme_fc_free_io_queues(ctrl);
+	}
+
 	nvme_fc_term_aen_ops(ctrl);
 
 	/*
@@ -2847,11 +2852,6 @@ nvme_fc_delete_association(struct nvme_fc_ctrl *ctrl)
 	if (ctrl->association_id)
 		nvme_fc_xmt_disconnect_assoc(ctrl);
 
-	if (ctrl->ctrl.tagset) {
-		nvme_fc_delete_hw_io_queues(ctrl);
-		nvme_fc_free_io_queues(ctrl);
-	}
-
 	__nvme_fc_delete_hw_queue(ctrl, &ctrl->queues[0], 0);
 	nvme_fc_free_queue(&ctrl->queues[0]);
 
-- 
2.16.4

  parent reply	other threads:[~2019-05-20  6:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  6:36 [PATCH 0/4v3] nvme-fc: track state change failures Hannes Reinecke
2019-05-20  6:36 ` [PATCH 1/4] nvme: separate out nvme_ctrl_state_name() Hannes Reinecke
2019-05-21  6:46   ` Christoph Hellwig
2019-05-24  6:46   ` Sagi Grimberg
2019-05-24  7:33     ` Hannes Reinecke
2019-05-24 20:34   ` Keith Busch
2019-05-20  6:36 ` [PATCH 2/4] nvme-fc: track state change failures during reconnect Hannes Reinecke
2019-05-21  6:47   ` Christoph Hellwig
2019-05-24  6:51   ` Sagi Grimberg
2019-05-24  7:35     ` Hannes Reinecke
2019-05-20  6:36 ` [PATCH 3/4] nvme-fc: fail reconnect if state change fails Hannes Reinecke
2019-05-21 16:18   ` James Smart
2019-05-22 17:43   ` Arun Easi
2019-05-23  5:33     ` Hannes Reinecke
2019-05-23 15:46       ` James Smart
2019-05-23 15:52         ` [EXT] " Arun Easi
2019-05-20  6:36 ` Hannes Reinecke [this message]
2019-05-21 16:25   ` [PATCH 4/4] nvme-fc: align nvme_fc_delete_association() with exit path James Smart
2019-05-22 14:00     ` Hannes Reinecke
2019-05-23 16:01       ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520063624.50338-5-hare@suse.de \
    --to=hare@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.