From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Kocialkowski Subject: Re: [PATCH v3 5/7] drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height Date: Mon, 20 May 2019 13:32:59 +0200 Message-ID: <20190520113258.GC6789@aptenodytes> References: <27b0041c7977402df4a087c78d2849ffe51c9f1c.1558002671.git-series.maxime.ripard@bootlin.com> <514af1d489d80b8b1767e3716b663ce5103da6eb.1558002671.git-series.maxime.ripard@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8635892AD for ; Mon, 20 May 2019 11:33:04 +0000 (UTC) Content-Disposition: inline In-Reply-To: <514af1d489d80b8b1767e3716b663ce5103da6eb.1558002671.git-series.maxime.ripard@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul , Daniel Vetter , Emil Velikov List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiBUaHUgMTYgTWF5IDE5LCAxMjozMSwgTWF4aW1lIFJpcGFyZCB3cm90ZToKPiBTbyBm YXIsIHRoZSBkcm1fZm9ybWF0X3BsYW5lX2hlaWdodC93aWR0aCBmdW5jdGlvbnMgd2VyZSBvcGVy YXRpbmcgb24gdGhlCj4gZm9ybWF0J3MgZm91cmNjIGFuZCB3YXMgZG9pbmcgYSBsb29rdXAgdG8g cmV0cmlldmUgdGhlIGRybV9mb3JtYXRfaW5mbwo+IHN0cnVjdHVyZSBhbmQgcmV0dXJuIHRoZSBj cHAuCj4gCj4gSG93ZXZlciwgdGhpcyBpcyBpbmVmZmljaWVudCBzaW5jZSBpbiBtb3N0IGNhc2Vz LCB3ZSB3aWxsIGhhdmUgdGhlCj4gZHJtX2Zvcm1hdF9pbmZvIHBvaW50ZXIgYWxyZWFkeSBhdmFp bGFibGUgc28gd2Ugc2hvdWxkbid0IGhhdmUgdG8gcGVyZm9ybSBhCj4gbmV3IGxvb2t1cC4gU29t ZSBkcm1fZm91cmNjIGZ1bmN0aW9ucyBhbHNvIGFscmVhZHkgb3BlcmF0ZSBvbiB0aGUKPiBkcm1f Zm9ybWF0X2luZm8gcG9pbnRlciBmb3IgdGhhdCByZWFzb24sIHNvIHRoZSBBUEkgaXMgcXVpdGUg aW5jb25zaXN0ZW50Cj4gdGhlcmUuCj4gCj4gTGV0J3MgZm9sbG93IHRoZSBsYXR0ZXIgcGF0dGVy biBhbmQgcmVtb3ZlIHRoZSBleHRyYSBsb29rdXAgd2hpbGUgYmVpbmcgYQo+IGJpdCBtb3JlIGNv bnNpc3RlbnQuCj4gCj4gSW4gb3JkZXIgdG8gYmUgZXh0cmEgY29uc2lzdGVudCwgYWxzbyByZW5h bWUgdGhhdCBmdW5jdGlvbiB0bwo+IGRybV9mb3JtYXRfaW5mb19wbGFuZV9jcHAgYW5kIHRvIGEg c3RhdGljIGZ1bmN0aW9uIGluIHRoZSBoZWFkZXIgdG8gbWF0Y2gKPiB0aGUgY3VycmVudCBwb2xp Y3kuIFRoZSBwYXJhbWV0ZXJzIG9yZGVyIGhhdmUgYWxzbyBiZSBjaGFuZ2VkIHRvIG1hdGNoIHRo ZQo+IG90aGVyIGZ1bmN0aW9ucyBwcm90b3R5cGUuCgpTYW1lIGNvbW1lbnQgYWJvdXQgcGxhbmUg YmVpbmcgaW50IGluc3RlYWQgb2YgdW5zaWduZWQgaW50LCBidXQgSSB0aGluayB3ZQpjYW4gZml4 IHRoYXQgbGF0ZXIuCgpBbm90aGVyIHRoaW5nIHRoYXQgSSBmaW5kIG9kZCBpcyB0aGF0IHRoZSBk aXZpc2lvbiBieSB2c3ViL2hzdWIgaXMgbm90CnJvdW5kZWQgdXAsIGJ1dCBhZ2FpbiwgaXQncyBz b21ldGhpbmcgaW5kZXBlbmRlbnQgZnJvbSB5b3VyIHBhdGNoLgoKUmV2aWV3ZWQtYnk6IFBhdWwg S29jaWFsa293c2tpIDxwYXVsLmtvY2lhbGtvd3NraUBib290bGluLmNvbT4KCkNoZWVycywKClBh dWwKCj4gUmV2aWV3ZWQtYnk6IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5j b20+Cj4gU2lnbmVkLW9mZi1ieTogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGlu LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYyAgICAgICAgICB8IDQ4 ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tZXNvbi9t ZXNvbl9vdmVybGF5LmMgfCAxMiArKystLS0tCj4gIGluY2x1ZGUvZHJtL2RybV9mb3VyY2MuaCAg ICAgICAgICAgICAgfCA0NiArKysrKysrKysrKysrKysrKysrKysrKysrLS0KPiAgMyBmaWxlcyBj aGFuZ2VkLCA1MCBpbnNlcnRpb25zKCspLCA1NiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mb3VyY2MuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZm91 cmNjLmMKPiBpbmRleCA1ZjYzZmM3NGUyNjUuLjM1YjQ1OWQxODZjNSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2ZvdXJjYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9m b3VyY2MuYwo+IEBAIC0zMzMsNTQgKzMzMyw2IEBAIGRybV9nZXRfZm9ybWF0X2luZm8oc3RydWN0 IGRybV9kZXZpY2UgKmRldiwKPiAgRVhQT1JUX1NZTUJPTChkcm1fZ2V0X2Zvcm1hdF9pbmZvKTsK PiAgCj4gIC8qKgo+IC0gKiBkcm1fZm9ybWF0X3BsYW5lX3dpZHRoIC0gd2lkdGggb2YgdGhlIHBs YW5lIGdpdmVuIHRoZSBmaXJzdCBwbGFuZQo+IC0gKiBAd2lkdGg6IHdpZHRoIG9mIHRoZSBmaXJz dCBwbGFuZQo+IC0gKiBAZm9ybWF0OiBwaXhlbCBmb3JtYXQKPiAtICogQHBsYW5lOiBwbGFuZSBp bmRleAo+IC0gKgo+IC0gKiBSZXR1cm5zOgo+IC0gKiBUaGUgd2lkdGggb2YgQHBsYW5lLCBnaXZl biB0aGF0IHRoZSB3aWR0aCBvZiB0aGUgZmlyc3QgcGxhbmUgaXMgQHdpZHRoLgo+IC0gKi8KPiAt aW50IGRybV9mb3JtYXRfcGxhbmVfd2lkdGgoaW50IHdpZHRoLCB1aW50MzJfdCBmb3JtYXQsIGlu dCBwbGFuZSkKPiAtewo+IC0JY29uc3Qgc3RydWN0IGRybV9mb3JtYXRfaW5mbyAqaW5mbzsKPiAt Cj4gLQlpbmZvID0gZHJtX2Zvcm1hdF9pbmZvKGZvcm1hdCk7Cj4gLQlpZiAoIWluZm8gfHwgcGxh bmUgPj0gaW5mby0+bnVtX3BsYW5lcykKPiAtCQlyZXR1cm4gMDsKPiAtCj4gLQlpZiAocGxhbmUg PT0gMCkKPiAtCQlyZXR1cm4gd2lkdGg7Cj4gLQo+IC0JcmV0dXJuIHdpZHRoIC8gaW5mby0+aHN1 YjsKPiAtfQo+IC1FWFBPUlRfU1lNQk9MKGRybV9mb3JtYXRfcGxhbmVfd2lkdGgpOwo+IC0KPiAt LyoqCj4gLSAqIGRybV9mb3JtYXRfcGxhbmVfaGVpZ2h0IC0gaGVpZ2h0IG9mIHRoZSBwbGFuZSBn aXZlbiB0aGUgZmlyc3QgcGxhbmUKPiAtICogQGhlaWdodDogaGVpZ2h0IG9mIHRoZSBmaXJzdCBw bGFuZQo+IC0gKiBAZm9ybWF0OiBwaXhlbCBmb3JtYXQKPiAtICogQHBsYW5lOiBwbGFuZSBpbmRl eAo+IC0gKgo+IC0gKiBSZXR1cm5zOgo+IC0gKiBUaGUgaGVpZ2h0IG9mIEBwbGFuZSwgZ2l2ZW4g dGhhdCB0aGUgaGVpZ2h0IG9mIHRoZSBmaXJzdCBwbGFuZSBpcyBAaGVpZ2h0Lgo+IC0gKi8KPiAt aW50IGRybV9mb3JtYXRfcGxhbmVfaGVpZ2h0KGludCBoZWlnaHQsIHVpbnQzMl90IGZvcm1hdCwg aW50IHBsYW5lKQo+IC17Cj4gLQljb25zdCBzdHJ1Y3QgZHJtX2Zvcm1hdF9pbmZvICppbmZvOwo+ IC0KPiAtCWluZm8gPSBkcm1fZm9ybWF0X2luZm8oZm9ybWF0KTsKPiAtCWlmICghaW5mbyB8fCBw bGFuZSA+PSBpbmZvLT5udW1fcGxhbmVzKQo+IC0JCXJldHVybiAwOwo+IC0KPiAtCWlmIChwbGFu ZSA9PSAwKQo+IC0JCXJldHVybiBoZWlnaHQ7Cj4gLQo+IC0JcmV0dXJuIGhlaWdodCAvIGluZm8t PnZzdWI7Cj4gLX0KPiAtRVhQT1JUX1NZTUJPTChkcm1fZm9ybWF0X3BsYW5lX2hlaWdodCk7Cj4g LQo+IC0vKioKPiAgICogZHJtX2Zvcm1hdF9pbmZvX2Jsb2NrX3dpZHRoIC0gd2lkdGggaW4gcGl4 ZWxzIG9mIGJsb2NrLgo+ICAgKiBAaW5mbzogcGl4ZWwgZm9ybWF0IGluZm8KPiAgICogQHBsYW5l OiBwbGFuZSBpbmRleAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVzb25f b3ZlcmxheS5jIGIvZHJpdmVycy9ncHUvZHJtL21lc29uL21lc29uX292ZXJsYXkuYwo+IGluZGV4 IGZiODUxNWIyODYwYy4uNTViM2YyZjJlNjA4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9tZXNvbi9tZXNvbl9vdmVybGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbWVzb24vbWVz b25fb3ZlcmxheS5jCj4gQEAgLTQ2Niw4ICs0NjYsOCBAQCBzdGF0aWMgdm9pZCBtZXNvbl9vdmVy bGF5X2F0b21pY191cGRhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJcHJpdi0+dml1 LnZkMV9hZGRyMiA9IGdlbS0+cGFkZHIgKyBmYi0+b2Zmc2V0c1syXTsKPiAgCQlwcml2LT52aXUu dmQxX3N0cmlkZTIgPSBmYi0+cGl0Y2hlc1syXTsKPiAgCQlwcml2LT52aXUudmQxX2hlaWdodDIg PQo+IC0JCQlkcm1fZm9ybWF0X3BsYW5lX2hlaWdodChmYi0+aGVpZ2h0LAo+IC0JCQkJCQlmYi0+ Zm9ybWF0LT5mb3JtYXQsIDIpOwo+ICsJCQlkcm1fZm9ybWF0X2luZm9fcGxhbmVfaGVpZ2h0KGZi LT5mb3JtYXQsCj4gKwkJCQkJCWZiLT5oZWlnaHQsIDIpOwo+ICAJCURSTV9ERUJVRygicGxhbmUg MiBhZGRyIDB4JXggc3RyaWRlICVkIGhlaWdodCAlZFxuIiwKPiAgCQkJIHByaXYtPnZpdS52ZDFf YWRkcjIsCj4gIAkJCSBwcml2LT52aXUudmQxX3N0cmlkZTIsCj4gQEAgLTQ3OCw4ICs0NzgsOCBA QCBzdGF0aWMgdm9pZCBtZXNvbl9vdmVybGF5X2F0b21pY191cGRhdGUoc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gIAkJcHJpdi0+dml1LnZkMV9hZGRyMSA9IGdlbS0+cGFkZHIgKyBmYi0+b2Zm c2V0c1sxXTsKPiAgCQlwcml2LT52aXUudmQxX3N0cmlkZTEgPSBmYi0+cGl0Y2hlc1sxXTsKPiAg CQlwcml2LT52aXUudmQxX2hlaWdodDEgPQo+IC0JCQlkcm1fZm9ybWF0X3BsYW5lX2hlaWdodChm Yi0+aGVpZ2h0LAo+IC0JCQkJCQlmYi0+Zm9ybWF0LT5mb3JtYXQsIDEpOwo+ICsJCQlkcm1fZm9y bWF0X2luZm9fcGxhbmVfaGVpZ2h0KGZiLT5mb3JtYXQsCj4gKwkJCQkJCWZiLT5oZWlnaHQsIDEp Owo+ICAJCURSTV9ERUJVRygicGxhbmUgMSBhZGRyIDB4JXggc3RyaWRlICVkIGhlaWdodCAlZFxu IiwKPiAgCQkJIHByaXYtPnZpdS52ZDFfYWRkcjEsCj4gIAkJCSBwcml2LT52aXUudmQxX3N0cmlk ZTEsCj4gQEAgLTQ5MCw4ICs0OTAsOCBAQCBzdGF0aWMgdm9pZCBtZXNvbl9vdmVybGF5X2F0b21p Y191cGRhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gIAkJcHJpdi0+dml1LnZkMV9hZGRy MCA9IGdlbS0+cGFkZHIgKyBmYi0+b2Zmc2V0c1swXTsKPiAgCQlwcml2LT52aXUudmQxX3N0cmlk ZTAgPSBmYi0+cGl0Y2hlc1swXTsKPiAgCQlwcml2LT52aXUudmQxX2hlaWdodDAgPQo+IC0JCQlk cm1fZm9ybWF0X3BsYW5lX2hlaWdodChmYi0+aGVpZ2h0LAo+IC0JCQkJCQlmYi0+Zm9ybWF0LT5m b3JtYXQsIDApOwo+ICsJCQlkcm1fZm9ybWF0X2luZm9fcGxhbmVfaGVpZ2h0KGZiLT5mb3JtYXQs Cj4gKwkJCQkJCWZiLT5oZWlnaHQsIDApOwo+ICAJCURSTV9ERUJVRygicGxhbmUgMCBhZGRyIDB4 JXggc3RyaWRlICVkIGhlaWdodCAlZFxuIiwKPiAgCQkJIHByaXYtPnZpdS52ZDFfYWRkcjAsCj4g IAkJCSBwcml2LT52aXUudmQxX3N0cmlkZTAsCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2Ry bV9mb3VyY2MuaCBiL2luY2x1ZGUvZHJtL2RybV9mb3VyY2MuaAo+IGluZGV4IDZiNWE4MmIzMWJj NC4uNGVmOGNjYjVkMjM2IDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9mb3VyY2MuaAo+ ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9mb3VyY2MuaAo+IEBAIC0yNzcsNiArMjc3LDUwIEBAIGlu dCBkcm1fZm9ybWF0X2luZm9fcGxhbmVfY3BwKGNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8g KmluZm8sIGludCBwbGFuZSkKPiAgCXJldHVybiBpbmZvLT5jcHBbcGxhbmVdOwo+ICB9Cj4gIAo+ ICsvKioKPiArICogZHJtX2Zvcm1hdF9pbmZvX3BsYW5lX3dpZHRoIC0gd2lkdGggb2YgdGhlIHBs YW5lIGdpdmVuIHRoZSBmaXJzdCBwbGFuZQo+ICsgKiBAZm9ybWF0OiBwaXhlbCBmb3JtYXQgaW5m bwo+ICsgKiBAd2lkdGg6IHdpZHRoIG9mIHRoZSBmaXJzdCBwbGFuZQo+ICsgKiBAcGxhbmU6IHBs YW5lIGluZGV4Cj4gKyAqCj4gKyAqIFJldHVybnM6Cj4gKyAqIFRoZSB3aWR0aCBvZiBAcGxhbmUs IGdpdmVuIHRoYXQgdGhlIHdpZHRoIG9mIHRoZSBmaXJzdCBwbGFuZSBpcyBAd2lkdGguCj4gKyAq Lwo+ICtzdGF0aWMgaW5saW5lCj4gK2ludCBkcm1fZm9ybWF0X2luZm9fcGxhbmVfd2lkdGgoY29u c3Qgc3RydWN0IGRybV9mb3JtYXRfaW5mbyAqaW5mbywgaW50IHdpZHRoLAo+ICsJCQkJaW50IHBs YW5lKQo+ICt7Cj4gKwlpZiAoIWluZm8gfHwgcGxhbmUgPj0gaW5mby0+bnVtX3BsYW5lcykKPiAr CQlyZXR1cm4gMDsKPiArCj4gKwlpZiAocGxhbmUgPT0gMCkKPiArCQlyZXR1cm4gd2lkdGg7Cj4g Kwo+ICsJcmV0dXJuIHdpZHRoIC8gaW5mby0+aHN1YjsKPiArfQo+ICsKPiArLyoqCj4gKyAqIGRy bV9mb3JtYXRfaW5mb19wbGFuZV9oZWlnaHQgLSBoZWlnaHQgb2YgdGhlIHBsYW5lIGdpdmVuIHRo ZSBmaXJzdCBwbGFuZQo+ICsgKiBAZm9ybWF0OiBwaXhlbCBmb3JtYXQgaW5mbwo+ICsgKiBAaGVp Z2h0OiBoZWlnaHQgb2YgdGhlIGZpcnN0IHBsYW5lCj4gKyAqIEBwbGFuZTogcGxhbmUgaW5kZXgK PiArICoKPiArICogUmV0dXJuczoKPiArICogVGhlIGhlaWdodCBvZiBAcGxhbmUsIGdpdmVuIHRo YXQgdGhlIGhlaWdodCBvZiB0aGUgZmlyc3QgcGxhbmUgaXMgQGhlaWdodC4KPiArICovCj4gK3N0 YXRpYyBpbmxpbmUKPiAraW50IGRybV9mb3JtYXRfaW5mb19wbGFuZV9oZWlnaHQoY29uc3Qgc3Ry dWN0IGRybV9mb3JtYXRfaW5mbyAqaW5mbywgaW50IGhlaWdodCwKPiArCQkJCSBpbnQgcGxhbmUp Cj4gK3sKPiArCWlmICghaW5mbyB8fCBwbGFuZSA+PSBpbmZvLT5udW1fcGxhbmVzKQo+ICsJCXJl dHVybiAwOwo+ICsKPiArCWlmIChwbGFuZSA9PSAwKQo+ICsJCXJldHVybiBoZWlnaHQ7Cj4gKwo+ ICsJcmV0dXJuIGhlaWdodCAvIGluZm8tPnZzdWI7Cj4gK30KPiArCj4gIGNvbnN0IHN0cnVjdCBk cm1fZm9ybWF0X2luZm8gKl9fZHJtX2Zvcm1hdF9pbmZvKHUzMiBmb3JtYXQpOwo+ICBjb25zdCBz dHJ1Y3QgZHJtX2Zvcm1hdF9pbmZvICpkcm1fZm9ybWF0X2luZm8odTMyIGZvcm1hdCk7Cj4gIGNv bnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKgo+IEBAIC0yODUsOCArMzI5LDYgQEAgZHJtX2dl dF9mb3JtYXRfaW5mbyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICB1aW50MzJfdCBkcm1fbW9k ZV9sZWdhY3lfZmJfZm9ybWF0KHVpbnQzMl90IGJwcCwgdWludDMyX3QgZGVwdGgpOwo+ICB1aW50 MzJfdCBkcm1fZHJpdmVyX2xlZ2FjeV9mYl9mb3JtYXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwK PiAgCQkJCSAgICAgdWludDMyX3QgYnBwLCB1aW50MzJfdCBkZXB0aCk7Cj4gLWludCBkcm1fZm9y bWF0X3BsYW5lX3dpZHRoKGludCB3aWR0aCwgdWludDMyX3QgZm9ybWF0LCBpbnQgcGxhbmUpOwo+ IC1pbnQgZHJtX2Zvcm1hdF9wbGFuZV9oZWlnaHQoaW50IGhlaWdodCwgdWludDMyX3QgZm9ybWF0 LCBpbnQgcGxhbmUpOwo+ICB1bnNpZ25lZCBpbnQgZHJtX2Zvcm1hdF9pbmZvX2Jsb2NrX3dpZHRo KGNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8gKmluZm8sCj4gIAkJCQkJIGludCBwbGFuZSk7 Cj4gIHVuc2lnbmVkIGludCBkcm1fZm9ybWF0X2luZm9fYmxvY2tfaGVpZ2h0KGNvbnN0IHN0cnVj dCBkcm1fZm9ybWF0X2luZm8gKmluZm8sCj4gLS0gCj4gZ2l0LXNlcmllcyAwLjkuMQo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gClBhdWwg S29jaWFsa293c2tpLCBCb290bGluCkVtYmVkZGVkIExpbnV4IGFuZCBrZXJuZWwgZW5naW5lZXJp bmcKaHR0cHM6Ly9ib290bGluLmNvbQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB9F7C04AAC for ; Mon, 20 May 2019 11:33:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1DC020863 for ; Mon, 20 May 2019 11:33:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732995AbfETLdH (ORCPT ); Mon, 20 May 2019 07:33:07 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:37373 "EHLO relay8-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732957AbfETLdG (ORCPT ); Mon, 20 May 2019 07:33:06 -0400 X-Originating-IP: 90.88.22.185 Received: from aptenodytes (aaubervilliers-681-1-80-185.w90-88.abo.wanadoo.fr [90.88.22.185]) (Authenticated sender: paul.kocialkowski@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 7FDA81BF20D; Mon, 20 May 2019 11:32:59 +0000 (UTC) Date: Mon, 20 May 2019 13:32:59 +0200 From: Paul Kocialkowski To: Maxime Ripard Cc: Daniel Vetter , David Airlie , Maarten Lankhorst , Sean Paul , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Emil Velikov Subject: Re: [PATCH v3 5/7] drm/fourcc: Pass the format_info pointer to drm_format_plane_width/height Message-ID: <20190520113258.GC6789@aptenodytes> References: <27b0041c7977402df4a087c78d2849ffe51c9f1c.1558002671.git-series.maxime.ripard@bootlin.com> <514af1d489d80b8b1767e3716b663ce5103da6eb.1558002671.git-series.maxime.ripard@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <514af1d489d80b8b1767e3716b663ce5103da6eb.1558002671.git-series.maxime.ripard@bootlin.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu 16 May 19, 12:31, Maxime Ripard wrote: > So far, the drm_format_plane_height/width functions were operating on the > format's fourcc and was doing a lookup to retrieve the drm_format_info > structure and return the cpp. > > However, this is inefficient since in most cases, we will have the > drm_format_info pointer already available so we shouldn't have to perform a > new lookup. Some drm_fourcc functions also already operate on the > drm_format_info pointer for that reason, so the API is quite inconsistent > there. > > Let's follow the latter pattern and remove the extra lookup while being a > bit more consistent. > > In order to be extra consistent, also rename that function to > drm_format_info_plane_cpp and to a static function in the header to match > the current policy. The parameters order have also be changed to match the > other functions prototype. Same comment about plane being int instead of unsigned int, but I think we can fix that later. Another thing that I find odd is that the division by vsub/hsub is not rounded up, but again, it's something independent from your patch. Reviewed-by: Paul Kocialkowski Cheers, Paul > Reviewed-by: Emil Velikov > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/drm_fourcc.c | 48 +---------------------------- > drivers/gpu/drm/meson/meson_overlay.c | 12 +++---- > include/drm/drm_fourcc.h | 46 +++++++++++++++++++++++++-- > 3 files changed, 50 insertions(+), 56 deletions(-) > > diff --git a/drivers/gpu/drm/drm_fourcc.c b/drivers/gpu/drm/drm_fourcc.c > index 5f63fc74e265..35b459d186c5 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -333,54 +333,6 @@ drm_get_format_info(struct drm_device *dev, > EXPORT_SYMBOL(drm_get_format_info); > > /** > - * drm_format_plane_width - width of the plane given the first plane > - * @width: width of the first plane > - * @format: pixel format > - * @plane: plane index > - * > - * Returns: > - * The width of @plane, given that the width of the first plane is @width. > - */ > -int drm_format_plane_width(int width, uint32_t format, int plane) > -{ > - const struct drm_format_info *info; > - > - info = drm_format_info(format); > - if (!info || plane >= info->num_planes) > - return 0; > - > - if (plane == 0) > - return width; > - > - return width / info->hsub; > -} > -EXPORT_SYMBOL(drm_format_plane_width); > - > -/** > - * drm_format_plane_height - height of the plane given the first plane > - * @height: height of the first plane > - * @format: pixel format > - * @plane: plane index > - * > - * Returns: > - * The height of @plane, given that the height of the first plane is @height. > - */ > -int drm_format_plane_height(int height, uint32_t format, int plane) > -{ > - const struct drm_format_info *info; > - > - info = drm_format_info(format); > - if (!info || plane >= info->num_planes) > - return 0; > - > - if (plane == 0) > - return height; > - > - return height / info->vsub; > -} > -EXPORT_SYMBOL(drm_format_plane_height); > - > -/** > * drm_format_info_block_width - width in pixels of block. > * @info: pixel format info > * @plane: plane index > diff --git a/drivers/gpu/drm/meson/meson_overlay.c b/drivers/gpu/drm/meson/meson_overlay.c > index fb8515b2860c..55b3f2f2e608 100644 > --- a/drivers/gpu/drm/meson/meson_overlay.c > +++ b/drivers/gpu/drm/meson/meson_overlay.c > @@ -466,8 +466,8 @@ static void meson_overlay_atomic_update(struct drm_plane *plane, > priv->viu.vd1_addr2 = gem->paddr + fb->offsets[2]; > priv->viu.vd1_stride2 = fb->pitches[2]; > priv->viu.vd1_height2 = > - drm_format_plane_height(fb->height, > - fb->format->format, 2); > + drm_format_info_plane_height(fb->format, > + fb->height, 2); > DRM_DEBUG("plane 2 addr 0x%x stride %d height %d\n", > priv->viu.vd1_addr2, > priv->viu.vd1_stride2, > @@ -478,8 +478,8 @@ static void meson_overlay_atomic_update(struct drm_plane *plane, > priv->viu.vd1_addr1 = gem->paddr + fb->offsets[1]; > priv->viu.vd1_stride1 = fb->pitches[1]; > priv->viu.vd1_height1 = > - drm_format_plane_height(fb->height, > - fb->format->format, 1); > + drm_format_info_plane_height(fb->format, > + fb->height, 1); > DRM_DEBUG("plane 1 addr 0x%x stride %d height %d\n", > priv->viu.vd1_addr1, > priv->viu.vd1_stride1, > @@ -490,8 +490,8 @@ static void meson_overlay_atomic_update(struct drm_plane *plane, > priv->viu.vd1_addr0 = gem->paddr + fb->offsets[0]; > priv->viu.vd1_stride0 = fb->pitches[0]; > priv->viu.vd1_height0 = > - drm_format_plane_height(fb->height, > - fb->format->format, 0); > + drm_format_info_plane_height(fb->format, > + fb->height, 0); > DRM_DEBUG("plane 0 addr 0x%x stride %d height %d\n", > priv->viu.vd1_addr0, > priv->viu.vd1_stride0, > diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h > index 6b5a82b31bc4..4ef8ccb5d236 100644 > --- a/include/drm/drm_fourcc.h > +++ b/include/drm/drm_fourcc.h > @@ -277,6 +277,50 @@ int drm_format_info_plane_cpp(const struct drm_format_info *info, int plane) > return info->cpp[plane]; > } > > +/** > + * drm_format_info_plane_width - width of the plane given the first plane > + * @format: pixel format info > + * @width: width of the first plane > + * @plane: plane index > + * > + * Returns: > + * The width of @plane, given that the width of the first plane is @width. > + */ > +static inline > +int drm_format_info_plane_width(const struct drm_format_info *info, int width, > + int plane) > +{ > + if (!info || plane >= info->num_planes) > + return 0; > + > + if (plane == 0) > + return width; > + > + return width / info->hsub; > +} > + > +/** > + * drm_format_info_plane_height - height of the plane given the first plane > + * @format: pixel format info > + * @height: height of the first plane > + * @plane: plane index > + * > + * Returns: > + * The height of @plane, given that the height of the first plane is @height. > + */ > +static inline > +int drm_format_info_plane_height(const struct drm_format_info *info, int height, > + int plane) > +{ > + if (!info || plane >= info->num_planes) > + return 0; > + > + if (plane == 0) > + return height; > + > + return height / info->vsub; > +} > + > const struct drm_format_info *__drm_format_info(u32 format); > const struct drm_format_info *drm_format_info(u32 format); > const struct drm_format_info * > @@ -285,8 +329,6 @@ drm_get_format_info(struct drm_device *dev, > uint32_t drm_mode_legacy_fb_format(uint32_t bpp, uint32_t depth); > uint32_t drm_driver_legacy_fb_format(struct drm_device *dev, > uint32_t bpp, uint32_t depth); > -int drm_format_plane_width(int width, uint32_t format, int plane); > -int drm_format_plane_height(int height, uint32_t format, int plane); > unsigned int drm_format_info_block_width(const struct drm_format_info *info, > int plane); > unsigned int drm_format_info_block_height(const struct drm_format_info *info, > -- > git-series 0.9.1 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com