From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61C55C04AAC for ; Mon, 20 May 2019 13:06:51 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2CAED20856 for ; Mon, 20 May 2019 13:06:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OVB/Efvf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2CAED20856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:35437 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hSi0A-0008Ap-Eg for qemu-devel@archiver.kernel.org; Mon, 20 May 2019 09:06:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hShn6-0006Z5-21 for qemu-devel@nongnu.org; Mon, 20 May 2019 08:53:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hShn5-0000pe-4k for qemu-devel@nongnu.org; Mon, 20 May 2019 08:53:20 -0400 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:45832) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hShn4-0000nV-Tj for qemu-devel@nongnu.org; Mon, 20 May 2019 08:53:19 -0400 Received: by mail-ed1-x544.google.com with SMTP id g57so23664304edc.12 for ; Mon, 20 May 2019 05:53:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lcyudD+YHiLETyo03LrCcptJpEIAkkzDHtaRg2ZKb3w=; b=OVB/EfvfwJ1/ILkFnpEC5OB2F/wOeG1hojAYphm/Ivd7WGXP1ihEpnspUujdTDyg3X /8b20E5XBrCtdAfq9x6hxFqRBALr8sCnjwcgDoqMsSBd376IIh4sq0m66KNHX+RBTxnc e6Jo3X2+2Fyb4N8XD9scWoI1VD/LVoXShRcscrSTzPKbiG7rPqw4K1z2FAjKDTGgLj/x 3a2KoittXdhexRxe5a1qG2Fl9Bm7htl6sv57uQm98nmhPHhdFu2y3WJy3jWDRfxnmc5I qC8xTtAoKweTZ57ihZXELZKxbkp3ir/RBlw7d9VW0+q27477zNdylsYdsVnjLAW1rzX6 RUzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=lcyudD+YHiLETyo03LrCcptJpEIAkkzDHtaRg2ZKb3w=; b=JgdCX+5+uZJbZglgBfFroQbbZrxxtH9rQY3rt+e/aoYRYdVI4/Ve9E6it+dtBtHiti pZtO5JH06qqZWKKiALWzWZbLpBL4l00e2wXM2HBELhiAKwLu9VdDVLvrp1ieB24y8p3w juehHOxTbCxESN41+hoAfVj420xLiG9ysqaz/73OPLygMg4eRzumGtTOqk1VQ2+sDu/9 7ayWOmDoD0C4RlErwTE5prGRegBs3bvW4TW4TY/SugyT8JWNn9FAoNyyFj38HM4q5etg Yvto/PShdP1s0XJjn4qteC0M0zuyBOmyB3VlJytvCLP4d+flP9nsR9scZk8bKQqxiEMX uN7w== X-Gm-Message-State: APjAAAXwU6BQPQKwfy0wf2DbDlBb2ZdLQ6btlaoEqHw8yS/wXRrZllYG AHHOcTM/ifn6a2pt9G3OZUY= X-Google-Smtp-Source: APXvYqxCujIXVXO/vtoL5p0ldOouXtOGTYmGzbX6YZ5Yuxns9vLdXnn6qTwc41bjyVST27kFyEjaGg== X-Received: by 2002:a50:87ab:: with SMTP id a40mr73129497eda.188.1558356795070; Mon, 20 May 2019 05:53:15 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id c49sm5638205eda.58.2019.05.20.05.53.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 May 2019 05:53:14 -0700 (PDT) Date: Mon, 20 May 2019 12:53:13 +0000 From: Wei Yang To: Juan Quintela Message-ID: <20190520125313.wiiut3u7mkdedib4@master> References: <20190515121544.4597-1-quintela@redhat.com> <20190515121544.4597-6-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515121544.4597-6-quintela@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::544 Subject: Re: [Qemu-devel] [PATCH v3 5/8] migration: Add multifd-compress parameter X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Wei Yang Cc: Laurent Vivier , Thomas Huth , Markus Armbruster , qemu-devel@nongnu.org, Paolo Bonzini , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, May 15, 2019 at 02:15:41PM +0200, Juan Quintela wrote: >Signed-off-by: Juan Quintela > >--- >Rename it to NONE >Fix typos (dave) >--- > hmp.c | 17 +++++++++++++++++ > hw/core/qdev-properties.c | 13 +++++++++++++ > include/hw/qdev-properties.h | 1 + > migration/migration.c | 16 ++++++++++++++++ > qapi/migration.json | 30 +++++++++++++++++++++++++++--- > tests/migration-test.c | 13 ++++++++++--- > 6 files changed, 84 insertions(+), 6 deletions(-) > >diff --git a/hmp.c b/hmp.c >index 56a3ed7375..5732c34249 100644 >--- a/hmp.c >+++ b/hmp.c >@@ -38,6 +38,7 @@ > #include "qapi/qapi-commands-run-state.h" > #include "qapi/qapi-commands-tpm.h" > #include "qapi/qapi-commands-ui.h" >+#include "qapi/qapi-visit-migration.h" > #include "qapi/qmp/qdict.h" > #include "qapi/qmp/qerror.h" > #include "qapi/string-input-visitor.h" >@@ -435,6 +436,9 @@ void hmp_info_migrate_parameters(Monitor *mon, const QDict *qdict) > monitor_printf(mon, "%s: %u\n", > MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_CHANNELS), > params->multifd_channels); >+ monitor_printf(mon, "%s: %s\n", >+ MigrationParameter_str(MIGRATION_PARAMETER_MULTIFD_COMPRESS), >+ MultifdCompress_str(params->multifd_compress)); > monitor_printf(mon, "%s: %" PRIu64 "\n", > MigrationParameter_str(MIGRATION_PARAMETER_XBZRLE_CACHE_SIZE), > params->xbzrle_cache_size); >@@ -1736,6 +1740,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) > MigrateSetParameters *p = g_new0(MigrateSetParameters, 1); > uint64_t valuebw = 0; > uint64_t cache_size; >+ MultifdCompress compress_type; > Error *err = NULL; > int val, ret; > >@@ -1821,6 +1826,18 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict) > p->has_multifd_channels = true; > visit_type_int(v, param, &p->multifd_channels, &err); > break; >+ case MIGRATION_PARAMETER_MULTIFD_COMPRESS: >+ p->has_multifd_compress = true; >+ visit_type_MultifdCompress(v, param, &compress_type, &err); >+ if (err) { >+ break; >+ } >+ if (compress_type < 0 || compress_type >= MULTIFD_COMPRESS__MAX) { A warning during build: hmp.c:1835:27: warning: comparison of unsigned enum expression < 0 is always false [-Wtautological-compare] if (compress_type < 0 || compress_type >= MULTIFD_COMPRESS__MAX) { -- Wei Yang Help you, Help me