From: Brian Foster <bfoster@redhat.com>
To: bugzilla-daemon@bugzilla.kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: Re: [Bug 203655] XFS: Assertion failed: 0, xfs_log_recover.c, line: 551
Date: Mon, 20 May 2019 12:12:00 -0400 [thread overview]
Message-ID: <20190520161200.GB32784@bfoster> (raw)
In-Reply-To: <bug-203655-201763-WLgC3hGYRF@https.bugzilla.kernel.org/>
On Mon, May 20, 2019 at 04:02:06PM +0000, bugzilla-daemon@bugzilla.kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=203655
>
> Eric Sandeen (sandeen@sandeen.net) changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |sandeen@sandeen.net
>
> --- Comment #2 from Eric Sandeen (sandeen@sandeen.net) ---
> I think the question here is whether the ASSERT() is valid - we don't ever want
> to assert on disk corruption, it should only be for "this should never happen
> in the code" scenarios.
>
Makes sense. It's not clear to me whether that's the intent of the bug,
but regardless I think it would be reasonable to kill off that
particular assert. We already warn and return an error.
Brian
> --
> You are receiving this mail because:
> You are watching the assignee of the bug.
next prev parent reply other threads:[~2019-05-20 16:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 10:47 [Bug 203655] New: XFS: Assertion failed: 0, xfs_log_recover.c, line: 551 bugzilla-daemon
2019-05-20 15:51 ` Brian Foster
2019-05-20 15:51 ` [Bug 203655] " bugzilla-daemon
2019-05-20 16:02 ` bugzilla-daemon
2019-05-20 16:12 ` Brian Foster [this message]
2019-05-20 22:46 ` Dave Chinner
2019-05-20 16:12 ` bugzilla-daemon
2019-05-20 23:14 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520161200.GB32784@bfoster \
--to=bfoster@redhat.com \
--cc=bugzilla-daemon@bugzilla.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.