All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] core: make it possible to check flake8 like we check package
Date: Mon, 20 May 2019 21:07:26 +0200	[thread overview]
Message-ID: <20190520190726.GA2229@scaer> (raw)
In-Reply-To: <20190520200346.453c08b1@gmx.net>

Peter, All,

On 2019-05-20 20:03 +0200, Peter Seiderer spake thusly:
> On Mon, 20 May 2019 19:34:16 +0200, Peter Seiderer <ps.report@gmx.net> wrote:
> > Did a local run with 'make check-flake8', produced 7636 warnings ;-) , you can add my
> Most warnings where from the download/dl directory,

Aha! ;-)

> without only 96
> warnings in support and utils are left:
> 
> support/testing/infra/__init__.py:91:29: W605 invalid escape sequence '\['

Yes, like me you are running a pretty recent distribution, that has
pycodestyle 2.4.0 (or more recent), which introduced a new warning,
W605.

I started fixing it locally, but I am not totally sure:

 1- if we really need to fix it: the warning is about python3, while
    quite a few reported errors apply to python2 code.

 2- how we should fix it. The obvious solution seems to prefix all such
    strings with a leading 'r', like so:  r"the\.pattern\sstrings".
    However, doing so will change the behaviour, for example, of
    check-package, which starts reportign new issues with our mk files
    (more on that in a later mail...)

However, this very patch is indeed about _calling_ flake8 from the
Makefile instead of only from a gitlab pipeline.

Thanks for the testing! :-)

Regards,
Yann E. MORIN.

> support/testing/infra/__init__.py:91:67: W605 invalid escape sequence '\]'
> support/testing/tests/core/test_timezone.py:7:9: E117 over-indented
> utils/check-package:48:40: W605 invalid escape sequence '\.'
> utils/check-package:48:42: W605 invalid escape sequence '\S'
> 
> [...]
> 
> utils/checkpackagelib/lib_config.py:65:48: W605 invalid escape sequence '\S'
> utils/checkpackagelib/lib_mk.py:22:28: W605 invalid escape sequence '\s'
> 
> [...]
> 
> utils/checkpackagelib/lib_mk.py:78:50: W605 invalid escape sequence '\+'
> utils/checkpackagelib/lib_mk.py:78:57: W605 invalid escape sequence '\s'
> utils/checkpackagelib/lib_mk.py:78:60: W605 invalid escape sequence '\$'
> utils/checkpackagelib/lib_mk.py:78:62: W605 invalid escape sequence '\('
> utils/checkpackagelib/lib_mk.py:78:67: W605 invalid escape sequence '\)'
> 
> [...]
> 
> utils/checkpackagelib/lib_patch.py:13:32: W605 invalid escape sequence '\d'
> utils/checkpackagelib/lib_patch.py:23:42: W605 invalid escape sequence '\s'
> utils/checkpackagelib/lib_patch.py:23:45: W605 invalid escape sequence '\['
> utils/checkpackagelib/lib_patch.py:23:52: W605 invalid escape sequence '\s'
> utils/checkpackagelib/lib_patch.py:23:55: W605 invalid escape sequence '\d'
> utils/checkpackagelib/lib_patch.py:23:59: W605 invalid escape sequence '\d'
> utils/checkpackagelib/lib_patch.py:23:62: W605 invalid escape sequence '\]'
> utils/checkpackagelib/lib.py:56:1: E302 expected 2 blank lines, found 1
> utils/getdeveloperlib.py:12:36: W605 invalid escape sequence '\+'
> utils/getdeveloperlib.py:12:38: W605 invalid escape sequence '\$'
> utils/getdeveloperlib.py:12:40: W605 invalid escape sequence '\('
> utils/getdeveloperlib.py:12:47: W605 invalid escape sequence '\$'
> utils/getdeveloperlib.py:12:49: W605 invalid escape sequence '\('
> utils/getdeveloperlib.py:12:74: W605 invalid escape sequence '\)'
> utils/getdeveloperlib.py:12:76: W605 invalid escape sequence '\)'
> utils/getdeveloperlib.py:35:33: W605 invalid escape sequence '\$'
> utils/getdeveloperlib.py:35:35: W605 invalid escape sequence '\('
> utils/getdeveloperlib.py:35:42: W605 invalid escape sequence '\$'
> utils/getdeveloperlib.py:35:44: W605 invalid escape sequence '\('
> utils/getdeveloperlib.py:35:69: W605 invalid escape sequence '\)'
> utils/getdeveloperlib.py:35:71: W605 invalid escape sequence '\)'
> utils/getdeveloperlib.py:128:32: W605 invalid escape sequence '\s'
> utils/getdeveloperlib.py:142:41: W605 invalid escape sequence '\.'
> utils/getdeveloperlib.py:142:45: W605 invalid escape sequence '\.'
> utils/scanpypi:99:22: W605 invalid escape sequence '\w'
> utils/scanpypi:340:37: W605 invalid escape sequence '\w'
> utils/scanpypi:454:60: W605 invalid escape sequence '\('
> utils/scanpypi:454:64: W605 invalid escape sequence '\)'
> 
> Regards,
> Peter
> 
> >
> > Tested-by: Peter Seiderer <ps.report@gmx.net>
> >
> > Regards,
> > Peter
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2019-05-20 19:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19 16:44 [Buildroot] [PATCH] core: make it possible to check flake8 like we check package Yann E. MORIN
2019-05-20 17:34 ` Peter Seiderer
2019-05-20 18:03   ` Peter Seiderer
2019-05-20 19:07     ` Yann E. MORIN [this message]
2019-05-24  8:04 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190520190726.GA2229@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.