All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] libnfc: Fix build with musl
Date: Tue, 21 May 2019 09:02:31 +0300	[thread overview]
Message-ID: <20190521060231.GC9971@localhost> (raw)
In-Reply-To: <20190521052103.2096-1-raj.khem@gmail.com>

On Mon, May 20, 2019 at 10:21:03PM -0700, Khem Raj wrote:
>...
> +--- a/libnfc/buses/usbbus.h
> ++++ b/libnfc/buses/usbbus.h
> +@@ -35,6 +35,8 @@
> + 
> + #ifndef _WIN32
> + // Under POSIX system, we use libusb (>= 0.1.12)
> ++#define _GNU_SOURCE
> ++#include <stdint.h>
>...

Defining feature test macros after headers have already been included is 
documented to be wrong, and can lead to nasty runtime breakages.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



      reply	other threads:[~2019-05-21  6:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-21  5:21 [meta-oe][PATCH] libnfc: Fix build with musl Khem Raj
2019-05-21  6:02 ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190521060231.GC9971@localhost \
    --to=bunk@stusta.de \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.