From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/7] libxfs: fix argument to xfs_trans_add_item
Date: Tue, 21 May 2019 01:34:58 -0700 [thread overview]
Message-ID: <20190521083458.GD533@infradead.org> (raw)
In-Reply-To: <1558410427-1837-5-git-send-email-sandeen@redhat.com>
On Mon, May 20, 2019 at 10:47:04PM -0500, Eric Sandeen wrote:
> The hack of casting an inode_log_item or buf_log_item to a
> xfs_log_item_t is pretty gross; yes it's the first member in the
> structure, but yuk. Pass in the correct structure member.
>
> This was fixed in the kernel with commit e98c414f9
> ("xfs: simplify log item descriptor tracking")
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> Reviewed-by: Allison Collins <allison.henderson@oracle.com>
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-05-21 8:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 3:47 [PATCH 0/7] xfsprogs: libxfs spring cleaning take 3 Eric Sandeen
2019-05-21 3:47 ` [PATCH 1/7] libxfs: Remove XACT_DEBUG #ifdefs Eric Sandeen
2019-05-21 8:33 ` Christoph Hellwig
2019-05-21 3:47 ` [PATCH 2/7] libxfs: rename bli_format to avoid confusion with bli_formats Eric Sandeen
2019-05-21 8:33 ` Christoph Hellwig
2019-05-21 3:47 ` [PATCH 3/7] libxfs: factor common xfs_trans_bjoin code Eric Sandeen
2019-05-21 8:33 ` Christoph Hellwig
2019-05-21 3:47 ` [PATCH 4/7] libxfs: fix argument to xfs_trans_add_item Eric Sandeen
2019-05-21 8:34 ` Christoph Hellwig [this message]
2019-05-21 3:47 ` [PATCH 5/7] xfs: factor log item initialisation Eric Sandeen
2019-05-21 8:36 ` Christoph Hellwig
2019-05-21 3:47 ` [PATCH 6/7] libxfs: create current_time helper and sync xfs_trans_ichgtime Eric Sandeen
2019-05-21 8:36 ` Christoph Hellwig
2019-05-21 3:47 ` [PATCH 7/7] libxfs: share kernel's xfs_trans_inode.c Eric Sandeen
2019-05-21 3:52 ` [PATCH 7/7 V2] " Eric Sandeen
2019-05-21 8:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521083458.GD533@infradead.org \
--to=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.